[{"id":38316,"web_url":"https://patchwork.libcamera.org/comment/38316/","msgid":"<1cc39a5f-50e5-423e-842b-4e001f3da722@ideasonboard.com>","date":"2026-03-02T10:37:26","subject":"Re: [PATCH] ipa: rpi: awb_nn: Remove unused constexpr variable","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 03. 02. 11:25 keltezéssel, Naushir Patuck írta:\n> The kDefaultCT variable is unused, remove it.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n\nPossibly:\n\n Fixes: 045bfb1b8f0a (\"ipa: rpi: controller: awb: Add Neural Network AWB\")\n\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rpi/controller/rpi/awb_nn.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> index 1c20512638dd..c382f63d5f21 100644\n> --- a/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> +++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> @@ -35,8 +35,6 @@ using namespace libcamera;\n> \n> LOG_DECLARE_CATEGORY(RPiAwb)\n> \n> -constexpr double kDefaultCT = 4500.0;\n> -\n> /*\n> * The neural networks are trained to work on images rendered at a canonical\n> * colour temperature. That value is 5000K, which must be reproduced here.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E0B5BE086\n\tfor ;\n\tMon, 2 Mar 2026 10:37:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B828C62380;\n\tMon, 2 Mar 2026 11:37:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B413362080\n\tfor ;\n\tMon, 2 Mar 2026 11:37:29 +0100 (CET)","from [192.168.33.96] (185.182.214.224.nat.pool.zt.hu\n\t[185.182.214.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86CC998A;\n\tMon, 2 Mar 2026 11:36:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D/5GfaRD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772447788;\n\tbh=1SDgV+zU0ZjbxacUsixAtXbRHT+/HEj1HH7Q3ofWAPg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=D/5GfaRD4Zh/pDQSFNXmDFNMaB53GKNtC/aYv1saF8PNg5dv73XLP1ASV0nNQ+TRc\n\tgiCx2D9cjKoGQyKw9euTGtn6RKjCCj7YXIAA1pt+87rhDKfJbLGBUobzoYy9AhnMNZ\n\tJ3uM4zbX3x4m78EY5C1DdjBWjpJdF3qzJVqWSJzE=","Message-ID":"<1cc39a5f-50e5-423e-842b-4e001f3da722@ideasonboard.com>","Date":"Mon, 2 Mar 2026 11:37:26 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: rpi: awb_nn: Remove unused constexpr variable","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"david.plowman@raspberrypi.com","References":"<20260302102540.824771-1-naush@raspberrypi.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260302102540.824771-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38317,"web_url":"https://patchwork.libcamera.org/comment/38317/","msgid":"<177244872858.2762712.2410192731239442812@ping.linuxembedded.co.uk>","date":"2026-03-02T10:52:08","subject":"Re: [PATCH] ipa: rpi: awb_nn: Remove unused constexpr variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-03-02 10:37:26)\n> 2026. 03. 02. 11:25 keltezéssel, Naushir Patuck írta:\n> > The kDefaultCT variable is unused, remove it.\n> > \n> > Signed-off-by: Naushir Patuck \n> > ---\n> \n> Possibly:\n> \n> Fixes: 045bfb1b8f0a (\"ipa: rpi: controller: awb: Add Neural Network AWB\")\n\nThat would then add this patch to the bug reports on the release notes,\nso I'd probably leave that out in this instance.\n\nRemoving an unused variable probably doesn't cross the threshold into\nfixing a bug, but it's still a valid patch so:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> \n> Reviewed-by: Barnabás Pőcze \n> \n> \n> > src/ipa/rpi/controller/rpi/awb_nn.cpp | 2 --\n> > 1 file changed, 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> > index 1c20512638dd..c382f63d5f21 100644\n> > --- a/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> > +++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp\n> > @@ -35,8 +35,6 @@ using namespace libcamera;\n> > \n> > LOG_DECLARE_CATEGORY(RPiAwb)\n> > \n> > -constexpr double kDefaultCT = 4500.0;\n> > -\n> > /*\n> > * The neural networks are trained to work on images rendered at a canonical\n> > * colour temperature. That value is 5000K, which must be reproduced here.\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3797DC0DA4\n\tfor ;\n\tMon, 2 Mar 2026 10:52:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C72F62381;\n\tMon, 2 Mar 2026 11:52:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 999FA62080\n\tfor ;\n\tMon, 2 Mar 2026 11:52:11 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F5EE98A;\n\tMon, 2 Mar 2026 11:51:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q058xP0u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772448670;\n\tbh=5q9cMZPtP88DAWLGfeGHJhfE1MNCaKbueJ7cHKKerKE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=q058xP0ujFRDfuJWNeVjV0sb84F1GchpcS7N+vNU5pY6vIi1qdqJ6RpGLUTZ7/DiZ\n\tQ2s06DIMn5moFrPscv5vRtlPACNoG77AqdN00EPs/8OyTNC1nr6yY09m/+HHrt81xx\n\tYR+JMz6lHJB1ICowTkPPcKxn6jAYMa0HbUcufMgg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<1cc39a5f-50e5-423e-842b-4e001f3da722@ideasonboard.com>","References":"<20260302102540.824771-1-naush@raspberrypi.com>\n\t<1cc39a5f-50e5-423e-842b-4e001f3da722@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rpi: awb_nn: Remove unused constexpr variable","From":"Kieran Bingham ","Cc":"david.plowman@raspberrypi.com","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tNaushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 02 Mar 2026 10:52:08 +0000","Message-ID":"<177244872858.2762712.2410192731239442812@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]