[{"id":38296,"web_url":"https://patchwork.libcamera.org/comment/38296/","msgid":"<83c912fd-0635-4600-8d65-cbb609bf87ba@oss.qualcomm.com>","date":"2026-02-24T18:50:58","subject":"Re: [PATCH] libcamera: software_isp: Set initial values of\n\tDebayerParams","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 23-Feb-26 15:19, Milan Zamazal wrote:\n> Debayer parameters and processing are currently run asynchronously.\n> This can lead to assertion errors in case the processing tries to use\n> not yet computed debayer parameters. To prevent this situation, specify\n> some default values for DebayerParams members. This doesn't make\n> correct parameters but prevents crashes or other crazy behaviours at\n> least.\n> \n> Note this patch is just a workaround. The mutually asynchronous\n> parameters computation and processing can cause more problems, like\n> using parameters computed for a different frame. But it is non-trivial\n> to fix that; in the meantime, setting the default values solves the\n> worst problem.\n> \n> Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/311\n> Signed-off-by: Milan Zamazal \n\nThanks, patch looks good to me:\n\nReviewed-by: Hans de Goede \n\nRegards,\n\nHans\n\n\n\n> ---\n> .../libcamera/internal/software_isp/debayer_params.h | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 1c0412d75..6772b43bc 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -18,11 +18,13 @@\n> namespace libcamera {\n> \n> struct DebayerParams {\n> -\tMatrix combinedMatrix;\n> -\tRGB blackLevel;\n> -\tfloat gamma;\n> -\tfloat contrastExp;\n> -\tRGB gains;\n> +\tMatrix combinedMatrix = { { 1.0, 0.0, 0.0,\n> +\t\t\t\t\t\t 0.0, 1.0, 0.0,\n> +\t\t\t\t\t\t 0.0, 0.0, 1.0 } };\n> +\tRGB blackLevel = RGB({ 0.0, 0.0, 0.0 });\n> +\tfloat gamma = 1.0;\n> +\tfloat contrastExp = 1.0;\n> +\tRGB gains = RGB({ 1.0, 1.0, 1.0 });\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3AD2C3237\n\tfor ;\n\tTue, 24 Feb 2026 18:51:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0A4F622A2;\n\tTue, 24 Feb 2026 19:51:03 +0100 (CET)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC2F262080\n\tfor ;\n\tTue, 24 Feb 2026 19:51:02 +0100 (CET)","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61OFlNx44044554 for ;\n\tTue, 24 Feb 2026 18:51:01 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chexegpyp-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tTue, 24 Feb 2026 18:51:01 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8cb3ad1b81aso7705627985a.2\n\tfor ;\n\tTue, 24 Feb 2026 10:51:01 -0800 (PST)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9088c8fc30sm436972366b.63.2026.02.24.10.50.58\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 24 Feb 2026 10:50:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"AVBBikAx\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"MfvEf2FQ\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tukM/eBSKP3dboztR0RHenInb24WWGWMOoMhSQJIVvww=; b=AVBBikAxyikfg/NV\n\tk0P8e9mfP5pMUsjO7a36HU3+2MPdaH5UI7tAtKKvlNp0/TsHcTOQ9mAnSxyQacSt\n\tVs/dz7r2i2Rp31IHqgVPiB73hR9VMYkM1kHE6Vj+R4zLBFFErvJk9n88jaAxlFvV\n\tdeQpJRzZMx68J8cyETqW9dakDfXOFHZwJ94Wlms8lG3F7mLO/uvxFGS98e+G9vql\n\tFE68d9SrLZ/7Il9+9jD/5lliO1GJ3yE9uFjD86VvMTIT+kCAI8KQlZ+XIZ0dhmvZ\n\tq/nOWtJHsAkML8el4Bs5Ybl0zxDdHekoOTAOAoXxH4o7cmMK66uVAS3ACt+YsSEN\n\tTSOXcg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771959060; x=1772563860;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=ukM/eBSKP3dboztR0RHenInb24WWGWMOoMhSQJIVvww=;\n\tb=MfvEf2FQv09k+XdhbkLogANP+WU2iT9RcTG4EIq6HYyOhl1KpxHwDIqVqdmJs0Vo2A\n\tzCiwuH0ixeYiwYL6Pol5YS2eTPRc0pk8EkUyiJ+K/8Lm61uORiJ0y/p1lw5YEU4gqLlQ\n\tBvgzNyJQIj/6UYAjihrc2rtx0ciseUbKfY0P0hrBJabehHGANU5Tj+/f85RMGC12h/fM\n\tP42InCAqpeuxfmoMHAKVQt8P68e+5knnq8svMvpJmZab4GoNwmM8zXyTPRslq4NAVtyh\n\tG+1ZjwfZ9CAOjXhacrdW0XKgzlaR3wqovPH75YeyL9A0Ni6N7XBFwtdD/9uVlP766znK\n\tRC/A=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771959060; x=1772563860;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ukM/eBSKP3dboztR0RHenInb24WWGWMOoMhSQJIVvww=;\n\tb=ERNxn3PiGug1Z6Nc1//kWw16WdTMnSs24m07NO8eoDMbFHtJHyxWIe5T8zPDvrSg55\n\tFxQ8G2fJsvc64paCgYPYgzJpUyLs4KIDWwwgfnhT69ANhuU0iUk2NJMiGF5W1/dSHD7T\n\tvBg6HHfeteqXcjmXmPva995zL03tKTqBTXusWp5NSnHxBqRITb7ad0RgJUEBx1XbVMmP\n\tMtvQUGYBIFMSUsEtnOUlvxCRbhU7VJIrXeeEdCdjeovM9KWZMQrs4D6xSQDXzB7VWP2A\n\tniMoomOc2rXN5mGzfUFoyQXTi5yKWq0xKs4pJ3pHDvLO6X6aCpYTDcuxqDu05IWwfiQc\n\tMPIg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXw4DBef3czdhsLjiQlqhYq+MCoaLPzUd45L+ixEydpIadp1LrVoc1vcQGNVnI6mY2dKYVFj03qCLAOrOu0WLI=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yy4JCn5/DwkhoKpsDyx9CWWLhGWEefthc1HKBpsRundQH1B/4kV\n\t2dULTyoTHnnWaVvEVYm1C4JUi0CIMKHxsgL/zSnyAvuSCnskbfGFD3pxzhe+xcbhKoUP5FsClIB\n\t/zUzE4Lp4/m1sksPJDDIHO0XI16aR9fOrSqNJY/BO0nHAa4udC1CptENQ8+fwoX1wHvoBg4oZAL\n\tCC5eZ4hUnb","X-Gm-Gg":"AZuq6aKT3S0h4LEIR1jDTFNf0DOhUEhct3KkbD2g0M5y8Jn7hBYknHKhYeTBbSmm2hH\n\t7E5AEf3QOQZWv2xAvPpROBBJGjw2PEOQeXuQRB3tq7bWuL1bV93A8tDe3kTZRqNO7Iye+VMPkJH\n\tP/KDXf325vzC0fe+g/ahfVBR19061ZTlNwsm42qNEhQKZeaWMP3VV9GU3JT1yJY/T20PBaftjZw\n\t7CAa24apUCgqi3vncKyPn556fMmOD9T5hSindp1Vi8BrRrA0HCQxBXN47EI98LqHay0II9Ernx3\n\tXl51O8WaYN+q7ClCkw24SFbksR7k+mDvLRH2YfuuuGObQbOgM5CknWXdNIdDkX8he1+MZS19oMN\n\tEFNkrVBco2kf+GQ7RueyKClDMYUk04OTI6FJNxNTqG8u/GLraKsjAPof2BoRPF13+kT7R+4g2z+\n\tjPtsOQ89wf7aT9CIOVT0ZMq+WYls0UTvtrH98Cyc9EJ+eJk29zcG7g1DsXxZcJw45jkQizgcq5V\n\tSo7EDR8O+SeKTYX","X-Received":["by 2002:a05:620a:319b:b0:8ca:fe7f:7324 with SMTP id\n\taf79cd13be357-8cb8ca6e1b3mr1727260585a.53.1771959060433; \n\tTue, 24 Feb 2026 10:51:00 -0800 (PST)","by 2002:a05:620a:319b:b0:8ca:fe7f:7324 with SMTP id\n\taf79cd13be357-8cb8ca6e1b3mr1727256685a.53.1771959059836; \n\tTue, 24 Feb 2026 10:50:59 -0800 (PST)"],"Message-ID":"<83c912fd-0635-4600-8d65-cbb609bf87ba@oss.qualcomm.com>","Date":"Tue, 24 Feb 2026 19:50:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"johannes.goede@oss.qualcomm.com","Subject":"Re: [PATCH] libcamera: software_isp: Set initial values of\n\tDebayerParams","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","References":"<20260223141945.58779-1-mzamazal@redhat.com>","Content-Language":"en-US, nl","In-Reply-To":"<20260223141945.58779-1-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjI0MDE2MSBTYWx0ZWRfXyGJsHoptrNoM\n\t0YuEpo12TwpFmbcHPLm43XzAGvKRYHOV0+hTxgnDvG/DUq0+L8T2HTdy3Cua+INv5FL7bkREcwf\n\tDV1eG/CubCmbrBCRTgy6DS4Di3vvKIUT19YbiFM6HclyV3m1S/oZ51nFtvpPKXriqcaqRzGqFBI\n\t+k3xpWPRXZD92YbsPm6If0HdbUxn3mT9xnASZOHmDpxy5gA8cx+DIbMdq8/FqoOtf45qQEfsVzY\n\tyQRUc36zF9DzllCZKjLjlA6OBpw+klvOJaTD9UEbyeOs+YqpxN+XKfK/L2GWVTtfdgmH23GgHgR\n\tVaFxsNu6jekW6gu3DEUKwhgDcBPPkRqEkqc+YVo35oB7HpVkH5PigE7pqyNCOd6KrzUBomz3iDV\n\tkJBF8pm9CUn8GG/EPUYKOEDR0Gt1ZQQfVnvc/CO3pTIBuVDNjA4HWBFaO4VoV1ZAig72iWIlbb5\n\tuDVhn+U34/0EVa5BDcw==","X-Authority-Analysis":"v=2.4 cv=V85wEOni c=1 sm=1 tr=0 ts=699df315 cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=e5mUnYsNAAAA:8\n\ta=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=pyelzev1xuxT6oErfSIA:9\n\ta=QEXdDO2ut3YA:10\n\ta=IoWCM6iH3mJn3m4BftBB:22 a=Vxmtnl_E_bksehYqCbjh:22","X-Proofpoint-GUID":"AEbB_7PwUEVR4clG1KirletQRuFY03Sx","X-Proofpoint-ORIG-GUID":"AEbB_7PwUEVR4clG1KirletQRuFY03Sx","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-24_02,2026-02-23_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\timpostorscore=0 bulkscore=0 malwarescore=0 priorityscore=1501\n\tspamscore=0\n\tsuspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0\n\tclxscore=1015\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2602240161","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38300,"web_url":"https://patchwork.libcamera.org/comment/38300/","msgid":"<177202069583.172242.15090756889421768416@ping.linuxembedded.co.uk>","date":"2026-02-25T11:58:15","subject":"Re: [PATCH] libcamera: software_isp: Set initial values of\n\tDebayerParams","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2026-02-23 14:19:45)\n> Debayer parameters and processing are currently run asynchronously.\n> This can lead to assertion errors in case the processing tries to use\n> not yet computed debayer parameters. To prevent this situation, specify\n> some default values for DebayerParams members. This doesn't make\n> correct parameters but prevents crashes or other crazy behaviours at\n> least.\n> \n> Note this patch is just a workaround. The mutually asynchronous\n> parameters computation and processing can cause more problems, like\n> using parameters computed for a different frame. But it is non-trivial\n> to fix that; in the meantime, setting the default values solves the\n> worst problem.\n\nI think these look like sane initialisation defaults.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/311\n> Signed-off-by: Milan Zamazal \n> ---\n> .../libcamera/internal/software_isp/debayer_params.h | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 1c0412d75..6772b43bc 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -18,11 +18,13 @@\n> namespace libcamera {\n> \n> struct DebayerParams {\n> - Matrix combinedMatrix;\n> - RGB blackLevel;\n> - float gamma;\n> - float contrastExp;\n> - RGB gains;\n> + Matrix combinedMatrix = { { 1.0, 0.0, 0.0,\n> + 0.0, 1.0, 0.0,\n> + 0.0, 0.0, 1.0 } };\n> + RGB blackLevel = RGB({ 0.0, 0.0, 0.0 });\n> + float gamma = 1.0;\n> + float contrastExp = 1.0;\n> + RGB gains = RGB({ 1.0, 1.0, 1.0 });\n> };\n> \n> } /* namespace libcamera */\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 697F9C3237\n\tfor ;\n\tWed, 25 Feb 2026 11:58:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F958622AE;\n\tWed, 25 Feb 2026 12:58:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0372761FA0\n\tfor ;\n\tWed, 25 Feb 2026 12:58:18 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B220E79;\n\tWed, 25 Feb 2026 12:57:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Me3CxlM9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772020641;\n\tbh=21eY2Yj1COct8do6YyvTZVatf0bgR1SJy+kPZRR4Vz4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Me3CxlM9p7DD63v2jYOfM0WjUfojGt0rWoWUFKJvZ7KSLmzFPfu3JYMX/I71n1nUS\n\tP4LOkAXjxuv+3N+0H1qe0gz63ApG3O3Hwjk6IO/Cv43IgIvVQTQGdgsfPnQRdirWaD\n\tEAqqoVohMacLJf6RU/Bkd/Pp3VinYmQ6Sm/6gu2I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260223141945.58779-1-mzamazal@redhat.com>","References":"<20260223141945.58779-1-mzamazal@redhat.com>","Subject":"Re: [PATCH] libcamera: software_isp: Set initial values of\n\tDebayerParams","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Wed, 25 Feb 2026 11:58:15 +0000","Message-ID":"<177202069583.172242.15090756889421768416@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]