[{"id":38269,"web_url":"https://patchwork.libcamera.org/comment/38269/","msgid":"<177183872339.1230693.17552947441290474633@ping.linuxembedded.co.uk>","date":"2026-02-23T09:25:23","subject":"Re: [PATCH v1] apps: qcam: Fix clang build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-02-23 09:16:22)\n> While gcc ignores attempts to disable unknown warnings, clang does not\n> (`-Wunknown-warning-option`), thus compilation fails due to the recent\n> addition of `-Wno-sfinae-incomplete`. So only add it conditionally.\n> \n> Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/315\n> Fixes: aa2a0812e6692a (\"apps: qcam: Disable -Wsfinae-incomplete\")\n> Signed-off-by: Barnabás Pőcze \n> ---\n> I would still love to merge https://patchwork.libcamera.org/patch/26160/\n> in some form to avoid this in the future.\n> ---\n> src/apps/qcam/meson.build | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 8eb815eed..ef4209389 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -40,7 +40,6 @@ qt6_cpp_args = [\n> apps_cpp_args,\n> '-DQT_NO_KEYWORDS',\n> '-Wno-extra-semi',\n> - '-Wno-sfinae-incomplete',\n> ]\n> \n> # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n> @@ -50,6 +49,10 @@ if qt6_dep.version().version_compare('>=6.9.0') and \\\n> qt6_cpp_args += ['-Wno-shadow']\n> endif\n> \n> +if cxx.get_id() == 'gcc' and cxx.version().version_compare('>=16')\n> + qt6_cpp_args += ['-Wno-sfinae-incomplete']\n> +endif\n\n\nReviewed-by: Kieran Bingham \n\n> +\n> resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n> dependencies : qt6_dep)\n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66572BE175\n\tfor ;\n\tMon, 23 Feb 2026 09:25:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BA6C62288;\n\tMon, 23 Feb 2026 10:25:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09C3B6226E\n\tfor ;\n\tMon, 23 Feb 2026 10:25:27 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 030AE308;\n\tMon, 23 Feb 2026 10:24:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kGzR9AhL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771838671;\n\tbh=NjjnFrLhO/q/PaKUfd9JXoaWXfJfK0+7bUtJI+IRR6o=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=kGzR9AhLn/pV601LZ65zeP+2LccrPRke3h0OOJB5AXEojy5A1ahBpfPEfd8vHNYJk\n\t+I47aXPYnP9OUbKvPDxuRIlpUF5IaIPt0uYMOVtDWGfc8g+jDkjI7BrQKwqVoNyuCV\n\t0MeZ+qyyWbGOJUrnodJGg5NuV8kViM/9zi6j9ryw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>","References":"<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] apps: qcam: Fix clang build","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 23 Feb 2026 09:25:23 +0000","Message-ID":"<177183872339.1230693.17552947441290474633@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38272,"web_url":"https://patchwork.libcamera.org/comment/38272/","msgid":"<20260223094653.GA2683397@killaraus.ideasonboard.com>","date":"2026-02-23T09:46:53","subject":"Re: [PATCH v1] apps: qcam: Fix clang build","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 23, 2026 at 10:16:22AM +0100, Barnabás Pőcze wrote:\n> While gcc ignores attempts to disable unknown warnings, clang does not\n> (`-Wunknown-warning-option`), thus compilation fails due to the recent\n> addition of `-Wno-sfinae-incomplete`. So only add it conditionally.\n> \n> Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/315\n> Fixes: aa2a0812e6692a (\"apps: qcam: Disable -Wsfinae-incomplete\")\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> I would still love to merge https://patchwork.libcamera.org/patch/26160/\n> in some form to avoid this in the future.\n> ---\n> src/apps/qcam/meson.build | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 8eb815eed..ef4209389 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -40,7 +40,6 @@ qt6_cpp_args = [\n> apps_cpp_args,\n> '-DQT_NO_KEYWORDS',\n> '-Wno-extra-semi',\n> - '-Wno-sfinae-incomplete',\n> ]\n> \n> # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n> @@ -50,6 +49,10 @@ if qt6_dep.version().version_compare('>=6.9.0') and \\\n> qt6_cpp_args += ['-Wno-shadow']\n> endif\n> \n> +if cxx.get_id() == 'gcc' and cxx.version().version_compare('>=16')\n> + qt6_cpp_args += ['-Wno-sfinae-incomplete']\n> +endif\n> +\n> resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n> dependencies : qt6_dep)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82037BE175\n\tfor ;\n\tMon, 23 Feb 2026 09:46:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7292D6227A;\n\tMon, 23 Feb 2026 10:46:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 081B161FA0\n\tfor ;\n\tMon, 23 Feb 2026 10:46:57 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BAA91308;\n\tMon, 23 Feb 2026 10:46:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lh6gfBdF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771839961;\n\tbh=4qjMKKiA/ci7Dq+RY4XRCYqXxBtLN4iV9ArM5mzLx90=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lh6gfBdFSYFcWephpJqFePJ5XBQMPfml3eiwsBBnZcc2uS5rpos8kys/yC5ZQQO5T\n\tSxzoMViytyjzSbQazFvWwlgpB2iaGhUYD5G+EHTlD8aqPNkBvH3hKuqfKXqMY0VfGX\n\tIzJ+JZZHbniqK/wMMr5xW7NFp/+nF9UxMN9+6acg=","Date":"Mon, 23 Feb 2026 10:46:53 +0100","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] apps: qcam: Fix clang build","Message-ID":"<20260223094653.GA2683397@killaraus.ideasonboard.com>","References":"<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]