[{"id":38374,"web_url":"https://patchwork.libcamera.org/comment/38374/","msgid":"<6dbdabf2-a3a2-4858-8274-3efe58c9773c@ideasonboard.com>","date":"2026-03-23T08:10:27","subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi all\n\nI would like to merge this change. Any comments?\n\n\n2026. 02. 16. 16:11 keltezéssel, Barnabás Pőcze írta:\n> Previously it was not possible to disable the use of libtiff in the cam\n> and qcam applications if it was detected. Fix that by adding a meson\n> feature option.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> changes in v2:\n> * rename option\n> \n> v1: https://patchwork.libcamera.org/patch/26056/\n> ---\n> meson_options.txt | 5 +++++\n> src/apps/meson.build | 2 +-\n> 2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index c27e377ad..f1dbfcee5 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -11,6 +11,11 @@ option('android_platform',\n> value : 'generic',\n> description : 'Select the Android platform to compile for')\n> \n> +option('apps-output-dng',\n> + type : 'feature',\n> + value : 'auto',\n> + description : 'Enable DNG file creation support in the cam and qcam applications')\n> +\n> option('cam',\n> type : 'feature',\n> value : 'auto',\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index af632b9a7..bc3a79196 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -10,7 +10,7 @@ if not libevent.found()\n> libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> endif\n> \n> -libtiff = dependency('libtiff-4', required : false)\n> +libtiff = dependency('libtiff-4', required : get_option('apps-output-dng'))\n> \n> subdir('common')\n> \n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AFD3BD87C\n\tfor ;\n\tMon, 23 Mar 2026 08:10:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6667962739;\n\tMon, 23 Mar 2026 09:10:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24AC5623A7\n\tfor ;\n\tMon, 23 Mar 2026 09:10:30 +0100 (CET)","from [192.168.33.33] (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D010F874\n\tfor ;\n\tMon, 23 Mar 2026 09:09:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fSRxTb/m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774253353;\n\tbh=pgqypD/5X0uj4coB8VdPgtoclM9/VUMyPrbL53TzD18=;\n\th=Date:Subject:From:To:References:In-Reply-To:From;\n\tb=fSRxTb/m/v9vuw4MdBSSd3tvJlunm91v1C/g0tqSNuhyGugz/goWCH+OOBgBLNN2I\n\tKWpECMUeU6iF+QtvL1f2H+nLnxFAggwHVZ0yqY9TUcpHVN3k+uu/Of0YZu+eWghrVa\n\tAHCk7jf+9m+5g/E2iBzBYYbh2UD1p8hj7huYm8zs=","Message-ID":"<6dbdabf2-a3a2-4858-8274-3efe58c9773c@ideasonboard.com>","Date":"Mon, 23 Mar 2026 09:10:27 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","References":"<20260216151105.502264-1-barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260216151105.502264-1-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38387,"web_url":"https://patchwork.libcamera.org/comment/38387/","msgid":"<177429057827.3380983.15147479388694608372@ping.linuxembedded.co.uk>","date":"2026-03-23T18:29:38","subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-03-23 08:10:27)\n> Hi all\n> \n> I would like to merge this change. Any comments?\n\nI think it's fine to merge.\n\n--\nKieran\n\n\n> \n> \n> 2026. 02. 16. 16:11 keltezéssel, Barnabás Pőcze írta:\n> > Previously it was not possible to disable the use of libtiff in the cam\n> > and qcam applications if it was detected. Fix that by adding a meson\n> > feature option.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > changes in v2:\n> > * rename option\n> > \n> > v1: https://patchwork.libcamera.org/patch/26056/\n> > ---\n> > meson_options.txt | 5 +++++\n> > src/apps/meson.build | 2 +-\n> > 2 files changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index c27e377ad..f1dbfcee5 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -11,6 +11,11 @@ option('android_platform',\n> > value : 'generic',\n> > description : 'Select the Android platform to compile for')\n> > \n> > +option('apps-output-dng',\n> > + type : 'feature',\n> > + value : 'auto',\n> > + description : 'Enable DNG file creation support in the cam and qcam applications')\n> > +\n> > option('cam',\n> > type : 'feature',\n> > value : 'auto',\n> > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > index af632b9a7..bc3a79196 100644\n> > --- a/src/apps/meson.build\n> > +++ b/src/apps/meson.build\n> > @@ -10,7 +10,7 @@ if not libevent.found()\n> > libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > endif\n> > \n> > -libtiff = dependency('libtiff-4', required : false)\n> > +libtiff = dependency('libtiff-4', required : get_option('apps-output-dng'))\n> > \n> > subdir('common')\n> > \n> > --\n> > 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90416BD87C\n\tfor ;\n\tMon, 23 Mar 2026 18:29:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8B3262777;\n\tMon, 23 Mar 2026 19:29:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59E5D62647\n\tfor ;\n\tMon, 23 Mar 2026 19:29:41 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C004289;\n\tMon, 23 Mar 2026 19:28:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MyQPnJLU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774290504;\n\tbh=XIHO3pBS5+nXFA2atYhCOFZ3ORsiyy4ZCESQ+ed0vpQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MyQPnJLU2EX6FcGgXZY/qJkZL48oaeuRGF7OlZre5lfEoRVGcNbJU2VyqbpG3mwmt\n\tTWZTD2HTeAZAR7wd+h1UooTIuFvMyKv0lcczm3FFaynS62BJJxBNxa0fntRntZHAHA\n\tcTPlxf/Gc84Lsh7Y0/Yn+eKd/Cn09o1/J3wjzmKM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<6dbdabf2-a3a2-4858-8274-3efe58c9773c@ideasonboard.com>","References":"<20260216151105.502264-1-barnabas.pocze@ideasonboard.com>\n\t<6dbdabf2-a3a2-4858-8274-3efe58c9773c@ideasonboard.com>","Subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2026 18:29:38 +0000","Message-ID":"<177429057827.3380983.15147479388694608372@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38483,"web_url":"https://patchwork.libcamera.org/comment/38483/","msgid":"<177504712497.1874149.619252432571437123@ping.linuxembedded.co.uk>","date":"2026-04-01T12:38:44","subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-03-23 18:29:38)\n> Quoting Barnabás Pőcze (2026-03-23 08:10:27)\n> > Hi all\n> > \n> > I would like to merge this change. Any comments?\n> \n> I think it's fine to merge.\n> \n\nWhich would help if I did this in that case:\n\nReviewed-by: Kieran Bingham \n\n> --\n> Kieran\n> \n> \n> > \n> > \n> > 2026. 02. 16. 16:11 keltezéssel, Barnabás Pőcze írta:\n> > > Previously it was not possible to disable the use of libtiff in the cam\n> > > and qcam applications if it was detected. Fix that by adding a meson\n> > > feature option.\n> > > \n> > > Signed-off-by: Barnabás Pőcze \n> > > ---\n> > > changes in v2:\n> > > * rename option\n> > > \n> > > v1: https://patchwork.libcamera.org/patch/26056/\n> > > ---\n> > > meson_options.txt | 5 +++++\n> > > src/apps/meson.build | 2 +-\n> > > 2 files changed, 6 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/meson_options.txt b/meson_options.txt\n> > > index c27e377ad..f1dbfcee5 100644\n> > > --- a/meson_options.txt\n> > > +++ b/meson_options.txt\n> > > @@ -11,6 +11,11 @@ option('android_platform',\n> > > value : 'generic',\n> > > description : 'Select the Android platform to compile for')\n> > > \n> > > +option('apps-output-dng',\n> > > + type : 'feature',\n> > > + value : 'auto',\n> > > + description : 'Enable DNG file creation support in the cam and qcam applications')\n> > > +\n> > > option('cam',\n> > > type : 'feature',\n> > > value : 'auto',\n> > > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > > index af632b9a7..bc3a79196 100644\n> > > --- a/src/apps/meson.build\n> > > +++ b/src/apps/meson.build\n> > > @@ -10,7 +10,7 @@ if not libevent.found()\n> > > libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n> > > endif\n> > > \n> > > -libtiff = dependency('libtiff-4', required : false)\n> > > +libtiff = dependency('libtiff-4', required : get_option('apps-output-dng'))\n> > > \n> > > subdir('common')\n> > > \n> > > --\n> > > 2.53.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53EFDBDCBD\n\tfor ;\n\tWed, 1 Apr 2026 12:38:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C6D062D55;\n\tWed, 1 Apr 2026 14:38:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81ADC62CCA\n\tfor ;\n\tWed, 1 Apr 2026 14:38:48 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E671F04;\n\tWed, 1 Apr 2026 14:37:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gFbg8+iP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775047045;\n\tbh=sO8zBWm+Fl3PPcSJIwfkEp8eutgl5kxLv5JFDj8vY9M=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gFbg8+iPJ6fJYKPR365BJAD9n1WpoaxcihvMqOGt05Yr4xfTEPGNxieYxodpZh0kp\n\t8UHqgHy3dibmVlEw+Fsl5Ard1eDRB6tq1ErJtpeuF35Q7s8uvL7GFbjA8gn+mCT/s8\n\tJnAWE/ispxUujrAY74rw8jkmmj506V39kg7A4u0A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<177429057827.3380983.15147479388694608372@ping.linuxembedded.co.uk>","References":"<20260216151105.502264-1-barnabas.pocze@ideasonboard.com>\n\t<6dbdabf2-a3a2-4858-8274-3efe58c9773c@ideasonboard.com>\n\t<177429057827.3380983.15147479388694608372@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v2] meson: Add `apps-output-dng` option to control\n\tlibtiff dependency","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 01 Apr 2026 13:38:44 +0100","Message-ID":"<177504712497.1874149.619252432571437123@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]