[{"id":38207,"web_url":"https://patchwork.libcamera.org/comment/38207/","msgid":"<177126952213.2938025.5369904344094259613@ping.linuxembedded.co.uk>","date":"2026-02-16T19:18:42","subject":"Re: [PATCH v1] apps: qcam: Show `QImageWriter` errors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-02-16 14:54:10)\n> When saving the current iamge, `QImageWriter::write()` may fail for various\n> reasons. However, this is currently not reported in any way.\n> \n> Use a simple `QMessageBox` to report the issues.\n> \n> Link: https://gitlab.freedesktop.org/camera/libcamera/-/issues/313\n> Signed-off-by: Barnabás Pőcze \n\nAlready worth adding indeed.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/qcam/main_window.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index 96a2d5090..5a88c5aa8 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -637,7 +638,8 @@ void MainWindow::saveImageAs()\n> \n> QImageWriter writer(filename);\n> writer.setQuality(95);\n> - writer.write(image);\n> + if (!writer.write(image))\n> + QMessageBox::warning(this, \"Failed to save image\", writer.errorString());\n> }\n> \n> void MainWindow::captureRaw()\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C21CC31E9\n\tfor ;\n\tMon, 16 Feb 2026 19:18:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93BA462209;\n\tMon, 16 Feb 2026 20:18:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5185B62084\n\tfor ;\n\tMon, 16 Feb 2026 20:18:44 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2361F250;\n\tMon, 16 Feb 2026 20:17:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wkvalsE4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771269473;\n\tbh=q+MSacFx2GQbhNPt9JK9wkJmUKFWIXEIjNyRB/V07uA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=wkvalsE4VTQTSZEguP+U3WJ5A+y+f+stZO47JtMWB9mEcJlSWwRep8Re7owCZ79vP\n\tvfbNsIYdNDBCN7OmZh/fTXeL/8EmRdUD8fpnbIiWX4qk5rLB/WMXUBt57o3TchhdCp\n\tHseL6SLN0dvDvtZO7HY8BgLJTL4SIexJEbcY3uN0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260216145410.495478-1-barnabas.pocze@ideasonboard.com>","References":"<20260216145410.495478-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] apps: qcam: Show `QImageWriter` errors","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 16 Feb 2026 19:18:42 +0000","Message-ID":"<177126952213.2938025.5369904344094259613@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38388,"web_url":"https://patchwork.libcamera.org/comment/38388/","msgid":"<177429073758.3380983.15343755822837317533@ping.linuxembedded.co.uk>","date":"2026-03-23T18:32:17","subject":"Re: [PATCH v1] apps: qcam: Show `QImageWriter` errors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-03-23 07:20:59)\n> Hi all\n> \n> I would like to merge this change. Any further comments?\n\nI think this can be merged already too.\n--\nKieran\n\n> \n> \n> 2026. 02. 16. 15:54 keltezéssel, Barnabás Pőcze írta:\n> > When saving the current iamge, `QImageWriter::write()` may fail for various\n> > reasons. However, this is currently not reported in any way.\n> > \n> > Use a simple `QMessageBox` to report the issues.\n> > \n> > Link: https://gitlab.freedesktop.org/camera/libcamera/-/issues/313\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/apps/qcam/main_window.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> > index 96a2d5090..5a88c5aa8 100644\n> > --- a/src/apps/qcam/main_window.cpp\n> > +++ b/src/apps/qcam/main_window.cpp\n> > @@ -18,6 +18,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -637,7 +638,8 @@ void MainWindow::saveImageAs()\n> > \n> > QImageWriter writer(filename);\n> > writer.setQuality(95);\n> > - writer.write(image);\n> > + if (!writer.write(image))\n> > + QMessageBox::warning(this, \"Failed to save image\", writer.errorString());\n> > }\n> > \n> > void MainWindow::captureRaw()\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7875FBE086\n\tfor ;\n\tMon, 23 Mar 2026 18:32:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95B3A62783;\n\tMon, 23 Mar 2026 19:32:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66A666275D\n\tfor ;\n\tMon, 23 Mar 2026 19:32:20 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD015225;\n\tMon, 23 Mar 2026 19:31:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TjFff6i3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774290663;\n\tbh=i8n1jEahEKVSTSgvIXMIXFM2DTG1E0gTsdTBvOKhFYY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=TjFff6i3VF3Wq2tNzHufMubEOP2QY5TcIx63gjGKLvmGnk4aU3oDLCEKKmNmVWNHG\n\t4RzELPjYi9Kq5kC55gKXdR9o5s5+4TRtZToQ/YoeQO4xc26ZLQUYhORQXbDsyTDZr6\n\tRNWm4Nw3fousyOlrQ2/vt8TVqbXoRpyTbkR61DPY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20260216145410.495478-1-barnabas.pocze@ideasonboard.com>\n\t","Subject":"Re: [PATCH v1] apps: qcam: Show `QImageWriter` errors","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2026 18:32:17 +0000","Message-ID":"<177429073758.3380983.15343755822837317533@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]