{"id":26161,"url":"https://patchwork.libcamera.org/api/patches/26161/?format=json","web_url":"https://patchwork.libcamera.org/patch/26161/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216145410.495478-1-barnabas.pocze@ideasonboard.com>","date":"2026-02-16T14:54:10","name":"[v1] apps: qcam: Show `QImageWriter` errors","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f5fb3ce8a0902784614355b1a121b85c01743d30","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26161/mbox/","series":[{"id":5792,"url":"https://patchwork.libcamera.org/api/series/5792/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5792","date":"2026-02-16T14:54:10","name":"[v1] apps: qcam: Show `QImageWriter` errors","version":1,"mbox":"https://patchwork.libcamera.org/series/5792/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26161/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26161/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACEF7C0DA4\n\tfor ;\n\tMon, 16 Feb 2026 14:54:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9669621F4;\n\tMon, 16 Feb 2026 15:54:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E185062084\n\tfor ;\n\tMon, 16 Feb 2026 15:54:13 +0100 (CET)","from pb-laptop.local (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 031254B3\n\tfor ;\n\tMon, 16 Feb 2026 15:53:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IEP4DDJc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771253603;\n\tbh=BvwPA7Te1g4WSqkPpRPt2SceanWUVV1BZ3jbLZlb9X4=;\n\th=From:To:Subject:Date:From;\n\tb=IEP4DDJcuy3J83k2bsCWeVlapmpTdvWnTgSN1Ayg2SkXeYEqshVYc1ML8oFmrKY2a\n\tikQEf18lWYXDvGVuNm87G6bHALkD/y9bgkHboeeFXTDjTDYHX0US5R6hUte5LDmX/U\n\tY1r7/6c6Rcx0MubS9/Rrnus4StVTfJP7ZEsCkieg=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] apps: qcam: Show `QImageWriter` errors","Date":"Mon, 16 Feb 2026 15:54:10 +0100","Message-ID":"<20260216145410.495478-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When saving the current iamge, `QImageWriter::write()` may fail for various\nreasons. However, this is currently not reported in any way.\n\nUse a simple `QMessageBox` to report the issues.\n\nLink: https://gitlab.freedesktop.org/camera/libcamera/-/issues/313\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/qcam/main_window.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex 96a2d5090..5a88c5aa8 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -18,6 +18,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -637,7 +638,8 @@ void MainWindow::saveImageAs()\n \n \tQImageWriter writer(filename);\n \twriter.setQuality(95);\n-\twriter.write(image);\n+\tif (!writer.write(image))\n+\t\tQMessageBox::warning(this, \"Failed to save image\", writer.errorString());\n }\n \n void MainWindow::captureRaw()\n","prefixes":["v1"]}