[{"id":38199,"web_url":"https://patchwork.libcamera.org/comment/38199/","msgid":"<177116628266.1941913.13226594356767916675@ping.linuxembedded.co.uk>","date":"2026-02-15T14:38:02","subject":"Re: [PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix to\n\tmeasure data member","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2026-02-15 09:44:17)\n> All class data members should have a _ postifx, add the missing _ postfix\n> to the Benchmark::measure_ data member.\n> \n\nThanks, this fixes the coding style indeed.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Hans de Goede \n> ---\n> include/libcamera/internal/software_isp/benchmark.h | 2 +-\n> src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\n> index 0680d6cd..46bdb86d 100644\n> --- a/include/libcamera/internal/software_isp/benchmark.h\n> +++ b/include/libcamera/internal/software_isp/benchmark.h\n> @@ -28,7 +28,7 @@ public:\n> \n> private:\n> timespec frameStartTime_;\n> - bool measure;\n> + bool measure_;\n> /* Skip 30 frames for things to stabilize then measure 30 frames */\n> unsigned int encounteredFrames_ = 0;\n> int64_t frameProcessTime_ = 0;\n> diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\n> index 1a00ae56..4ffb6773 100644\n> --- a/src/libcamera/software_isp/benchmark.cpp\n> +++ b/src/libcamera/software_isp/benchmark.cpp\n> @@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before)\n> */\n> void Benchmark::startFrame(void)\n> {\n> - measure = framesToMeasure_ > 0 &&\n> - encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n> - ++encounteredFrames_ > skipBeforeMeasure_;\n> + measure_ = framesToMeasure_ > 0 &&\n> + encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n> + ++encounteredFrames_ > skipBeforeMeasure_;\n> \n> - if (measure) {\n> + if (measure_) {\n> frameStartTime_ = {};\n> clock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_);\n> }\n> @@ -75,7 +75,7 @@ void Benchmark::startFrame(void)\n> */\n> void Benchmark::finishFrame(void)\n> {\n> - if (measure) {\n> + if (measure_) {\n> timespec frameEndTime = {};\n> clock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime);\n> frameProcessTime_ += timeDiff(frameEndTime, frameStartTime_);\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4477C31E9\n\tfor ;\n\tSun, 15 Feb 2026 14:38:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BABA621E6;\n\tSun, 15 Feb 2026 15:38:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EB3A621CE\n\tfor ;\n\tSun, 15 Feb 2026 15:38:06 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE432FE;\n\tSun, 15 Feb 2026 15:37:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TKjmn66Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771166235;\n\tbh=jBWrCIqQoRrsl8HWZuG1IXq/WKHr0j1cuLDuEoDTGUw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TKjmn66YyUEDepTMfdOXu+B+RtB6bGsw8XB0BoN2dzV/B81BIhoWVvxWNDojkTkfQ\n\tJjrRcjgD7NqjRyOqb88e+GPAlbrY2MGpu4slNnBVJOB7ywJb4z9GK/zxFxyv24ozEs\n\teXTESg9hVFqAuRhKrjEDFQPyt0CO88jbsC0Rgjq8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>","References":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>","Subject":"Re: [PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix to\n\tmeasure data member","From":"Kieran Bingham ","Cc":"Hans de Goede ","To":"Hans de Goede ,\n\tMilan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Sun, 15 Feb 2026 14:38:02 +0000","Message-ID":"<177116628266.1941913.13226594356767916675@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38202,"web_url":"https://patchwork.libcamera.org/comment/38202/","msgid":"<85a4x9t5i7.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-02-16T09:14:08","subject":"Re: [PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix\n\tto measure data member","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hans de Goede writes:\n\n> All class data members should have a _ postifx, add the missing _ postfix\n> to the Benchmark::measure_ data member.\n>\n> Signed-off-by: Hans de Goede \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/internal/software_isp/benchmark.h | 2 +-\n> src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\n> index 0680d6cd..46bdb86d 100644\n> --- a/include/libcamera/internal/software_isp/benchmark.h\n> +++ b/include/libcamera/internal/software_isp/benchmark.h\n> @@ -28,7 +28,7 @@ public:\n> \n> private:\n> \ttimespec frameStartTime_;\n> -\tbool measure;\n> +\tbool measure_;\n> \t/* Skip 30 frames for things to stabilize then measure 30 frames */\n> \tunsigned int encounteredFrames_ = 0;\n> \tint64_t frameProcessTime_ = 0;\n> diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\n> index 1a00ae56..4ffb6773 100644\n> --- a/src/libcamera/software_isp/benchmark.cpp\n> +++ b/src/libcamera/software_isp/benchmark.cpp\n> @@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before)\n> */\n> void Benchmark::startFrame(void)\n> {\n> -\tmeasure = framesToMeasure_ > 0 &&\n> -\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n> -\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n> +\tmeasure_ = framesToMeasure_ > 0 &&\n> +\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n> +\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n> \n> -\tif (measure) {\n> +\tif (measure_) {\n> \t\tframeStartTime_ = {};\n> \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_);\n> \t}\n> @@ -75,7 +75,7 @@ void Benchmark::startFrame(void)\n> */\n> void Benchmark::finishFrame(void)\n> {\n> -\tif (measure) {\n> +\tif (measure_) {\n> \t\ttimespec frameEndTime = {};\n> \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime);\n> \t\tframeProcessTime_ += timeDiff(frameEndTime, frameStartTime_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E964C0DA4\n\tfor ;\n\tMon, 16 Feb 2026 09:14:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 215E2621EB;\n\tMon, 16 Feb 2026 10:14:16 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 833C8620FA\n\tfor ;\n\tMon, 16 Feb 2026 10:14:14 +0100 (CET)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-440-XSdCK8WEN-2kM_0G1tPPug-1; Mon, 16 Feb 2026 04:14:12 -0500","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-4836bf1a920so35095835e9.3\n\tfor ;\n\tMon, 16 Feb 2026 01:14:12 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48371a44d2asm79736775e9.30.2026.02.16.01.14.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Feb 2026 01:14:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Laz0FTYC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1771233253;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=nYHaQtL6G6bElvfjDBl5T6qbzhNwgpAgVnHcRkA8uD8=;\n\tb=Laz0FTYC5fmslNq5JmR4hcTZekbbyz8OodgWIsriGdlOBk3un3KZgwvwS6no10Move3XKo\n\tL+orHcc2cH4EnwbwmeieXdQspvEDvLLjE6ttQxgzE/yvlG8Pfsvy99c2f8VW5G5aLEzfKZ\n\tdSmB+El/gMraXHFecdXpMn1Dd/1nY1s=","X-MC-Unique":"XSdCK8WEN-2kM_0G1tPPug-1","X-Mimecast-MFC-AGG-ID":"XSdCK8WEN-2kM_0G1tPPug_1771233251","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771233250; x=1771838050;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=nYHaQtL6G6bElvfjDBl5T6qbzhNwgpAgVnHcRkA8uD8=;\n\tb=uzv3lGWVvxt3hqMMK+DPAE/np+PkOTfXCJNt0CwpyeoftmzaxCsGYo7cqFLZ+UMENY\n\tEjcdmZtaSjXcHaYpao6W5tUm90Tr+Vs0fWavosRHDWOx5pXg45wEjz9n7QlT7+hJtZym\n\tDH/0m0CFccWptYgansjLEJpNjntDTdE5f9Zt5+NtKbi6FNRgfo/BgdqIBEbkO9JLxy3s\n\tI4eUEGtptyLeZG8FMztDKneHx3NTWFtP1Ff0uwuWOvJ+EVP0lKIR2deDw7w3Xv/J0HlU\n\tbqChttYoetx4fIg65ojfgERRrxmC7AiKoOjcjtM/A0mLosQ/zCgZFLgxJHQiCdYVIDm7\n\tCyYQ==","X-Gm-Message-State":"AOJu0YziBBloZcJSh/D/am2O9mcDO3bXouErGg2GTCUFb9P5QzNRO2yX\n\t37t5A/MNfJiuaXSClFMhztr91u3dW5s/6/w387oCZll2OsGXChK5h8WqkQsnkHuMzM8k9oVtb2O\n\tuFK8Mf2yUb3wQInGFa+lzV3HFRrOXDEABP3P2dNUNo+rIBjXtVbZfrg1EzP6rDYSRSkI+ncCMHA\n\tGnpx8IapicmFbN2F/PoqTVSwrBaNZYGeyrWYsAmmWTLoKEaMlgP5WkaPWdxh0=","X-Gm-Gg":"AZuq6aLhA5iy9FYpwPVAAxwNmSNOK41o45OkF+2tV90Ew5zo4IC/Eo89tY7Xa1bRka5\n\to6heC2NCDY7XcRlA7KRYCQ1uzMx8oLwC4fIbvrK6CiheOZgbPQYa7dPjIpgz9iRwYYYB2SIaCE3\n\tEhe+/P2xDNT1c8ixg9KtkBpkILX4/FO+h+IVTtGvQjJl60pwC4xISiLPCOSLafEqjSUfPeuJI9h\n\tbwjzzai+e1jUuQG74EnuUDhz8CdtO3/I4FkFETgJ29jXFNbSqRs8cwkR13kMP7fdRb9o1bqhBFk\n\tyIPXgvwohzR5aLUZmW+s0zseKpIX1it73ibjVWuSoksPanKr61xIZjrSzvuMmQlY0PtKKfultE0\n\tytuHimgnqxo0VCoX7EZ4a7jGiCe3m8mXjxI93EP6CslEYEyL9C/sjO9FvaDjRKIMT0tQnvgFSNj\n\tA=","X-Received":["by 2002:a05:600c:c491:b0:475:dd89:acb with SMTP id\n\t5b1f17b1804b1-48379be8253mr122327565e9.22.1771233250458; \n\tMon, 16 Feb 2026 01:14:10 -0800 (PST)","by 2002:a05:600c:c491:b0:475:dd89:acb with SMTP id\n\t5b1f17b1804b1-48379be8253mr122327105e9.22.1771233249979; \n\tMon, 16 Feb 2026 01:14:09 -0800 (PST)"],"From":"Milan Zamazal ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/2] software_isp: benchmark: Add missing _ postfix\n\tto measure data member","In-Reply-To":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com> (Hans\n\tde Goede's message of \"Sun, 15 Feb 2026 10:44:17 +0100\")","References":"<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>","Date":"Mon, 16 Feb 2026 10:14:08 +0100","Message-ID":"<85a4x9t5i7.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"q9KMLoGuWxIEEBKv1dng3FoAitvDt7_nmeDMvYWgDeM_1771233251","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]