[{"id":38231,"web_url":"https://patchwork.libcamera.org/comment/38231/","msgid":"<177149172764.607498.8417244836952858303@neptunite.rasen.tech>","date":"2026-02-19T09:02:07","subject":"Re: [PATCH v7 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-02-14 01:57:49)\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Reviewed-by: Isaac Scott \n> Reviewed-by: Barnabás Pőcze \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> v5:\n> - Use Q<4, 7>\n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..466d7a116eea 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> */\n> for (unsigned int i = 0; i < 3; i++) {\n> for (unsigned int j = 0; j < 3; j++)\n> - config.coeff[i][j] =\n> - floatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> + config.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n> }\n> \n> for (unsigned int i = 0; i < 3; i++)\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC213C31E9\n\tfor ;\n\tThu, 19 Feb 2026 09:02:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E57E62230;\n\tThu, 19 Feb 2026 10:02:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 801AD62010\n\tfor ;\n\tThu, 19 Feb 2026 10:02:12 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:3150:3f17:6415:4c60])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3172B673;\n\tThu, 19 Feb 2026 10:01:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"roJM82ZS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771491679;\n\tbh=zGea0/x2h4uBG0EPffF7WVfwNlkyVFWbYnrNdn3Sb1o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=roJM82ZSp4sODl1T7Lz/3I8Pqo8BteuQfwQS8trErBc4Q6b5zLguinS0CYPaCvnDs\n\ttO6b5Wj82mROOP1jgoLa8AGMekh2orQrcRaQSEaAcV/CqKILwhWYxjM6++uuXo7EJu\n\tq69XcGdjEwdP7xLC3Ypj0BXm4GGGlNjM/Jt3Ko2I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","Subject":"Re: [PATCH v7 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","From":"Paul Elder ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 19 Feb 2026 18:02:07 +0900","Message-ID":"<177149172764.607498.8417244836952858303@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38236,"web_url":"https://patchwork.libcamera.org/comment/38236/","msgid":"<20260219095848.GA688396@killaraus.ideasonboard.com>","date":"2026-02-19T09:58:48","subject":"Re: [PATCH v7 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 13, 2026 at 04:57:49PM +0000, Kieran Bingham wrote:\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Reviewed-by: Isaac Scott \n> Reviewed-by: Barnabás Pőcze \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v5:\n> - Use Q<4, 7>\n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..466d7a116eea 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> \t */\n> \tfor (unsigned int i = 0; i < 3; i++) {\n> \t\tfor (unsigned int j = 0; j < 3; j++)\n> -\t\t\tconfig.coeff[i][j] =\n> -\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> +\t\t\tconfig.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n> \t}\n> \n> \tfor (unsigned int i = 0; i < 3; i++)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 839EDC31E9\n\tfor ;\n\tThu, 19 Feb 2026 09:58:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93CFD62234;\n\tThu, 19 Feb 2026 10:58:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCEB862010\n\tfor ;\n\tThu, 19 Feb 2026 10:58:53 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 50F2F741;\n\tThu, 19 Feb 2026 10:58:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OnwTZCHQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771495080;\n\tbh=vFHy8hoAaFWUuttJRjqDQfm2GSv9QwOa60BtOENNWik=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OnwTZCHQS+zYcD5JHexUyNKqe/7FVvZa9B759lZIRS6wO2771fdxodQp9wYKC5k30\n\tM5+jjX3ask1Wxbblx4gjx6qJ4qBi1+yBxb2IuADKmaABMV7Lp7TuUJODu7BTd0JR9V\n\tIK0C6cfeoYPtI5/T8DW+LIhIBc2SpWcaDTneNso4=","Date":"Thu, 19 Feb 2026 10:58:48 +0100","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"Re: [PATCH v7 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","Message-ID":"<20260219095848.GA688396@killaraus.ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]