{"id":26152,"url":"https://patchwork.libcamera.org/api/patches/26152/?format=json","web_url":"https://patchwork.libcamera.org/patch/26152/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","date":"2026-02-13T16:57:49","name":"[v7,10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bdb6b793191bcdfb1f40e7cce77a9bc2eba7b3c4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26152/mbox/","series":[{"id":5789,"url":"https://patchwork.libcamera.org/api/series/5789/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5789","date":"2026-02-13T16:57:39","name":"libipa: Introduce a Quantized type","version":7,"mbox":"https://patchwork.libcamera.org/series/5789/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26152/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26152/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4398BC32F5\n\tfor ;\n\tFri, 13 Feb 2026 16:58:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D70D86220F;\n\tFri, 13 Feb 2026 17:58:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67613621E1\n\tfor ;\n\tFri, 13 Feb 2026 17:58:06 +0100 (CET)","from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9990526D1;\n\tFri, 13 Feb 2026 17:57:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y8K3mTZY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771001837;\n\tbh=qF1kii5a079EQBiA2z+WOtrbYueZi7DzfYCOdhxKkDM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Y8K3mTZY/j1r8K9EVEa19576RghytG382YrIHgS5hJSdym3xv4k+Lf/XObUmtnaJG\n\tNygppnFoQ74D3DqbWhcWusnMLQ9187zWoaiKjl1lA7Ovjfw5E6hs28zKg1AmUR3ZT/\n\tGo1ZMkFj8LbZi3HACDR12lWXXm4ITGiAK4x8YI68=","From":"Kieran Bingham ","Date":"Fri, 13 Feb 2026 16:57:49 +0000","Subject":"[PATCH v7 10/15] ipa: rkisp1: ccm: Use Q<4, 7> format directly","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260213-kbingham-quantizers-v7-10-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>","In-Reply-To":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1771001883; l=1079;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=qF1kii5a079EQBiA2z+WOtrbYueZi7DzfYCOdhxKkDM=;\n\tb=v8+BXWUDTTX8jdYisAsjp133bDoKZfGInWBV7q2bRtgHjuNjwrCqe2aGC8zbAlfCe+nrYzk+v\n\te4P4oz/uQXfCXgqiV1uSbpTZbMicrpMdNDBma7y/grxnYhVQtQYqg50","X-Developer-Key":"i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the legacy call to floatingToFixedPoint with the new FixedPoint\nquantizer to explicitly describe the type used by the RKISP1 Colour\nCorrection Matrix.\n\nReviewed-by: Isaac Scott \nReviewed-by: Barnabás Pőcze \nSigned-off-by: Kieran Bingham \n\n---\nv5:\n - Use Q<4, 7>\n---\n src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex de2b6fe775aa..466d7a116eea 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n \t */\n \tfor (unsigned int i = 0; i < 3; i++) {\n \t\tfor (unsigned int j = 0; j < 3; j++)\n-\t\t\tconfig.coeff[i][j] =\n-\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n+\t\t\tconfig.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n \t}\n \n \tfor (unsigned int i = 0; i < 3; i++)\n","prefixes":["v7","10/15"]}