[{"id":38230,"web_url":"https://patchwork.libcamera.org/comment/38230/","msgid":"<177149167314.607498.7265933508844012968@neptunite.rasen.tech>","date":"2026-02-19T09:01:13","subject":"Re: [PATCH v7 09/15] ipa: rkisp1: cproc: Provide a Hue control","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-02-14 01:57:48)\n> The RKISP1 supports a configurable Hue as part of the colour processing\n> unit (cproc).\n> \n> Implement the new control converting to the hardware scale accordingly\n> and report the applied control in the completed request metadata.\n> \n> This is implemented as a phase shift of the chrominance values between\n> -90 and +87.188 degrees according to the datasheet however the type\n> itself would imply that this is a range between -90 and 89.2969.\n> \n> Moreover, the hardware applies the inverse phase shift to the operation\n> expected and documented by libcamera, so we apply a negative scale when\n> converting the libcamera control to the Q<1,7> type, resulting in a\n> range of -89.2969 to +90.0 degrees control.\n> \n> Reviewed-by: Isaac Scott \n> Tested-by: Barnabás Pőcze \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> v5:\n> - Use Q<1, 7> directly and handle scaling in cproc.cpp\n> - Use full string of quantized in debug log\n> - Invert/Negate the hardware hue direction\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 28 ++++++++++++++++++++++++++++\n> src/ipa/rkisp1/ipa_context.h | 3 +++\n> 2 files changed, 31 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index e9e2b5444bc9..7484e4780094 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -37,8 +37,15 @@ namespace {\n> \n> constexpr float kDefaultBrightness = 0.0f;\n> constexpr float kDefaultContrast = 1.0f;\n> +constexpr float kDefaultHue = 0.0f;\n> constexpr float kDefaultSaturation = 1.0f;\n> \n> +/*\n> + * The Hue scale is negated as the hardware performs the opposite phase shift\n> + * to what is expected and defined from the libcamera Hue control value.\n> + */\n> +constexpr float kHueScale = -90.0f;\n> +\n> } /* namespace */\n> \n> /**\n> @@ -53,6 +60,11 @@ int ColorProcessing::init(IPAContext &context,\n> cmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);\n> cmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);\n> \n> + /* Hue adjustment is negated by kHueScale, min/max are swapped */\n> + cmap[&controls::Hue] = ControlInfo(HueQ::TraitsType::max * kHueScale,\n> + HueQ::TraitsType::min * kHueScale,\n> + kDefaultHue);\n> +\n> return 0;\n> }\n> \n> @@ -66,6 +78,7 @@ int ColorProcessing::configure(IPAContext &context,\n> \n> cproc.brightness = BrightnessQ(kDefaultBrightness);\n> cproc.contrast = ContrastQ(kDefaultContrast);\n> + cproc.hue = HueQ(kDefaultHue);\n> cproc.saturation = SaturationQ(kDefaultSaturation);\n> \n> return 0;\n> @@ -107,6 +120,18 @@ void ColorProcessing::queueRequest(IPAContext &context,\n> LOG(RkISP1CProc, Debug) << \"Set contrast to \" << value;\n> }\n> \n> + const auto &hue = controls.get(controls::Hue);\n> + if (hue) {\n> + /* Scale the Hue from ]-90, +90] */\n> + HueQ value = *hue / kHueScale;\n> + if (cproc.hue != value) {\n> + cproc.hue = value;\n> + update = true;\n> + }\n> +\n> + LOG(RkISP1CProc, Debug) << \"Set hue to \" << value;\n> + }\n> +\n> const auto saturation = controls.get(controls::Saturation);\n> if (saturation) {\n> SaturationQ value = *saturation;\n> @@ -120,6 +145,7 @@ void ColorProcessing::queueRequest(IPAContext &context,\n> \n> frameContext.cproc.brightness = cproc.brightness;\n> frameContext.cproc.contrast = cproc.contrast;\n> + frameContext.cproc.hue = cproc.hue;\n> frameContext.cproc.saturation = cproc.saturation;\n> frameContext.cproc.update = update;\n> }\n> @@ -140,6 +166,7 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> config.setEnabled(true);\n> config->brightness = frameContext.cproc.brightness.quantized();\n> config->contrast = frameContext.cproc.contrast.quantized();\n> + config->hue = frameContext.cproc.hue.quantized();\n> config->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> @@ -154,6 +181,7 @@ void ColorProcessing::process([[maybe_unused]] IPAContext &context,\n> {\n> metadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> metadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> + metadata.set(controls::Hue, frameContext.cproc.hue.value() * kHueScale);\n> metadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> }\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index cca5e281c732..e61391bb1510 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -36,6 +36,7 @@ namespace ipa::rkisp1 {\n> /* Fixed point types used by CPROC */\n> using BrightnessQ = Q<1, 7>;\n> using ContrastQ = UQ<1, 7>;\n> +using HueQ = Q<1, 7>;\n> using SaturationQ = UQ<1, 7>;\n> \n> struct IPAHwSettings {\n> @@ -119,6 +120,7 @@ struct IPAActiveState {\n> struct {\n> BrightnessQ brightness;\n> ContrastQ contrast;\n> + HueQ hue;\n> SaturationQ saturation;\n> } cproc;\n> \n> @@ -181,6 +183,7 @@ struct IPAFrameContext : public FrameContext {\n> struct {\n> BrightnessQ brightness;\n> ContrastQ contrast;\n> + HueQ hue;\n> SaturationQ saturation;\n> \n> bool update;\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3B06C31E9\n\tfor ;\n\tThu, 19 Feb 2026 09:01:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF9446223A;\n\tThu, 19 Feb 2026 10:01:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A16F062010\n\tfor ;\n\tThu, 19 Feb 2026 10:01:18 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:3150:3f17:6415:4c60])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4C2D6741;\n\tThu, 19 Feb 2026 10:00:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QHV72haQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771491625;\n\tbh=Ka1HVGobucz6FJEb37lCZ0H8weSjulZ5/lbzWutGhz0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QHV72haQMzPlHi6Zt66TKYquDKPsXnH8/eTYBv0cnfCie7dZRO4q1u7Wm0ZVAB9XW\n\tK13ubVthWuyPXBXKSq9GnE0VMuhBvIFmayjCAez/Lq++Mr5/AO4VMUHj/YPAFuJBQL\n\t3hSX5etOCCdFze1H1+t9RWikDOHK7rMipKYIZX28=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","Subject":"Re: [PATCH v7 09/15] ipa: rkisp1: cproc: Provide a Hue control","From":"Paul Elder ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 19 Feb 2026 18:01:13 +0900","Message-ID":"<177149167314.607498.7265933508844012968@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38244,"web_url":"https://patchwork.libcamera.org/comment/38244/","msgid":"<20260219120443.GE688396@killaraus.ideasonboard.com>","date":"2026-02-19T12:04:43","subject":"Re: [PATCH v7 09/15] ipa: rkisp1: cproc: Provide a Hue control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Feb 13, 2026 at 04:57:48PM +0000, Kieran Bingham wrote:\n> The RKISP1 supports a configurable Hue as part of the colour processing\n> unit (cproc).\n> \n> Implement the new control converting to the hardware scale accordingly\n> and report the applied control in the completed request metadata.\n> \n> This is implemented as a phase shift of the chrominance values between\n> -90 and +87.188 degrees according to the datasheet however the type\n> itself would imply that this is a range between -90 and 89.2969.\n> \n> Moreover, the hardware applies the inverse phase shift to the operation\n> expected and documented by libcamera, so we apply a negative scale when\n> converting the libcamera control to the Q<1,7> type, resulting in a\n> range of -89.2969 to +90.0 degrees control.\n> \n> Reviewed-by: Isaac Scott \n> Tested-by: Barnabás Pőcze \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> v5:\n> - Use Q<1, 7> directly and handle scaling in cproc.cpp\n> - Use full string of quantized in debug log\n> - Invert/Negate the hardware hue direction\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 28 ++++++++++++++++++++++++++++\n> src/ipa/rkisp1/ipa_context.h | 3 +++\n> 2 files changed, 31 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index e9e2b5444bc9..7484e4780094 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -37,8 +37,15 @@ namespace {\n> \n> constexpr float kDefaultBrightness = 0.0f;\n> constexpr float kDefaultContrast = 1.0f;\n> +constexpr float kDefaultHue = 0.0f;\n> constexpr float kDefaultSaturation = 1.0f;\n> \n> +/*\n> + * The Hue scale is negated as the hardware performs the opposite phase shift\n> + * to what is expected and defined from the libcamera Hue control value.\n> + */\n> +constexpr float kHueScale = -90.0f;\n> +\n> } /* namespace */\n> \n> /**\n> @@ -53,6 +60,11 @@ int ColorProcessing::init(IPAContext &context,\n> \tcmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);\n> \tcmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);\n> \n> +\t/* Hue adjustment is negated by kHueScale, min/max are swapped */\n> +\tcmap[&controls::Hue] = ControlInfo(HueQ::TraitsType::max * kHueScale,\n> +\t\t\t\t\t HueQ::TraitsType::min * kHueScale,\n> +\t\t\t\t\t kDefaultHue);\n> +\n> \treturn 0;\n> }\n> \n> @@ -66,6 +78,7 @@ int ColorProcessing::configure(IPAContext &context,\n> \n> \tcproc.brightness = BrightnessQ(kDefaultBrightness);\n> \tcproc.contrast = ContrastQ(kDefaultContrast);\n> +\tcproc.hue = HueQ(kDefaultHue);\n> \tcproc.saturation = SaturationQ(kDefaultSaturation);\n> \n> \treturn 0;\n> @@ -107,6 +120,18 @@ void ColorProcessing::queueRequest(IPAContext &context,\n> \t\tLOG(RkISP1CProc, Debug) << \"Set contrast to \" << value;\n> \t}\n> \n> +\tconst auto &hue = controls.get(controls::Hue);\n> +\tif (hue) {\n> +\t\t/* Scale the Hue from ]-90, +90] */\n> +\t\tHueQ value = *hue / kHueScale;\n> +\t\tif (cproc.hue != value) {\n> +\t\t\tcproc.hue = value;\n> +\t\t\tupdate = true;\n> +\t\t}\n> +\n> +\t\tLOG(RkISP1CProc, Debug) << \"Set hue to \" << value;\n> +\t}\n> +\n> \tconst auto saturation = controls.get(controls::Saturation);\n> \tif (saturation) {\n> \t\tSaturationQ value = *saturation;\n> @@ -120,6 +145,7 @@ void ColorProcessing::queueRequest(IPAContext &context,\n> \n> \tframeContext.cproc.brightness = cproc.brightness;\n> \tframeContext.cproc.contrast = cproc.contrast;\n> +\tframeContext.cproc.hue = cproc.hue;\n> \tframeContext.cproc.saturation = cproc.saturation;\n> \tframeContext.cproc.update = update;\n> }\n> @@ -140,6 +166,7 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> \tconfig.setEnabled(true);\n> \tconfig->brightness = frameContext.cproc.brightness.quantized();\n> \tconfig->contrast = frameContext.cproc.contrast.quantized();\n> +\tconfig->hue = frameContext.cproc.hue.quantized();\n> \tconfig->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> @@ -154,6 +181,7 @@ void ColorProcessing::process([[maybe_unused]] IPAContext &context,\n> {\n> \tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> \tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> +\tmetadata.set(controls::Hue, frameContext.cproc.hue.value() * kHueScale);\n> \tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> }\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index cca5e281c732..e61391bb1510 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -36,6 +36,7 @@ namespace ipa::rkisp1 {\n> /* Fixed point types used by CPROC */\n> using BrightnessQ = Q<1, 7>;\n> using ContrastQ = UQ<1, 7>;\n> +using HueQ = Q<1, 7>;\n> using SaturationQ = UQ<1, 7>;\n> \n> struct IPAHwSettings {\n> @@ -119,6 +120,7 @@ struct IPAActiveState {\n> \tstruct {\n> \t\tBrightnessQ brightness;\n> \t\tContrastQ contrast;\n> +\t\tHueQ hue;\n> \t\tSaturationQ saturation;\n> \t} cproc;\n> \n> @@ -181,6 +183,7 @@ struct IPAFrameContext : public FrameContext {\n> \tstruct {\n> \t\tBrightnessQ brightness;\n> \t\tContrastQ contrast;\n> +\t\tHueQ hue;\n> \t\tSaturationQ saturation;\n> \n> \t\tbool update;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AC3CC0DA4\n\tfor ;\n\tThu, 19 Feb 2026 12:04:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A7BF6224A;\n\tThu, 19 Feb 2026 13:04:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D7F0620C9\n\tfor ;\n\tThu, 19 Feb 2026 13:04:48 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9929F4D3;\n\tThu, 19 Feb 2026 13:03:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q3UEm1+i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771502635;\n\tbh=KXpFuD7UIsjqw7xRnUb2iT++XjpKNuhQ/tEP8i7o2wk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q3UEm1+ieCrHJL8V4whW4+nJZDFtWREs6Qh4keEsAa3ljY3fBhZFp7/iPSwrWQtc8\n\trh9KIMoKUthH2Uvf6HZW4o91YMw15cyhfngyyRrKjQd1q2DPv2kStJ3sQsUZqgiAjy\n\tDJNNlWdJsVSuG7Vko3x35JYsTVaqe75xE6PS2r7o=","Date":"Thu, 19 Feb 2026 13:04:43 +0100","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"Re: [PATCH v7 09/15] ipa: rkisp1: cproc: Provide a Hue control","Message-ID":"<20260219120443.GE688396@killaraus.ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260213-kbingham-quantizers-v7-9-1626b9aaabf1@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]