[{"id":38229,"web_url":"https://patchwork.libcamera.org/comment/38229/","msgid":"<177149148118.607498.13766120486606083371@neptunite.rasen.tech>","date":"2026-02-19T08:58:01","subject":"Re: [PATCH v7 08/15] libcamera: controls: Define a new core Hue\n\tcontrol","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-02-14 01:57:47)\n> From: \"van Veen, Stephan\" \n> \n> Define a new control to support configuration of Hue adjustments when\n> supported by the available platform.\n> \n> Reviewed-by: Isaac Scott \n> Signed-off-by: van Veen, Stephan \n> [Kieran: Rework to define as a rotation in degrees]\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> v5:\n> - Reworked control definition and direction\n> ---\n> src/libcamera/control_ids_core.yaml | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index f26a1b1b08bd..6df4bc9a0372 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1361,4 +1361,19 @@ controls:\n> description: |\n> Enable or disable the lens shading correction.\n> \n> + - Hue:\n> + type: float\n> + direction: inout\n> + description: |\n> + Adjusts the image hue (colour rotation) in degrees, as defined in\n> + the HSL/HSV colour model.\n> +\n> + The value represents a rotation around the hue circle in HSL/HSV space:\n> + positive values rotate hues clockwise (for example a +60° turns\n> + Red hues to Yellow hues), and negative values rotate counter-clockwise\n> + (a -60° turns Red hues to Magenta hues).\n> +\n> + The nominal range is [-180, 180[, where 0° leaves hues unchanged and the\n> + range wraps around continuously, with 180° == -180°.\n> +\n> ...\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9E92C0DA4\n\tfor ;\n\tThu, 19 Feb 2026 08:58:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B5562010;\n\tThu, 19 Feb 2026 09:58:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10A3162010\n\tfor ;\n\tThu, 19 Feb 2026 09:58:07 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:3150:3f17:6415:4c60])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8431E4D3;\n\tThu, 19 Feb 2026 09:57:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qK71nZFt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771491434;\n\tbh=u07ChyOqT6mRzGlDRfTpfM6jCQUtvVH71+6RKNp+y2U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qK71nZFtny/2GeBFdagFMLBTWvvutOfIc1iYhaXDWTLkQvtzygxrmdx8YcuEdpCee\n\t0xUNX7NJNKYOZClgoXuz+DgQF4jOPJ2Mt6cUGyrCzjyu4qAAd+Va6iUUosgphrMikG\n\t/TFi5yW9SIbQLA0c7n17AoGBGOxLMlGzNBGZ1kvg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260213-kbingham-quantizers-v7-8-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-8-1626b9aaabf1@ideasonboard.com>","Subject":"Re: [PATCH v7 08/15] libcamera: controls: Define a new core Hue\n\tcontrol","From":"Paul Elder ","Cc":"Kieran Bingham , \"van Veen,\n\tStephan\" ,\n\tIsaac Scott ","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 19 Feb 2026 17:58:01 +0900","Message-ID":"<177149148118.607498.13766120486606083371@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38243,"web_url":"https://patchwork.libcamera.org/comment/38243/","msgid":"<20260219120211.GD688396@killaraus.ideasonboard.com>","date":"2026-02-19T12:02:11","subject":"Re: [PATCH v7 08/15] libcamera: controls: Define a new core Hue\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Feb 13, 2026 at 04:57:47PM +0000, Kieran Bingham wrote:\n> From: \"van Veen, Stephan\" \n> \n> Define a new control to support configuration of Hue adjustments when\n> supported by the available platform.\n> \n> Reviewed-by: Isaac Scott \n> Signed-off-by: van Veen, Stephan \n> [Kieran: Rework to define as a rotation in degrees]\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v5:\n> - Reworked control definition and direction\n> ---\n> src/libcamera/control_ids_core.yaml | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index f26a1b1b08bd..6df4bc9a0372 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1361,4 +1361,19 @@ controls:\n> description: |\n> Enable or disable the lens shading correction.\n> \n> + - Hue:\n> + type: float\n> + direction: inout\n> + description: |\n> + Adjusts the image hue (colour rotation) in degrees, as defined in\n> + the HSL/HSV colour model.\n> +\n> + The value represents a rotation around the hue circle in HSL/HSV space:\n> + positive values rotate hues clockwise (for example a +60° turns\n> + Red hues to Yellow hues), and negative values rotate counter-clockwise\n> + (a -60° turns Red hues to Magenta hues).\n> +\n> + The nominal range is [-180, 180[, where 0° leaves hues unchanged and the\n> + range wraps around continuously, with 180° == -180°.\n> +\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ED76C31E9\n\tfor ;\n\tThu, 19 Feb 2026 12:02:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C3A56223F;\n\tThu, 19 Feb 2026 13:02:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00D18620C9\n\tfor ;\n\tThu, 19 Feb 2026 13:02:15 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 41D584D3;\n\tThu, 19 Feb 2026 13:01:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M3X+CBdV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771502482;\n\tbh=wTU9sTDTsf5ZZkBen9ZB+dT+cZvbv1N0X20Y5QTtfrc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M3X+CBdVq+WgBr16R0k1KkE31zdGukLDVDrYQISfbPbIh7f/IL9+r6xzzmtCOF/tS\n\tfIIvQZrQuaEUqx+ypokVBv8kKSV/ic5PVWC9VXCoqEFnhyBUWkiWpWF2JZqgG+T0Lk\n\tAt0DAD1t9iO2hKTVpwXeCuaA5SlxbYBF03Ap33P0=","Date":"Thu, 19 Feb 2026 13:02:11 +0100","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\t\"van Veen, Stephan\" ,\n\tIsaac Scott ","Subject":"Re: [PATCH v7 08/15] libcamera: controls: Define a new core Hue\n\tcontrol","Message-ID":"<20260219120211.GD688396@killaraus.ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-8-1626b9aaabf1@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260213-kbingham-quantizers-v7-8-1626b9aaabf1@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]