[{"id":38228,"web_url":"https://patchwork.libcamera.org/comment/38228/","msgid":"<177149127972.607498.515239148601838105@neptunite.rasen.tech>","date":"2026-02-19T08:54:39","subject":"Re: [PATCH v7 07/15] ipa: rkisp1: cproc: Report metadata","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-02-14 01:57:46)\n> Presently the colour processing component exposes controls for\n> brightness, saturation, and contrast to the applications which are\n> handled and processed accordingly on the ISP.\n> \n> The implementation lacks reporting the values that are set back to the\n> application.\n> \n> Utilise the new Quantised types to provide the values that were applied\n> to the hardware and report them in the completed request metadata.\n> \n> Reviewed-by: Isaac Scott \n> Reviewed-by: Barnabás Pőcze \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> v5:\n> - Fix line wraps\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 14 ++++++++++++++\n> src/ipa/rkisp1/algorithms/cproc.h | 4 ++++\n> 2 files changed, 18 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 4374c08c2a4f..e9e2b5444bc9 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -143,6 +143,20 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n> config->sat = frameContext.cproc.saturation.quantized();\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::process\n> + */\n> +void ColorProcessing::process([[maybe_unused]] IPAContext &context,\n> + [[maybe_unused]] const uint32_t frame,\n> + IPAFrameContext &frameContext,\n> + [[maybe_unused]] const rkisp1_stat_buffer *stats,\n> + ControlList &metadata)\n> +{\n> + metadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n> + metadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n> + metadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n> +}\n> +\n> REGISTER_IPA_ALGORITHM(ColorProcessing, \"ColorProcessing\")\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> diff --git a/src/ipa/rkisp1/algorithms/cproc.h b/src/ipa/rkisp1/algorithms/cproc.h\n> index fd38fd17e8bb..9b589ebd4ad7 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.h\n> +++ b/src/ipa/rkisp1/algorithms/cproc.h\n> @@ -30,6 +30,10 @@ public:\n> void prepare(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext,\n> RkISP1Params *params) override;\n> + void process(IPAContext &context, const uint32_t frame,\n> + IPAFrameContext &frameContext,\n> + const rkisp1_stat_buffer *stats,\n> + ControlList &metadata) override;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65B56C0DA4\n\tfor ;\n\tThu, 19 Feb 2026 08:54:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D7416222F;\n\tThu, 19 Feb 2026 09:54:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFE2862010\n\tfor ;\n\tThu, 19 Feb 2026 09:54:45 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:3150:3f17:6415:4c60])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AA811379;\n\tThu, 19 Feb 2026 09:53:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RFCcu3qB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771491233;\n\tbh=1urnQdYCGretCw8bDOnOQmLoj4VeZzvy3Zk4Wnva7u8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=RFCcu3qBWo3cNoStpFIs/ipOyYS7ltnjwykkzQBqDoXS7I/+wazgIimNTVqfgqACq\n\tp/106VH3aIuhtvJGv6EWCYs76EGkx/kvXqrbVyqtn1PAbmupOTA9M8oabE31vTb0BF\n\tAKYfWgFFD5YVd+bLIt/SMbV9bIYi7PsaZJ7tcWiw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260213-kbingham-quantizers-v7-7-1626b9aaabf1@ideasonboard.com>","References":"<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>\n\t<20260213-kbingham-quantizers-v7-7-1626b9aaabf1@ideasonboard.com>","Subject":"Re: [PATCH v7 07/15] ipa: rkisp1: cproc: Report metadata","From":"Paul Elder ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 19 Feb 2026 17:54:39 +0900","Message-ID":"<177149127972.607498.515239148601838105@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]