[{"id":38191,"web_url":"https://patchwork.libcamera.org/comment/38191/","msgid":"<177091171280.3376561.14754481998879091306@ping.linuxembedded.co.uk>","date":"2026-02-12T15:55:12","subject":"Re: [PATCH] android: camera_stream: Include instead of\n\t","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-02-12 15:28:50)\n> The standard C library header for the poll() API is poll.h, not\n> sys/poll.h. The musl C library warns about this:\n> \n> In file included from src/android/camera_stream.cpp:13:\n> host/i586-buildroot-linux-musl/sysroot/usr/include/sys/poll.h:1:2: error: #warning redirecting incorrect #include to [-Werror=cpp]\n> 1 | #warning redirecting incorrect #include to \n> | ^~~~~~~\n> \n> Fix it by including the correct header.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 1d68540d7e50..7da01dc30031 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -8,9 +8,9 @@\n> #include \"camera_stream.h\"\n> \n> #include \n> +#include \n\nLooks sane,\n\n\nReviewed-by: Kieran Bingham \n\n> #include \n> #include \n> -#include \n> #include \n> \n> #include \n> \n> base-commit: 1dcf9957a47fb54fce4fbae9daec0b587e52562e\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37ED4BD78E\n\tfor ;\n\tThu, 12 Feb 2026 15:55:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7938661FBF;\n\tThu, 12 Feb 2026 16:55:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D17D161FBF\n\tfor ;\n\tThu, 12 Feb 2026 16:55:15 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F84B6A6;\n\tThu, 12 Feb 2026 16:54:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O0PoUtiL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770911667;\n\tbh=zsanmLUhpqbCqQ5oH4lbX+XnnJBlXoLDFnm9PaYt+D8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=O0PoUtiLBMvGr7dDsMQ4c3CjPHnYT6HDINdsI7x9vo50fxBtl0/bO8Pjgm6xEINER\n\tHqwFkdWrtlppLPneUgGKkgJlkmmOCu9en9G3wmPpOzXHdtxPnhCovcOCDSD1tktJXG\n\t/O1aXqpv8FdSV2LN89sOq/dajO1ATEI8G8I4ysBo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>","References":"<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] android: camera_stream: Include instead of\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 12 Feb 2026 15:55:12 +0000","Message-ID":"<177091171280.3376561.14754481998879091306@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38192,"web_url":"https://patchwork.libcamera.org/comment/38192/","msgid":"<95368066-1d80-47d1-8394-a3820a93a2c6@ideasonboard.com>","date":"2026-02-12T15:56:04","subject":"Re: [PATCH] android: camera_stream: Include instead of\n\t","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 12. 16:28 keltezéssel, Laurent Pinchart írta:\n> The standard C library header for the poll() API is poll.h, not\n> sys/poll.h. The musl C library warns about this:\n> \n> In file included from src/android/camera_stream.cpp:13:\n> host/i586-buildroot-linux-musl/sysroot/usr/include/sys/poll.h:1:2: error: #warning redirecting incorrect #include to [-Werror=cpp]\n> 1 | #warning redirecting incorrect #include to \n> | ^~~~~~~\n> \n> Fix it by including the correct header.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/android/camera_stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 1d68540d7e50..7da01dc30031 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -8,9 +8,9 @@\n> #include \"camera_stream.h\"\n> \n> #include \n> +#include \n> #include \n> #include \n> -#include \n> #include \n> \n> #include \n> \n> base-commit: 1dcf9957a47fb54fce4fbae9daec0b587e52562e","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68F11BD78E\n\tfor ;\n\tThu, 12 Feb 2026 15:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FA8B621D0;\n\tThu, 12 Feb 2026 16:56:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE91F61FBF\n\tfor ;\n\tThu, 12 Feb 2026 16:56:07 +0100 (CET)","from [192.168.33.66] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6A936A6;\n\tThu, 12 Feb 2026 16:55:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NAuUvCqG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770911720;\n\tbh=91nm+OXA7rYSlzKqsiz0otwhXql2LpcBEBLc2VHFmNE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=NAuUvCqG4HpB6cyQja+IdZzj70ZJShE4sn0ghVeb/EiJyArUlxVNtpTK3uTUnRvcL\n\tH/KLN4id+2mqulcA4Celh9eLEBT95cjRjvnC7VHfSm4dsVBxNXd40HgmiaNvSc6988\n\thCVgKhNK5iC9mBR3JgHoTY+dMqxA0iaut4kI2NJc=","Message-ID":"<95368066-1d80-47d1-8394-a3820a93a2c6@ideasonboard.com>","Date":"Thu, 12 Feb 2026 16:56:04 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] android: camera_stream: Include instead of\n\t","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]