[{"id":38194,"web_url":"https://patchwork.libcamera.org/comment/38194/","msgid":"<19d71d4f-b7b8-47f6-9e91-1271141b8068@ideasonboard.com>","date":"2026-02-13T09:15:54","subject":"Re: [PATCH v2 3/4] libcamera: Use `it` variable name for iterators\n\tonly","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 12. 16:12 keltezéssel, Laurent Pinchart írta:\n> Using the name `it` for a variable that is not an iterator is confusing.\n> Give the variable a more explanatory name.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/ipa_data_serializer.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 61bada52f691..0dda76d5b1d1 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -114,12 +114,12 @@ public:\n> \t\tappendPOD(dataVec, vecLen);\n> \n> \t\t/* Serialize the members. */\n> -\t\tfor (auto const &it : data) {\n> +\t\tfor (const auto &value : data) {\n> \t\t\tstd::vector dvec;\n> \t\t\tstd::vector fvec;\n> \n> \t\t\tstd::tie(dvec, fvec) =\n> -\t\t\t\tIPADataSerializer::serialize(it, cs);\n> +\t\t\t\tIPADataSerializer::serialize(value, cs);\n> \n> \t\t\tappendPOD(dataVec, dvec.size());\n> \t\t\tappendPOD(dataVec, fvec.size());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 119FEBD78E\n\tfor ;\n\tFri, 13 Feb 2026 09:16:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4C4A621D4;\n\tFri, 13 Feb 2026 10:15:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 493EC621CC\n\tfor ;\n\tFri, 13 Feb 2026 10:15:55 +0100 (CET)","from [192.168.33.67] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B67F4180F;\n\tFri, 13 Feb 2026 10:15:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IJCC5lRO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770974106;\n\tbh=QiUWZBlTkwShRDnNsvxyG0GluUjZPJcbYCyK71HiEuY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IJCC5lROeePdsW38ZZeP/aeuYbvzqf1EcQNy9qoYxVL1D1Z6ceTFJBh1VuNnsf2Hl\n\t96DTQcp4c+jdWBjEMdzcxobFhSej3iF0JwJHSz+EhshXjZPF0TaZ2Nq5kQUEdAAe6h\n\tJLf9lal+4rEcgTlIJR7eraPMLuc3vYK/Y8ynTE7A=","Message-ID":"<19d71d4f-b7b8-47f6-9e91-1271141b8068@ideasonboard.com>","Date":"Fri, 13 Feb 2026 10:15:54 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/4] libcamera: Use `it` variable name for iterators\n\tonly","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>\n\t<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38319,"web_url":"https://patchwork.libcamera.org/comment/38319/","msgid":"<177247334397.3877752.17071208926064395128@t16>","date":"2026-03-02T17:42:23","subject":"Re: [PATCH v2 3/4] libcamera: Use `it` variable name for iterators\n\tonly","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Laurent,\n\nQuoting Laurent Pinchart (2026-02-12 15:12:37)\n> Using the name `it` for a variable that is not an iterator is confusing.\n> Give the variable a more explanatory name.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Isaac Scott \n\n> ---\n> include/libcamera/internal/ipa_data_serializer.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 61bada52f691..0dda76d5b1d1 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -114,12 +114,12 @@ public:\n> appendPOD(dataVec, vecLen);\n> \n> /* Serialize the members. */\n> - for (auto const &it : data) {\n> + for (const auto &value : data) {\n> std::vector dvec;\n> std::vector fvec;\n> \n> std::tie(dvec, fvec) =\n> - IPADataSerializer::serialize(it, cs);\n> + IPADataSerializer::serialize(value, cs);\n> \n> appendPOD(dataVec, dvec.size());\n> appendPOD(dataVec, fvec.size());\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 028C6BE086\n\tfor ;\n\tMon, 2 Mar 2026 17:42:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1BCA62080;\n\tMon, 2 Mar 2026 18:42:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CFC162080\n\tfor ;\n\tMon, 2 Mar 2026 18:42:27 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBD41986;\n\tMon, 2 Mar 2026 18:41:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aMbRfKKd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772473286;\n\tbh=Umtv8PHusDg2ZeQkA0AN78jR14kJKQa5hCtBiEnwBuE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=aMbRfKKdrkrUqNYAWmq1Rr3b/ozmqp9GbFQ1baas+zoabb5ADg7kyB5SWkHPG7/vZ\n\tpLKSCpeoJv7fWbtPw/MG9EMRz69nbnHv23AaA0xSOHLwOevXWvJJQwqf/AQ6noETj9\n\tUVeddp4/g5eWxNCw18qVjjazMDfjouCTaslmCsCc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","References":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>\n\t<20260212151238.3736234-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v2 3/4] libcamera: Use `it` variable name for iterators\n\tonly","From":"Isaac Scott ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 02 Mar 2026 17:42:23 +0000","Message-ID":"<177247334397.3877752.17071208926064395128@t16>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]