{"id":26134,"url":"https://patchwork.libcamera.org/api/patches/26134/?format=json","web_url":"https://patchwork.libcamera.org/patch/26134/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260211170037.131630-2-johannes.goede@oss.qualcomm.com>","date":"2026-02-11T17:00:37","name":"[2/2] software_isp: benchmark: Print what is being benchmarked","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b81bc3fc98139cc5f25dc91a4038b2c549c5158e","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/?format=json","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26134/mbox/","series":[{"id":5785,"url":"https://patchwork.libcamera.org/api/series/5785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5785","date":"2026-02-11T17:00:36","name":"[1/2] software_isp: benchmark: Add missing _ postfix to measure data member","version":1,"mbox":"https://patchwork.libcamera.org/series/5785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26134/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26134/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB449C3292\n\tfor ;\n\tWed, 11 Feb 2026 17:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCB1C621C0;\n\tWed, 11 Feb 2026 18:00:48 +0100 (CET)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A301C621B7\n\tfor ;\n\tWed, 11 Feb 2026 18:00:46 +0100 (CET)","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61B9JNLF3322724 for ;\n\tWed, 11 Feb 2026 17:00:45 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8epsjuh5-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tWed, 11 Feb 2026 17:00:45 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8c52f07fbd0so2287424685a.2\n\tfor ;\n\tWed, 11 Feb 2026 09:00:45 -0800 (PST)","from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-65a3cebf697sm867606a12.10.2026.02.11.09.00.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 11 Feb 2026 09:00:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"nFGmRgvU\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"FjAEuIUk\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=YUON/1GQCFL\n\tuc3ROMfRInAeiz6HJnBkOVMnn806CNAI=; b=nFGmRgvUviQre7b1wgLYzM9Hddw\n\tTz9BS/3TsBxzC+DAGUF9eKQHgxjhLb5pXT0ju4tsp72sLQAw67NQrX4WheVcJyLH\n\tNWOJR6huG7ocEypIygiqcyedqcCCvgZgRwQewzHhRPm+ZodYF9Ho107s1JeOzY9r\n\tihyXb1eBQEV+n8PACOmEd9S/uI4jpzuAdPiF4WEkrGZpVRRCTSYdWSLe+EGoyAEs\n\tkzb5eOpKOtT0cYxv+nUkY6B3mJ0HY4+pAYPxTYPHEDpibtEyUfHGhD96Q77jM/1c\n\t8CCD2mX/dgfRxmyQDUKvdqlR9MiImdz4+3WQWBX5Kv8/K98iNUqXjtGeYvQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1770829244; x=1771434044;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=YUON/1GQCFLuc3ROMfRInAeiz6HJnBkOVMnn806CNAI=;\n\tb=FjAEuIUkTuTCqdh2ZeNFBJCjdhNt7pUwLhR4ryCPeOnuB6svYBAunr3sz89GDPGA8/\n\tC9KWKaQjrIaUNx2kljoZD/BquLLFAllwwEatuF/oiP4lwrJLAQsnA9VK7CjbIjhj336f\n\tAAzKKKS11nQYw+0p6WAlRaA3WyvZc3KJSOxvk8icXeAmhyRqRhstDTkVaIjJZLOz3KYx\n\tTaYmRfOc6uJoGp80pTNFqbTcX3BgRNmPQEPmf2ULh3aHSOVOkAUwC9j+w+RAsaGeqKl5\n\tkRdBMETSLMzWIQimKTDIbtwUOuZH8xjNQ+61nkj5K6egMDM9NujtmDcmFHnN884/4s8U\n\tlQfg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770829244; x=1771434044;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=YUON/1GQCFLuc3ROMfRInAeiz6HJnBkOVMnn806CNAI=;\n\tb=YITGpGLmBOkWLeyauQD0IIwydWYKlx6JucPuK39L1qKH+eLUOWmnZdBlCA8xV7kiM4\n\tgRvyr22pbhzIFjVoA6xY4q2HllyM+ItE5KDGwyNumWCHSC9cKvF9IaMwcF53fV19bYrL\n\ttgKc/Ltt1Y7oVcagfgPE6UxoHGlAk0QTxFJ7UkoKuUGUVUjjxurOx78ALUWHw3mAKIEq\n\txq7Ezw3mq00bJtuu4QF47Dm1btAjfZwohI5junNlyfGvHdY2PcPW55/j5PS+TIDCyHto\n\t1zMLGJDbe5NDIGMQEeExdLdQa6ssM0YfMFtTHrHPxDzwRDM0vGJilpnFbtwzL0gHaVnj\n\tva2w==","X-Gm-Message-State":"AOJu0Yw0aaqKiiaUuyGmJUPjAgZGsrMWPEkGrY6T6WcAQ54zTh5+Ejt+\n\t1lz+jjzbO9AoCo/f0fdpk2msp4z5NN5Z3Why1C7J5243ZrrImOAh9Dl/mRForW+DSlX/3cO48zk\n\tABQM+r4aoYC7fVRidLI6Bw4ZiabHEaIFVAm4TYuiKF5WrtFNKieqnbqZ+exINkx3OmUB98fMRnJ\n\tfFWlcgzOY4","X-Gm-Gg":"AZuq6aItNiSGY9a9GGPrsCVHlLDXNTrFHLwmEUdDdNbvvYFvLoT3CRe2/fD1X3fPIYh\n\taBB9N34l5cnnSTi0yqKIzBkPD4AMoBv8N4OtK4DX65yRuQQCksmUKCpzStQX+QJZ2jAIeb/d1M+\n\tTw4kwcC5jAI0HaoiLiAwYot3k7K/QYM+0eY+XfHgu90hidyrmKX/QCBad8J17RV/6pGzXDTPzgV\n\tWZBmGJ/wfu5T5IsNYS9Hknao3TDX6jQmp+ZhuikfMYyFsgB0q+opgeX/FOVN/YYFgGVLKFIiMDF\n\tNjwOI36I4ejBFiy89+0e6UF9wfiYGagI+zzfmf+4NR5onFUolN9DdXcP6Adhuv4vc0J/ktLD1rg\n\t0xgSJ/nqmU82rVTIlWLpiDoDI1ZG+NQPThQf8oVliVx548bRAxjy8GiTHwpxB+xez1sWL3xLckH\n\tSJeNUd1TZ8exlRiB6j2WACQlP+gWD5w9OPfePB","X-Received":["by 2002:a05:620a:294b:b0:8ca:2bab:a0fb with SMTP id\n\taf79cd13be357-8cb27f76910mr484448385a.11.1770829242551; \n\tWed, 11 Feb 2026 09:00:42 -0800 (PST)","by 2002:a05:620a:294b:b0:8ca:2bab:a0fb with SMTP id\n\taf79cd13be357-8cb27f76910mr484414085a.11.1770829240404; \n\tWed, 11 Feb 2026 09:00:40 -0800 (PST)"],"From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org, Milan Zamazal ","Cc":"Hans de Goede ","Subject":"[PATCH 2/2] software_isp: benchmark: Print what is being benchmarked","Date":"Wed, 11 Feb 2026 18:00:37 +0100","Message-ID":"<20260211170037.131630-2-johannes.goede@oss.qualcomm.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260211170037.131630-1-johannes.goede@oss.qualcomm.com>","References":"<20260211170037.131630-1-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjExMDEzMSBTYWx0ZWRfX9NqmD8w+lvQ6\n\tAQ2kdLiC29Y6xX+ECyIIPNmMb9GVhiPlNdZvVzdt+bW8GZnI5uqoaIr/O7bC2JV8JzBoveZKSHH\n\tlo3yInxQrUQrXBT0MnCyveAUCK13676l3klInakeEfRSW7C+Z2T0Fz/3Z1MhP5cTM9FriFQ95Cc\n\t2yYASDfLDTih5hTn5OHYpWdQJbRGbrdu27uSh4kI6ecA0y8wnG6eXGBMuEbPDsmkGjZHNbivWCJ\n\t9sNKWtbP38DrZ7QaNvjKEvN5MHPGe1DgeTgeqvzHLz++c93WX0EDxkBp5eTOuXYC7kr53NyOXLl\n\t624fusxUe+IF+dIt6goYA38GiQi6pwuIGqF/ftnAchz+a7JZrscV3hOn7Tl3b2dI//5aawTQAdN\n\tIDBFqA4ayuxIa+xtzIF9I+eDcYs/0cJ7azELRtmdoSFrH5fyhyaHqrlWXzKqwc9BDaPLlOmc9ZM\n\t0En/lskM4v6YqocaqRg==","X-Proofpoint-ORIG-GUID":"0Ihcx8L-3zM_lb26_iMMAmC44pj9XnbG","X-Proofpoint-GUID":"0Ihcx8L-3zM_lb26_iMMAmC44pj9XnbG","X-Authority-Analysis":"v=2.4 cv=I/Vohdgg c=1 sm=1 tr=0 ts=698cb5bd cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=l68oApq_WO2ZGngkTEkA:9\n\ta=IoWCM6iH3mJn3m4BftBB:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-11_02,2026-02-11_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tclxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501\n\tbulkscore=0\n\tmalwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0\n\tadultscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2601150000\n\tdefinitions=main-2602110131","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"With the GPU accelerated softISP 2 separate benchmark results are printed,\n1 for the generation of the output images on the GPU and a separate one\nfor generating the statistics on the CPU.\n\nAdd a new name argument to the Benchmark class descriptor and print this\nout when printing the benchmark result.\n\nSigned-off-by: Hans de Goede \n---\n include/libcamera/internal/software_isp/benchmark.h | 3 ++-\n src/libcamera/software_isp/benchmark.cpp | 5 +++--\n src/libcamera/software_isp/debayer.cpp | 3 ++-\n src/libcamera/software_isp/swstats_cpu.cpp | 2 +-\n 4 files changed, 8 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\nindex 46bdb86d..9c181927 100644\n--- a/include/libcamera/internal/software_isp/benchmark.h\n+++ b/include/libcamera/internal/software_isp/benchmark.h\n@@ -20,13 +20,14 @@ namespace libcamera {\n class Benchmark\n {\n public:\n-\tBenchmark(const GlobalConfiguration &configuration);\n+\tBenchmark(const GlobalConfiguration &configuration, const std::string &name);\n \t~Benchmark();\n \n \tvoid startFrame(void);\n \tvoid finishFrame(void);\n \n private:\n+\tstd::string name_;\n \ttimespec frameStartTime_;\n \tbool measure_;\n \t/* Skip 30 frames for things to stabilize then measure 30 frames */\ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex 4ffb6773..e0fffaba 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -26,8 +26,9 @@ LOG_DEFINE_CATEGORY(Benchmark)\n /**\n * \\brief Constructs a Benchmark object\n */\n-Benchmark::Benchmark(const GlobalConfiguration &configuration)\n+Benchmark::Benchmark(const GlobalConfiguration &configuration, const std::string &name)\n {\n+\tname_ = name;\n \tskipBeforeMeasure_ = configuration.option(\n \t\t\t\t\t\t{ \"software_isp\", \"measure\", \"skip\" })\n \t\t\t\t\t\t\t.value_or(skipBeforeMeasure_);\n@@ -81,7 +82,7 @@ void Benchmark::finishFrame(void)\n \t\tframeProcessTime_ += timeDiff(frameEndTime, frameStartTime_);\n \t\tif (encounteredFrames_ == skipBeforeMeasure_ + framesToMeasure_) {\n \t\t\tLOG(Benchmark, Info)\n-\t\t\t\t<< \"Processed \" << framesToMeasure_\n+\t\t\t\t<< name_ << \" processed \" << framesToMeasure_\n \t\t\t\t<< \" frames in \" << frameProcessTime_ / 1000 << \"us, \"\n \t\t\t\t<< frameProcessTime_ / (1000 * framesToMeasure_)\n \t\t\t\t<< \" us/frame\";\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex dccdd86b..a6bceb58 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -58,7 +58,8 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n-Debayer::Debayer(const GlobalConfiguration &configuration) : bench_(configuration)\n+Debayer::Debayer(const GlobalConfiguration &configuration)\n+\t: bench_(configuration, \"Debayer\")\n {\n }\n \ndiff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 5c3011a7..1cedcfbc 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -155,7 +155,7 @@ namespace libcamera {\n LOG_DEFINE_CATEGORY(SwStatsCpu)\n \n SwStatsCpu::SwStatsCpu(const GlobalConfiguration &configuration)\n-\t: sharedStats_(\"softIsp_stats\"), bench_(configuration)\n+\t: sharedStats_(\"softIsp_stats\"), bench_(configuration, \"CPU stats\")\n {\n \tif (!sharedStats_)\n \t\tLOG(SwStatsCpu, Error)\n","prefixes":["2/2"]}