[{"id":38155,"web_url":"https://patchwork.libcamera.org/comment/38155/","msgid":"","date":"2026-02-08T13:49:52","subject":"Re: [PATCH v13 6/7] ipa: rkisp1: algorithms: data: enable DPF tuning\n\tfor sensors","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Rui,\n\nThe commit title should be:\n\nipa: rkisp1: ov5640: Update Denoise tuning data\n\nOn Fri, Feb 06, 2026 at 10:12:04AM -0500, Rui Wang wrote:\n> Update the RkISP1 denoise pre-filter (DPF) for the ov5640\n> sensor tuning config by adding the required DPF tuning block.\n\nUpdate the RkISP1 version of ov5640 tuning file to comply with the\nnewly introduced changes to the Dpf algorithm.\n\nUpdate not only the tuning data layout but also their values, according\nto newly performed tuning, to support four configurations modes of the Dpf\nengine.\n\n>\n> Signed-off-by: Rui Wang \n\nAcked-by: Jacopo Mondi \n\n>\n> ---\n> changelog since v5: No change\n>\n> changelog since v6:\n> add ov5647 as strong noise sensor for verification\n>\n> changelog since v7:\n> - move ov5647 yaml out this commit and will add brand new commit\n> - Update dpf tuning paras format , delete base config following\n> parseConfig code change\n>\n> change log since v8:\n> - move imx219 out to another commit\n> - update DPF tuning paramter for sample\n> change log since v9:\n> - Update imx219/ov5647 dpf tuning structure as new parser required\n> change log since v11:\n> - Change \"ActiveMode\" to \"activemode\"\n> ---\n> src/ipa/rkisp1/data/ov5640.yaml | 64 +++++++++++++++++++++++++--------\n> 1 file changed, 50 insertions(+), 14 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> index 4b21d412..9b754afb 100644\n> --- a/src/ipa/rkisp1/data/ov5640.yaml\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -232,19 +232,55 @@ algorithms:\n> green: 2\n> red-blue: 2\n> - Dpf:\n> - DomainFilter:\n> - g: [ 16, 16, 16, 16, 16, 16 ]\n> - rb: [ 16, 16, 16, 16, 16, 16 ]\n> - NoiseLevelFunction:\n> - coeff: [\n> - 1023, 1023, 1023, 1023, 1023, 1023, 1023, 1023,\n> - 1023, 1023, 1023, 1023, 1023, 1023, 1023, 1023,\n> - 1023\n> - ]\n> - scale-mode: \"linear\"\n> - FilterStrength:\n> - r: 64\n> - g: 64\n> - b: 64\n> + NoiseReductionModes:\n> + NoiseReductionModeMinimal:\n> + DomainFilter:\n> + g: [ 14, 10, 7, 4, 2, 1 ]\n> + rb: [ 14, 11, 8, 4, 2, 1 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392,\n> + 448, 508, 572, 640, 712 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 60\n> + g: 60\n> + b: 60\n> + NoiseReductionModeHighQuality:\n> + DomainFilter:\n> + g: [ 22, 18, 13, 8, 5, 2 ]\n> + rb: [ 20, 18, 16, 11, 7, 3 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392,\n> + 448, 508, 572, 640, 712 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 130\n> + g: 130\n> + b: 130\n> + NoiseReductionModeFast:\n> + DomainFilter:\n> + g: [ 16, 12, 9, 5, 3, 1 ]\n> + rb: [ 16, 13, 10, 6, 4, 2 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 16, 32, 48, 66, 86, 108, 132, 160, 192, 228, 268,\n> + 312, 360, 412, 468, 528 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 90\n> + g: 90\n> + b: 90\n> + NoiseReductionModeZsl:\n> + DomainFilter:\n> + g: [ 18, 14, 10, 6, 3, 1 ]\n> + rb: [ 18, 16, 13, 9, 5, 3 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 20, 40, 60, 82, 106, 132, 160, 192, 228, 268, 312,\n> + 360, 412, 468, 528, 592 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 110\n> + g: 110\n> + b: 110\n> + activeMode: \"NoiseReductionModeHighQuality\"\n> - Filter:\n> ...\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","kbingham@ideasonboard.com"],"Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E9E5BD78E\n\tfor ;\n\tMon, 9 Feb 2026 12:48:08 +0000 (UTC)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C76C263F\n\tfor ;\n\tMon, 9 Feb 2026 13:47:22 +0100 (CET)","from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id tXFyIVqUiGkDbyUA4E0KoQ\n\t(envelope-from )\n\tfor ; Sun, 08 Feb 2026 14:49:14 +0100","from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid 06C6CC6C;\tSun, 8 Feb 2026 14:49:14 +0100 (CET)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C60AF6209D;\n\tSun, 8 Feb 2026 14:49:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA5F161FC6\n\tfor ;\n\tSun, 8 Feb 2026 14:49:55 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 821A5C6C;\n\tSun, 8 Feb 2026 14:49:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770641242;\n\tbh=q/6ZvePrl+8iU7xg88PuAozlsd6b1Ov4r+CglJP6OYk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tResent-From:Resent-To:From;\n\tb=nCK7ns23XSWi/BQH1Lgwp0/jaqIZxIXtW+hZ0fcvhqi78phfiK63AbgHajqY6kZaR\n\tm0AKDef7VDDhX00HIMpLH5EuMAhn5aM5DUIAcvbDSKilKBnLprlnwMEmivNW7f38CQ\n\tL8h1tsUg/AgH2OjfqZMuWQ0KiAp98cNUe+N2jnsw=","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770558550;\n\tbh=q/6ZvePrl+8iU7xg88PuAozlsd6b1Ov4r+CglJP6OYk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nNxXsH32sHJUB+UnFW499Qx0s+iqDuN6Pk8gnI5S9jfjpp2s41K5G0O2fh0GkuDBa\n\tNIpDQmZuX62ISb8iWy12xJyvF8YchghBREt7QxQy+StjMsBfye9WGMmx2n6Q3gZnxf\n\tukRge1j+jtmG3LUI7TtNs8Q16zj6UiCLXt0ont40="],"Authentication-Results":["perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=nNxXsH32; dkim-atps=neutral","lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nNxXsH32\";\tdkim-atps=neutral"],"Date":"Sun, 8 Feb 2026 14:49:52 +0100","From":"Jacopo Mondi ","To":"Rui Wang ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v13 6/7] ipa: rkisp1: algorithms: data: enable DPF tuning\n\tfor sensors","Message-ID":"","References":"<20260206151205.143671-1-rui.wang@ideasonboard.com>\n\t<20260206151205.143671-7-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260206151205.143671-7-rui.wang@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" ","X-TUID":"EI9ILFyVE+83","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"}}]