{"id":26113,"url":"https://patchwork.libcamera.org/api/patches/26113/?format=json","web_url":"https://patchwork.libcamera.org/patch/26113/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260206151205.143671-4-rui.wang@ideasonboard.com>","date":"2026-02-06T15:12:01","name":"[v13,3/7] ipa: rkisp1: algorithms: register noise reduction controls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e12e32647983eb8c3537214658c17d54cae32929","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26113/mbox/","series":[{"id":5775,"url":"https://patchwork.libcamera.org/api/series/5775/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5775","date":"2026-02-06T15:11:58","name":"refactor DPF parsing and initialization","version":13,"mbox":"https://patchwork.libcamera.org/series/5775/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26113/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26113/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","kbingham@ideasonboard.com"],"Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 874C3C3220\n\tfor ;\n\tMon, 9 Feb 2026 12:47:55 +0000 (UTC)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0D3863F\n\tfor ;\n\tMon, 9 Feb 2026 13:47:09 +0100 (CET)","from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id 0D1DHbUEhmltSxgA4E0KoQ\n\t(envelope-from )\n\tfor ; Fri, 06 Feb 2026 16:11:49 +0100","from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid 0913B1752;\tFri, 6 Feb 2026 16:11:47 +0100 (CET)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB58362091;\n\tFri, 6 Feb 2026 16:12:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAE1762091\n\tfor ;\n\tFri, 6 Feb 2026 16:12:25 +0100 (CET)","from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 425402E0;\n\tFri, 6 Feb 2026 16:11:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770641229;\n\tbh=h0NRG0EK/7/A3f9e9q37SbY6v3ynHokIwbP/yBVBXBs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tResent-From:Resent-To:From;\n\tb=R1hew/lMRvVZgglgWLrBpJE3mNwJVzsH9eY5p46lopx1bGoE0B2TNxHCAEbQ89Anh\n\tC1sJFxXxxLp8gUoNIjxne9plulRN32MmvcULlg8GspaS4wwPBIfPyOFanY2VQlw1Iv\n\t/4DhcQ94mFvJ7lSGcTlq7kt4WC6PqVYNSXlI1JMg=","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770390702;\n\tbh=h0NRG0EK/7/A3f9e9q37SbY6v3ynHokIwbP/yBVBXBs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JZIioPHPaeMnliOxPyVgyEZtVk5Pv0FtwJLt2SZaKaMcxjta0MrHxgBf1R0enfgIe\n\tSe1uqCKA94u5//ZU/Hzq14UlC3eRIEKGqscSkw61HeZNVpkz1l4XXLS0rZIgej7is4\n\t12q3mwtj5rD3fmk1iG2QJ73yM0x+2F+eFszjkeCI="],"Authentication-Results":["perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=JZIioPHP; dkim-atps=neutral","lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JZIioPHP\";\tdkim-atps=neutral"],"From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ,\n\tIsaac Scott ,\n\tJacopo Mondi ","Subject":"[PATCH v13 3/7] ipa: rkisp1: algorithms: register noise reduction\n\tcontrols","Date":"Fri, 6 Feb 2026 10:12:01 -0500","Message-ID":"<20260206151205.143671-4-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260206151205.143671-1-rui.wang@ideasonboard.com>","References":"<20260206151205.143671-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" ","X-TUID":"GcvNc2Vr3XpT","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"},"content":"Register NoiseReductionMode controls based on the tuning data and default\nto the active DPF mode. Remove the static NoiseReductionMode entry from\nthe IPA control map now that DPF owns its registration.\n\nSigned-off-by: Rui Wang \nReviewed-by: Isaac Scott \nReviewed-by: Jacopo Mondi \n\n---\n changelog :\n --No change since v10\n changelog since v11:\n - Simple Debug log\n changelog since v12:\n - remove curly braceket of for looper\n\n Reviewed-by tags from v11 are carried over (no function changes).\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 20 ++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 1 -\n 3 files changed, 21 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 9d7fcc1c..5f46253e 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -52,6 +52,9 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Register available controls. */\n+\tregisterControls(context);\n+\n \treturn 0;\n }\n \n@@ -117,6 +120,23 @@ int Dpf::parseConfig(const YamlObject &tuningData)\n \treturn 0;\n }\n \n+void Dpf::registerControls(IPAContext &context)\n+{\n+\t/*\n+\t * Populate the control map with the available noise reduction modes.\n+\t * This allows applications to query and select from the modes defined\n+\t * in the tuning data.\n+\t */\n+\tstd::vector modes{};\n+\tfor (const auto &mode : noiseReductionModes_)\n+\t\tmodes.emplace_back(mode.modeValue);\n+\t/*\n+\t * Set the default mode to the active mode.\n+\t */\n+\tcontext.ctrlMap[&controls::draft::NoiseReductionMode] =\n+\t\tControlInfo(modes, activeMode_->modeValue);\n+}\n+\n int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig)\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 11fc88e4..43effcbe 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -37,6 +37,7 @@ private:\n \t};\n \n \tint parseConfig(const YamlObject &tuningData);\n+\tvoid registerControls(IPAContext &context);\n \tint parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex fbcc3910..402ed62c 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -120,7 +120,6 @@ const IPAHwSettings ipaHwSettingsV12{\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n-\t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n \n } /* namespace */\n","prefixes":["v13","3/7"]}