[{"id":38135,"web_url":"https://patchwork.libcamera.org/comment/38135/","msgid":"","date":"2026-02-08T13:52:41","subject":"Re: [PATCH v13 7/7] ipa: rkisp1: algorithms: data: Add IMX219 Dpf\n\tinto tuning file","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Rui\n for the commit title:\n\nipa: rkisp1: imx219: Add Dpf tuning data\n\nOn Fri, Feb 06, 2026 at 10:12:05AM -0500, Rui Wang wrote:\n> This includes initial settings for DPF algorithms.\n\nAdd Dpf tuning data to the RkISP1 version of the imx219 tuning file.\n\nAdd support for two configuration modes and enable the \"HighQuality\"\none by default.\n\n>\n> Add Dpf tuning config into Imx219\n>\n> Signed-off-by: Rui Wang \n\nAcked-by: Jacopo Mondi \n\n>\n> ---\n> changelog since v7 :\n> - move imx219 dpf tuning config\n> - update tuning parameters since \"key\" update\n>\n> changelog since v9:\n> - Update dpf tuning config regarding reduction mode format\n> from list to dictionary\n> - add ActiveMode for dpf default mode\n>\n> changelog since v10:\n> - Modify ReductionMinimal - > NoiseReductionModeMinimal\n> since parser code update\n> changelog since v11:\n> - Change \"ActiveMode\" to \"activeMode\"\n>\n> changelog since v12:\n> - delete ov5647 tuning config\n> - delete build config for ov5647\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 25 +++++++++++++++++++++++++\n> 1 file changed, 25 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index 0d99cb52..e8d2acbb 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -111,4 +111,29 @@ algorithms:\n> 1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,\n> 1326, 1334, 1334,\n> ]\n> + - Dpf:\n> + NoiseReductionModes:\n> + NoiseReductionModeMinimal:\n> + DomainFilter:\n> + g: [ 14, 10, 7, 4, 2, 1 ]\n> + rb: [ 14, 11, 8, 4, 2, 1 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 60\n> + g: 60\n> + b: 60\n> + NoiseReductionModeHighQuality:\n> + DomainFilter:\n> + g: [ 22, 18, 13, 8, 5, 2 ]\n> + rb: [ 20, 18, 16, 11, 7, 3 ]\n> + NoiseLevelFunction:\n> + coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n> + scale-mode: \"linear\"\n> + FilterStrength:\n> + r: 130\n> + g: 130\n> + b: 130\n> + activeMode: \"NoiseReductionModeHighQuality\"\n> ...\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51D8CC3220\n\tfor ;\n\tSun, 8 Feb 2026 13:52:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A622261FC6;\n\tSun, 8 Feb 2026 14:52:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE2961FC6\n\tfor ;\n\tSun, 8 Feb 2026 14:52:44 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA180C6C;\n\tSun, 8 Feb 2026 14:51:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dT8TKBSk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770558719;\n\tbh=etiImag5/7LVVnL2QrCmlx0AiD4Wv6/lV2lyPnDSCP4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dT8TKBSkSiXWmhE8PY1PZl7ICJUfbzLWjDQ2bnKYzFxSd6oIGO12XCljPjdV1JiNy\n\tJHoIZ/epnc6JSYaJ1wnY0ntyu79vgPRHIxjwWYdY38A9OeDpKKcNajVCeiasVRmo+R\n\t1l/qW5qZoi3/4S1O6zn6tK1ZHg9+MVIjVtb9/KuU=","Date":"Sun, 8 Feb 2026 14:52:41 +0100","From":"Jacopo Mondi ","To":"Rui Wang ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v13 7/7] ipa: rkisp1: algorithms: data: Add IMX219 Dpf\n\tinto tuning file","Message-ID":"","References":"<20260206151205.143671-1-rui.wang@ideasonboard.com>\n\t<20260206151205.143671-8-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260206151205.143671-8-rui.wang@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]