[{"id":387,"web_url":"https://patchwork.libcamera.org/comment/387/","msgid":"<20190117204318.GE23244@pendragon.ideasonboard.com>","date":"2019-01-17T20:43:18","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: event_dispatcher_poll:\n\tFix trivial spelling","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\nOn Thu, Jan 17, 2019 at 08:20:43PM +0000, Kieran Bingham wrote:\n> Correct the spelling of 'notifiers'.\n> \n> Fixes: 8356f8a6ab87 (\"libcamera: Add a poll-based event dispatcher\")\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/event_dispatcher_poll.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\n> index 69edfcbf2725..2072ae0aa3da 100644\n> --- a/src/libcamera/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/event_dispatcher_poll.cpp\n> @@ -146,7 +146,7 @@ void EventDispatcherPoll::processEvents()\n>  \t\t\t   << timeout.tv_nsec;\n>  \t}\n>  \n> -\t/* Wait for events and process notifers and timers. */\n> +\t/* Wait for events and process notifiers and timers. */\n>  \tret = ppoll(pollfds.data(), pollfds.size(),\n>  \t\t    nextTimer ? &timeout : nullptr, nullptr);\n>  \tif (ret < 0) {","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F9AF60B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jan 2019 21:43:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1821053E;\n\tThu, 17 Jan 2019 21:43:18 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547757798;\n\tbh=Bm9GGC0AT7UfWkzHETk6strMUP95mol4p+or6sqP+wg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SlsFhKO1bA+WC9qawXYnGSqPLUEI4TJYYIo4jygNUhuwczjiJdK0j9jpXeNYmohW0\n\tWE92m0eyWo0J27NsMb4TPPaYlI7tMvKg1VyOmDMGEF67ddFekx6/ENCXmdYizOqXMY\n\t5biI0bNvWpNsL6Vna0lYD+78I8nBrA1Z0VhjX1uw=","Date":"Thu, 17 Jan 2019 22:43:18 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190117204318.GE23244@pendragon.ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190117202043.21420-6-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: event_dispatcher_poll:\n\tFix trivial spelling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 17 Jan 2019 20:43:18 -0000"}},{"id":396,"web_url":"https://patchwork.libcamera.org/comment/396/","msgid":"<20190117220222.GP6484@bigcity.dyn.berto.se>","date":"2019-01-17T22:02:22","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: event_dispatcher_poll:\n\tFix trivial spelling","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your patch.\n\nOn 2019-01-17 20:20:43 +0000, Kieran Bingham wrote:\n> Correct the spelling of 'notifiers'.\n> \n> Fixes: 8356f8a6ab87 (\"libcamera: Add a poll-based event dispatcher\")\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/libcamera/event_dispatcher_poll.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\n> index 69edfcbf2725..2072ae0aa3da 100644\n> --- a/src/libcamera/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/event_dispatcher_poll.cpp\n> @@ -146,7 +146,7 @@ void EventDispatcherPoll::processEvents()\n>  \t\t\t   << timeout.tv_nsec;\n>  \t}\n>  \n> -\t/* Wait for events and process notifers and timers. */\n> +\t/* Wait for events and process notifiers and timers. */\n>  \tret = ppoll(pollfds.data(), pollfds.size(),\n>  \t\t    nextTimer ? &timeout : nullptr, nullptr);\n>  \tif (ret < 0) {\n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBD6C60B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jan 2019 23:02:23 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id v15-v6so9868480ljh.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jan 2019 14:02:23 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tf8sm565484lfe.72.2019.01.17.14.02.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 17 Jan 2019 14:02:22 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=2qFfmUsRrtyOsoepBl4U2FzC8VjtiirS+AyUrEirNgI=;\n\tb=pkClImVkoLa9x5GdmxdRFw6AWbvvijM4z7gpxuZG1zuQShhoMNOFZb1sJKndb+TPLY\n\tOYvutajMbdhTJZCG98FRGizFpguB9ptYVXLZkBOv3Cr0jinRNb17N8Ivy1c8VcFd6C6w\n\t+AkvEURyBNclXrqrRl2bJ5gIdUbmnm6mj5V+yu+HKG/jwxrX5I6bFI5St5yUn45W8wBB\n\tnCeXRdZAS2UYZEBoGbEiZ1V0RrEGyoEPL812eGw6q34wttOeBCrRsucPClISAzBVC6r6\n\t19E7EmysVUiBKbqIaRBuT+YBI/BRqIrJlSL6JITyqu2xLVZ6wg9EhUEy16mLZlP+6S9F\n\tul5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=2qFfmUsRrtyOsoepBl4U2FzC8VjtiirS+AyUrEirNgI=;\n\tb=kzde8gE2ihIdgysXe/lwjhwY1gfTF9rpy4txS2pTUifCzdOAHq7gJDQUHteadG1O8o\n\t6yu0Hl3ANR2YHs7gBJYA9QV8jlugwqVLFiV/ARKE2p0m4INiyirvElO4VeQi+XtCGPPv\n\txsvaICe78VE46Bm/9OdZBDas1TCiEgYpfwbP+Ry4OZilqelGXEn4U4rN/6jn81vyDovJ\n\t9WQWFOrurtlKKASDqGSX40wna+GRWqJzjRW9m4K5f8RJevFLYP5Lbk9kBNIEr1Jbmec6\n\tIwUujnFEy7S9nbGKAG3cxmiRoEp/ageM3rBLMT1wPvqBMiwaBy6mcBszxQrp6+gnkHGO\n\tMjTw==","X-Gm-Message-State":"AJcUuke3Xg3g5rT5+DFYthtj5TigTKyX6MvCbfgFTZgaXkE4TUEihxJp\n\ty1Gs9C8wpUmw0YA3Cb3cXeG5bQ==","X-Google-Smtp-Source":"ALg8bN7GNNcYTbLBtUXKQAQcEDJw/xOSxOciBG0QVw/sNLVQjhvm8j5m67n3pRSP3t9sU53LwpImjw==","X-Received":"by 2002:a05:651c:14e:: with SMTP id\n\tc14mr10357013ljd.20.1547762543054; \n\tThu, 17 Jan 2019 14:02:23 -0800 (PST)","Date":"Thu, 17 Jan 2019 23:02:22 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190117220222.GP6484@bigcity.dyn.berto.se>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190117202043.21420-6-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: event_dispatcher_poll:\n\tFix trivial spelling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 17 Jan 2019 22:02:24 -0000"}}]