[{"id":38083,"web_url":"https://patchwork.libcamera.org/comment/38083/","msgid":"<aYRLbOVLZPjgssbL@zed>","date":"2026-02-05T07:49:34","subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Wed, Feb 04, 2026 at 10:42:58PM +0000, Kieran Bingham wrote:\n> When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\n> error log has a typo. Fix the typo and reflow the line while here.\n\nTook me a while to spot the \"SOFISP\" misspelling\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n>  1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n>  \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n>  \tif (softISPMode) {\n>  \t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n> -\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n> -\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> +\t\t\tLOG(SoftwareIsp, Error)\n> +\t\t\t\t<< \"LIBCAMERA_SOFTISP_MODE \"\n> +\t\t\t\t<< softISPMode.value() << \" invalid \"\n> +\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n>  \t\t\treturn;\n>  \t\t}\n>  \t}\n>\n> --\n> 2.52.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A5C5C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  5 Feb 2026 07:49:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F70362051;\n\tThu,  5 Feb 2026 08:49:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60D1E61A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Feb 2026 08:49:37 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81D7146F;\n\tThu,  5 Feb 2026 08:48:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YmiDMPaK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770277734;\n\tbh=NoHkNDLwaEcVJfbNJI6FmIxtxZsaj+ds6YlG9zBoEZM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YmiDMPaKjp/MeQPE7BauUd8WnW3jQJrmQp4Fkvx4F8UvbG/A0CV/ipLgTXDjc/1La\n\tUNgQhz4rFuWjqfUsxtiDQpcEbMbZV+CmzA4w8Wnu5zMvUJD/ixsFOYmmrZZOrdjnq0\n\tECpuQdQQAr9mnsMT8NMbrt3qXB0gEkJIfFqXA798=","Date":"Thu, 5 Feb 2026 08:49:34 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","Message-ID":"<aYRLbOVLZPjgssbL@zed>","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38085,"web_url":"https://patchwork.libcamera.org/comment/38085/","msgid":"<177028581277.1199731.1764531761068249818@ping.linuxembedded.co.uk>","date":"2026-02-05T10:03:32","subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-02-05 07:49:34)\n> Hi Kieran\n> \n> On Wed, Feb 04, 2026 at 10:42:58PM +0000, Kieran Bingham wrote:\n> > When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\n> > error log has a typo. Fix the typo and reflow the line while here.\n> \n> Took me a while to spot the \"SOFISP\" misspelling\n\nGuess which string I used to try to 'set' the ISP to CPU mode ...\n\n--\nKieran\n\n> \n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> \n> Thanks\n>   j\n> \n> >\n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > ---\n> >  src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n> >  1 file changed, 4 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> > index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644\n> > --- a/src/libcamera/software_isp/software_isp.cpp\n> > +++ b/src/libcamera/software_isp/software_isp.cpp\n> > @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> >       std::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n> >       if (softISPMode) {\n> >               if (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n> > -                     LOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n> > -                                             << \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> > +                     LOG(SoftwareIsp, Error)\n> > +                             << \"LIBCAMERA_SOFTISP_MODE \"\n> > +                             << softISPMode.value() << \" invalid \"\n> > +                             << \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> >                       return;\n> >               }\n> >       }\n> >\n> > --\n> > 2.52.0\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DF5FC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  5 Feb 2026 10:03:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D71D62053;\n\tThu,  5 Feb 2026 11:03:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDA6D61F84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Feb 2026 11:03:35 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B88F227;\n\tThu,  5 Feb 2026 11:02:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XRPjgA7R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770285773;\n\tbh=fOWoMQ959J7Hei2Bz2+jAN7u61bwXINLRWohK6Cbx9c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XRPjgA7RVSFN92Yj/8nlianF6V/yRv+tFVpoGf+VFD7ITd1pzP0IziGQqpFPmN7sV\n\tcXucAmlDHfP+ubgybZTx/l5mI0dDTAq7e1sXlIsSe4PTz8ZrAJdO/fQ8CBYwFkY8S0\n\tHlDgfloubacrzQurIdBhWQ3+sEKiKG3C03C8QP/g=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<aYRLbOVLZPjgssbL@zed>","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>\n\t<aYRLbOVLZPjgssbL@zed>","Subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Date":"Thu, 05 Feb 2026 10:03:32 +0000","Message-ID":"<177028581277.1199731.1764531761068249818@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38086,"web_url":"https://patchwork.libcamera.org/comment/38086/","msgid":"<83ffcad0-8011-4b1b-9f57-bc20d3b8a83f@ideasonboard.com>","date":"2026-02-05T10:26:34","subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 04. 23:42 keltezéssel, Kieran Bingham írta:\n> When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\n> error log has a typo. Fix the typo and reflow the line while here.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>   src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n>   1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n>   \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n>   \tif (softISPMode) {\n>   \t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n> -\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n> -\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> +\t\t\tLOG(SoftwareIsp, Error)\n> +\t\t\t\t<< \"LIBCAMERA_SOFTISP_MODE \"\n> +\t\t\t\t<< softISPMode.value() << \" invalid \"\n> +\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n\nI think this message could be improved, at least to me something like\n\n   LIBCAMERA_SOFTISP_MODE must be \"cpu\" or \"gpu\", got \"XYZ\"\n\nis easier to understand.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   \t\t\treturn;\n>   \t\t}\n>   \t}\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE48AC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  5 Feb 2026 10:26:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D72746204A;\n\tThu,  5 Feb 2026 11:26:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C0FE61F84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Feb 2026 11:26:38 +0100 (CET)","from [192.168.33.53] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63B68227;\n\tThu,  5 Feb 2026 11:25:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KptPYDqu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770287155;\n\tbh=1Vc0r1m7HeZm3pne+y/hxBynOQZgMyg0Bi4si2jInPA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KptPYDqutlKNLVL+kvp5rM8CaY+fYSoBxuKBqV2uoMffxKW1lTbP7KuQAw92YwV4a\n\tiwTqWiV5AX9qtoFbGkHIXYE+ug3C74/XSq4v39+ok4xeit6kFUU31htvSMcQF6mOYE\n\tUnx72K+vbvMuNynHMDjYJEVQ+fxctcZqSf1MrD08=","Message-ID":"<83ffcad0-8011-4b1b-9f57-bc20d3b8a83f@ideasonboard.com>","Date":"Thu, 5 Feb 2026 11:26:34 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38103,"web_url":"https://patchwork.libcamera.org/comment/38103/","msgid":"<20260205225134.GF170964@killaraus>","date":"2026-02-05T22:51:34","subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Feb 05, 2026 at 11:26:34AM +0100, Barnabás Pőcze wrote:\n> 2026. 02. 04. 23:42 keltezéssel, Kieran Bingham írta:\n> > When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\n> > error log has a typo. Fix the typo and reflow the line while here.\n> > \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > ---\n> >   src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n> >   1 file changed, 4 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> > index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644\n> > --- a/src/libcamera/software_isp/software_isp.cpp\n> > +++ b/src/libcamera/software_isp/software_isp.cpp\n> > @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> >   \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n> >   \tif (softISPMode) {\n> >   \t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n> > -\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n> > -\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> > +\t\t\tLOG(SoftwareIsp, Error)\n> > +\t\t\t\t<< \"LIBCAMERA_SOFTISP_MODE \"\n> > +\t\t\t\t<< softISPMode.value() << \" invalid \"\n> > +\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> \n> I think this message could be improved, at least to me something like\n> \n>    LIBCAMERA_SOFTISP_MODE must be \"cpu\" or \"gpu\", got \"XYZ\"\n\nOr\n\tInvalid LIBCAMERA_SOFTISP_MODE \"xyz\", must be \"cpu\" or \"gpu\"\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> is easier to understand.\n> \n> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> \n> >   \t\t\treturn;\n> >   \t\t}\n> >   \t}\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53BE4C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  5 Feb 2026 22:51:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4027162069;\n\tThu,  5 Feb 2026 23:51:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0DBD62010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Feb 2026 23:51:35 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 32B3AD0;\n\tThu,  5 Feb 2026 23:50:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JiRIimhb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770331852;\n\tbh=oEEpGPdeMSpJxpGBU3Jb78tyn3nUJkKteBzzJYVlOoM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JiRIimhbRo3AoiuN/5fJqcsZmcTmGtC3AZPaTjrxwJJXyWO8iFxtC1zyzQ8oq/0jY\n\t1CgivNYgZS7EfnVyHG8Crbp6vog6N+6lUejejYS0Odb706P1l5RQ8RnzXM2on86WbF\n\tERI6EoGi8VvADDhLqZR6RXuo2l7zc2Gde+l2FsyY=","Date":"Fri, 6 Feb 2026 00:51:34 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Cc":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/3] libcamera: software_isp: Fix\n\tLIBCAMERA_SOFTISP_MODE log print","Message-ID":"<20260205225134.GF170964@killaraus>","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>\n\t<83ffcad0-8011-4b1b-9f57-bc20d3b8a83f@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<83ffcad0-8011-4b1b-9f57-bc20d3b8a83f@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]