[{"id":38084,"web_url":"https://patchwork.libcamera.org/comment/38084/","msgid":"","date":"2026-02-05T07:51:50","subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Wed, Feb 04, 2026 at 10:42:56PM +0000, Kieran Bingham wrote:\n> The Awb brief was not updated from when the Bayes AWB was added.\n>\n> Extend it to account for this.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms {\n>\n> /**\n> * \\class Awb\n> - * \\brief A Grey world white balance correction algorithm\n> + * \\brief Manage the white balance with automatic and manual controls\n> */\n>\n> LOG_DEFINE_CATEGORY(RkISP1Awb)\n>\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1460CBD78E\n\tfor ;\n\tThu, 5 Feb 2026 07:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 491DF62048;\n\tThu, 5 Feb 2026 08:51:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 323D861A35\n\tfor ;\n\tThu, 5 Feb 2026 08:51:53 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6154E46F;\n\tThu, 5 Feb 2026 08:51:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cn9DuEme\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770277870;\n\tbh=3Kd4wYpWtzXMcnl7QmX5/qzKO8jd6S5eHUGt8+nemD0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cn9DuEmemd6NrIOlj+OLX1W/vGX+vX2xr4pSnA6rF4bOe9oe+wuulWj6ohKlzsTsG\n\t20F9t/8Z+ZV61DnyZ4wXJoLh8HahMxsShwjWVTOfw+NVaWX3gfVLkYrLMNvGUW8VPS\n\trPKbYuk09MmXfIiyzHxoeQBy38lvk4Gm0VzN+2g8=","Date":"Thu, 5 Feb 2026 08:51:50 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","Message-ID":"","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38087,"web_url":"https://patchwork.libcamera.org/comment/38087/","msgid":"<2b4b2ecb-c6f9-4f44-b512-817b5e504b99@ideasonboard.com>","date":"2026-02-05T10:27:03","subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 04. 23:42 keltezéssel, Kieran Bingham írta:\n> The Awb brief was not updated from when the Bayes AWB was added.\n> \n> Extend it to account for this.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n\nLooks ok to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms {\n> \n> /**\n> * \\class Awb\n> - * \\brief A Grey world white balance correction algorithm\n> + * \\brief Manage the white balance with automatic and manual controls\n> */\n> \n> LOG_DEFINE_CATEGORY(RkISP1Awb)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E25D4C31E9\n\tfor ;\n\tThu, 5 Feb 2026 10:27:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85B2462052;\n\tThu, 5 Feb 2026 11:27:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC93361F84\n\tfor ;\n\tThu, 5 Feb 2026 11:27:07 +0100 (CET)","from [192.168.33.53] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19369227;\n\tThu, 5 Feb 2026 11:26:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TDpG96cH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770287185;\n\tbh=YSCg+rK0ELyU6NZjFJC6rKDzJs0fCF3H8FR2jXw0GcQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=TDpG96cHT+yTsPB0g/4FHSeE09vMJ0oQ29PhHUc0im3pgJxq4GAP4tWv/xHjmvQ3T\n\tlGpW9i72n+Khz3jMkO8WnIsnLBFIC3NswZ7lYWuFXeoVFjwRz7IHMjkg7okuEmEMTU\n\tPeXodC9DSTzF9pvNxcpz/fftW5y6H9ajpxW+/lks=","Message-ID":"<2b4b2ecb-c6f9-4f44-b512-817b5e504b99@ideasonboard.com>","Date":"Thu, 5 Feb 2026 11:27:03 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38159,"web_url":"https://patchwork.libcamera.org/comment/38159/","msgid":"<85ecmtlxg9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-02-09T15:59:34","subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> The Awb brief was not updated from when the Bayes AWB was added.\n>\n> Extend it to account for this.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms {\n> \n> /**\n> * \\class Awb\n> - * \\brief A Grey world white balance correction algorithm\n> + * \\brief Manage the white balance with automatic and manual controls\n> */\n> \n> LOG_DEFINE_CATEGORY(RkISP1Awb)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 486AEC3220\n\tfor ;\n\tMon, 9 Feb 2026 15:59:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17D5D620FA;\n\tMon, 9 Feb 2026 16:59:42 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBF9561FA0\n\tfor ;\n\tMon, 9 Feb 2026 16:59:40 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-457-ktjtVY5DOLCrTvDwNsyTew-1; Mon, 09 Feb 2026 10:59:38 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-480686b3b4cso62819375e9.0\n\tfor ;\n\tMon, 09 Feb 2026 07:59:37 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48320719b8fsm275721685e9.9.2026.02.09.07.59.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Feb 2026 07:59:35 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OWb1p3CF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1770652779;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=YruT4SHCtpP1NkDZLd5yR80IywOtbReoydy8370VJuk=;\n\tb=OWb1p3CFM/LgVp/XqMG2AoGmC9Ofbkwf10Y3BkfJtsqwBV4WvQkUQPljHSnYsxzv1UPubz\n\tZEv6vsj+mtgT/Xj0GEj3wt7fE+zMyIG1VEZT+iRMaCDvbke7Dfxjm6Ilx49Ov44OX2uqHh\n\tZMni+MIjxWaoLZrrq73/Y/ztlfI/JQw=","X-MC-Unique":"ktjtVY5DOLCrTvDwNsyTew-1","X-Mimecast-MFC-AGG-ID":"ktjtVY5DOLCrTvDwNsyTew_1770652777","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770652777; x=1771257577;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=YruT4SHCtpP1NkDZLd5yR80IywOtbReoydy8370VJuk=;\n\tb=hdJoH65/w6H3hZE291CtVZkZ5aBTxsi76nD0EwYm8/pRPXzGLRbjk+5YVbxwPh5l0o\n\tDGucHz8XBE7gIrDekRbZKppY603bMc+4lexBizIbwBca4I3q6s5kUxkJE4t2fONejdNd\n\teiFnshUit9droIk3osP22ThnGTpokbb6NfXOHu/9UOYgr9/1lBRKFjgqX7PPb1YS6lTd\n\tnToFIp2mcO+QTf6brszMdsu8jZLklfRkVchWfnm59l5NgRbtWfARmWLbbHEIOdDHfHgU\n\ta5xyu6x53Tq2NZkvymeDGKy98wXN2WJRqT8t4Q7rBNe6RCN/tSKEG+fnTx5cL5tW9Ulb\n\tL4gw==","X-Gm-Message-State":"AOJu0Yx29jYFnF1i4KNpKhttxF2hGS4Pgpwxhr/hrpTqt+th1CilNgt3\n\t+thoWc6mS0Wk8gNf84AS4BID4NQ2qLoPBUzwNES49B8oyeWXHyXXhrUSP0SwdZv/iietzGOv9sl\n\tUKhZjPIM9K4ZXIr+ZcQ3MTmu2E1rnzQLoe6cjFA3CiVMDvijenj9RoglUbdvxFGQmYz8NmtJTHy\n\tuAArGf1rtOOJBh/wyyEG426yneUgV7ZRxdV5nDU3tqGf/1e+yCpQac2oNBPrk=","X-Gm-Gg":"AZuq6aJwQQsJFQ6iNnjA4oEA/E2/P78FJ/9tigJMS11AgHDfledPWep5ldv5g/mez14\n\tPQQepqc7mwUPnUwP6yWoEv+8tEIQXv586zGufT/iHG/1WC504pK9i8bEeCGdib8yuHtvaclAY7p\n\tjNMoOJPCbxFuwA3ZSIWBClZ2z5bY6e6Kp0puJ3dSXRqfBtRxdb6qO0LDCfs0afBOZ0xYC1uqkVu\n\torpBW99QXyY8h6c6Qrew+lYDSa53BqRk2Qj98bEH34EgXmXyo0mzX2k9JXNl2jSyVnLjPLJ0psr\n\tCCJ3DH8W5JKtznk2fllZBacAfpdzneCy5+4n2MCAKQFQpHX0QtYpIx68vaBMURolgVGRG6j/7m/\n\tAvGrCyPeiVaQ8kYJNpkXohHV5vYV5SLQWIkn1vaKveK5fFJ5agRtxRaMkPYKFBPQ=","X-Received":["by 2002:a05:600c:3552:b0:480:4a90:1afe with SMTP id\n\t5b1f17b1804b1-48320339137mr185642685e9.34.1770652776663; \n\tMon, 09 Feb 2026 07:59:36 -0800 (PST)","by 2002:a05:600c:3552:b0:480:4a90:1afe with SMTP id\n\t5b1f17b1804b1-48320339137mr185642085e9.34.1770652776135; \n\tMon, 09 Feb 2026 07:59:36 -0800 (PST)"],"From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief","In-Reply-To":"<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>\n\t(Kieran Bingham's message of \"Wed, 04 Feb 2026 22:42:56 +0000\")","References":"<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>\n\t<20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com>","Date":"Mon, 09 Feb 2026 16:59:34 +0100","Message-ID":"<85ecmtlxg9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"UuIeJgVciPHhjkAgXKJJmQhMqGPZHL6KkBAITocyz0o_1770652777","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]