{"id":26088,"url":"https://patchwork.libcamera.org/api/patches/26088/?format=json","web_url":"https://patchwork.libcamera.org/patch/26088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260204203726.1820226-2-faizel.kb@gmail.com>","date":"2026-02-04T20:37:24","name":"[v3,1/3] media: vimc: sensor: Move vimc_sensor_device to common header","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"9ac9755488d2c4de361ef09ec457c18b0496903a","submitter":{"id":258,"url":"https://patchwork.libcamera.org/api/people/258/?format=json","name":"Faizel K B","email":"faizel.kb@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26088/mbox/","series":[{"id":5771,"url":"https://patchwork.libcamera.org/api/series/5771/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5771","date":"2026-02-04T20:37:23","name":"media: vimc: Add timing controls for fps config","version":3,"mbox":"https://patchwork.libcamera.org/series/5771/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26088/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0945BD78E\n\tfor ;\n\tWed, 4 Feb 2026 20:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D2986204C;\n\tWed, 4 Feb 2026 21:38:12 +0100 (CET)","from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n\t[IPv6:2607:f8b0:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA27361FBF\n\tfor ;\n\tWed, 4 Feb 2026 21:38:10 +0100 (CET)","by mail-pl1-x629.google.com with SMTP id\n\td9443c01a7336-2a929763b57so210105ad.3\n\tfor ;\n\tWed, 04 Feb 2026 12:38:10 -0800 (PST)","from FAIZEL-KB.. ([2001:569:5999:dc00:876b:c389:85e5:7957])\n\tby smtp.googlemail.com with ESMTPSA id\n\td9443c01a7336-2a933974884sm31136955ad.83.2026.02.04.12.38.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Feb 2026 12:38:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"W3xctmxA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1770237489; x=1770842289;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=;\n\tb=W3xctmxAMKKWXEtpM0q90zaifzGlH7inUmPsGGMbkF7zzaWrgx28PpPlzg2xMe30w3\n\tp7qt+EN+/oVJsTTP3x2oaMnuW3M+oV3gMPtoSvsFPb1ukL6iiH5WGuj40fgj/+yHd4C3\n\tGaHifV3VRAGcSHiVAb15WXmKq1W9XNVzJCbveFG2NX9iSwK7hFn+gYv4Wv/jCSQBEUMx\n\t/ceNvgVQUlJWMcDuzvVkTCUAAeG2wQzYhQ/+R5ftA5p01N/GM4nhRkyVcEVGXoO6HulL\n\t0c182D0JCTcZjk+A/oL1lfO2QBKc8OsSD0+SkjkqK8OAbUlEy8c0ZA14pKOtllYHrqjo\n\te/+Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770237489; x=1770842289;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=;\n\tb=jrRtDAhOrdWECpT/s9HWj8Px413lmlQuO4kk+Nvv8edZxC9BLo5mphJWSAxq38PI+5\n\tYBa3UiLF7aG0iJ3oqWQ1BPPjtjEt4Tzw4blo0iJHWynW0OQAknsTS0L7ARIV4/JWwMM2\n\tlHRIBqdZFFipqxTrxsAme70+z0/OFMGSYk3He9UjvMk0XA4U4Ts7/LnPgtPlm9qYkFdY\n\teYZooeQlu7Pvkl/xjk7BACQ38/idPlmWhjcMgnpa6HckmWxdETR38btZJd3tyEoAGsxY\n\tWFVYMTc5Ffjn4xOYDJyIT3uZAPsQ7aXp0f+JSe9xPwcxf/xT9u7+auzQwbLWemGJ/Amt\n\te/Rw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUY79dZUcPrltfNQtZGGaOyU6tx10TeFyN7VEjKLGwg6gkDUHZBXuatMrTS5nMLjiZdSOnE3eopzR8m1Yg0asM=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxCvQC/U+0s46MlQyw+qarijkhotFuNhH4JpdZgIviTJzgivbOq\n\t7mXDzjlq+U6dzk6u1r3Z6fh4mu3RhEezcKSd8uxeYbK4KcQgcKobnPz4","X-Gm-Gg":"AZuq6aJiD1eYseUaoggxggrILNew5ZhbDsoY4WCUoGGIPPZLlEAARK1vHZFc0ixF0T7\n\tuzkieLn9OQYzhSsPySaHclRllBYqNoWAlzZpvtJckE2OpKF5dB8gp2QXimiDTt5nPmwPsHQqwVl\n\tGFtuofYBB1+7usWP9oTThQNRp1o1CTGyMdPl9UnB4IzCOl0yZrpjx062gp0wtxNlalLoU/A6MFg\n\tlwCrSqGPJrKbaX8tUBKX4iohUS21y3BsP1Smibz73DacwSpLx1oCShG7ZwEqfeWH0Nyx6uPoOFj\n\tP2PSfV2y4JYwKew50kaowLDyX8cvtoOaFcv6rbnyCi0SiTe3qu2nnTh6z/Cs0z8ruAqYyugbV5l\n\t3Osoniygk0DCl20/A6PahXvJ6pZVkERRl8tb/sVuIqhg72/wMg32IXuJ9G+rNmLKsFYOyVfyq61\n\t8yAwPkZ5R/NWxqqbnClGjh+/MZVhh1yGq7q7VEXN24njqW","X-Received":"by 2002:a17:902:e806:b0:2a7:cbe3:a6e3 with SMTP id\n\td9443c01a7336-2a935bd69a2mr25281315ad.2.1770237489266; \n\tWed, 04 Feb 2026 12:38:09 -0800 (PST)","From":"Faizel K B ","To":"Shuah Khan ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tlinux-media@vger.kernel.org","Cc":"Mauro Carvalho Chehab ,\n\tlibcamera-devel@lists.libcamera.org, Faizel K B ","Subject":"[PATCH v3 1/3] media: vimc: sensor: Move vimc_sensor_device to\n\tcommon header","Date":"Wed, 4 Feb 2026 12:37:24 -0800","Message-ID":"<20260204203726.1820226-2-faizel.kb@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260204203726.1820226-1-faizel.kb@gmail.com>","References":"<20260204203726.1820226-1-faizel.kb@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the vimc_sensor_device structure from vimc-sensor.c to\nvimc-common.h to make it accessible to the vimc-streamer component.\n\nSigned-off-by: Faizel K B \n---\n drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++\n drivers/media/test-drivers/vimc/vimc-sensor.c | 26 -----------------\n 2 files changed, 28 insertions(+), 26 deletions(-)","diff":"diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h\nindex 7a45a2117748..35789add6b4a 100644\n--- a/drivers/media/test-drivers/vimc/vimc-common.h\n+++ b/drivers/media/test-drivers/vimc/vimc-common.h\n@@ -12,6 +12,8 @@\n #include \n #include \n #include \n+#include \n+#include \n \n #define VIMC_PDEV_NAME \"vimc\"\n \n@@ -159,6 +161,32 @@ struct vimc_ent_config {\n \tconst struct vimc_ent_type *type;\n };\n \n+enum vimc_sensor_osd_mode {\n+\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n+\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n+\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n+};\n+\n+struct vimc_sensor_device {\n+\tstruct vimc_ent_device ved;\n+\tstruct v4l2_subdev sd;\n+\tstruct tpg_data tpg;\n+\tstruct v4l2_ctrl_handler hdl;\n+\tstruct media_pad pad;\n+\n+\tu8 *frame;\n+\n+\t/*\n+\t * Virtual \"hardware\" configuration, filled when the stream starts or\n+\t * when controls are set.\n+\t */\n+\tstruct {\n+\t\tstruct v4l2_area size;\n+\t\tenum vimc_sensor_osd_mode osd_value;\n+\t\tu64 start_stream_ts;\n+\t} hw;\n+};\n+\n /**\n * vimc_is_source - returns true if the entity has only source pads\n *\ndiff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c\nindex 027767777763..2b07dc1f1278 100644\n--- a/drivers/media/test-drivers/vimc/vimc-sensor.c\n+++ b/drivers/media/test-drivers/vimc/vimc-sensor.c\n@@ -14,32 +14,6 @@\n \n #include \"vimc-common.h\"\n \n-enum vimc_sensor_osd_mode {\n-\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n-\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n-\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n-};\n-\n-struct vimc_sensor_device {\n-\tstruct vimc_ent_device ved;\n-\tstruct v4l2_subdev sd;\n-\tstruct tpg_data tpg;\n-\tstruct v4l2_ctrl_handler hdl;\n-\tstruct media_pad pad;\n-\n-\tu8 *frame;\n-\n-\t/*\n-\t * Virtual \"hardware\" configuration, filled when the stream starts or\n-\t * when controls are set.\n-\t */\n-\tstruct {\n-\t\tstruct v4l2_area size;\n-\t\tenum vimc_sensor_osd_mode osd_value;\n-\t\tu64 start_stream_ts;\n-\t} hw;\n-};\n-\n static const struct v4l2_mbus_framefmt fmt_default = {\n \t.width = 640,\n \t.height = 480,\n","prefixes":["v3","1/3"]}