{"id":26086,"url":"https://patchwork.libcamera.org/api/patches/26086/?format=json","web_url":"https://patchwork.libcamera.org/patch/26086/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260204154015.3755120-2-isaac.scott@ideasonboard.com>","date":"2026-02-04T15:40:15","name":"[RFC,1/1] camera_sensor: Ensure we try multiple camera sensor factories","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"53877fc14ca863b80fea19854d3b16aae6cef103","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/?format=json","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26086/mbox/","series":[{"id":5770,"url":"https://patchwork.libcamera.org/api/series/5770/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5770","date":"2026-02-04T15:40:14","name":"camera_sensor: Ensure we check all camera sensor factories","version":1,"mbox":"https://patchwork.libcamera.org/series/5770/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26086/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26086/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0ED4C32E7\n\tfor ;\n\tWed, 4 Feb 2026 15:40:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46CD261FBF;\n\tWed, 4 Feb 2026 16:40:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B01061FBF\n\tfor ;\n\tWed, 4 Feb 2026 16:40:44 +0100 (CET)","from t16.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F9845B2;\n\tWed, 4 Feb 2026 16:40:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PdXiz3cN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770219602;\n\tbh=TTTaEUbGVu4aT2uIDXWQBsEw2JDikLfRVspJa/r0EX8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PdXiz3cNLLwPbF7c4sB3UmQjJz1b5uvA7PsDs8vscRzixuobusirpaIvorYn3CEQ3\n\toe7mwKDFcD9ivixdIBFt3R8RjzEIbvv34c/f8ZFxxGysxrBR4sl+fz723c9Gmn/B9E\n\t6S8dOMHwIiv5I2xmGPKwVQ0U8QbAwgGyuA2vAwfs=","From":"Isaac Scott ","To":"libcamera-devel@lists.libcamera.org","Cc":"Isaac Scott ","Subject":"[RFC PATCH 1/1] camera_sensor: Ensure we try multiple camera sensor\n\tfactories","Date":"Wed, 4 Feb 2026 15:40:15 +0000","Message-ID":"<20260204154015.3755120-2-isaac.scott@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260204154015.3755120-1-isaac.scott@ideasonboard.com>","References":"<20260204154015.3755120-1-isaac.scott@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"CameraSensorFactory::match() should iterate through all available\ncamera sensor factories and in an attempt to find a CameraSensor class\nthat is suitable. Currently, it is implemented in such a way that it\nwill only try the first one before failing.\n\nRemove the early return to ensure all CameraSensor factories are checked\nbefore returning nullptr.\n\nSigned-off-by: Isaac Scott \n---\n src/libcamera/sensor/camera_sensor.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex 05390d1e1..42407b14b 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -479,12 +479,10 @@ std::unique_ptr CameraSensorFactoryBase::create(MediaEntity *entit\n \t\t\treturn std::get>(std::move(result));\n \t\t}\n \n-\t\tif (std::get(result)) {\n+\t\tif (std::get(result))\n \t\t\tLOG(CameraSensor, Error)\n \t\t\t\t<< \"Failed to create sensor for '\"\n \t\t\t\t<< entity->name() << \": \" << std::get(result);\n-\t\t\treturn nullptr;\n-\t\t}\n \t}\n \n \treturn nullptr;\n","prefixes":["RFC","1/1"]}