{"id":26080,"url":"https://patchwork.libcamera.org/api/patches/26080/?format=json","web_url":"https://patchwork.libcamera.org/patch/26080/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260202194645.1287757-2-faizel.kb@gmail.com>","date":"2026-02-02T19:46:43","name":"[v2,1/3] media: vimc: sensor: Move vimc_sensor_device to common header","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"9ac9755488d2c4de361ef09ec457c18b0496903a","submitter":{"id":258,"url":"https://patchwork.libcamera.org/api/people/258/?format=json","name":"Faizel K B","email":"faizel.kb@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26080/mbox/","series":[{"id":5767,"url":"https://patchwork.libcamera.org/api/series/5767/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5767","date":"2026-02-02T19:46:42","name":"media: vimc: Add timing controls for fps config","version":2,"mbox":"https://patchwork.libcamera.org/series/5767/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26080/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26080/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65F0CC3226\n\tfor ;\n\tMon, 2 Feb 2026 19:47:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 146A762001;\n\tMon, 2 Feb 2026 20:47:08 +0100 (CET)","from mail-pg1-x529.google.com (mail-pg1-x529.google.com\n\t[IPv6:2607:f8b0:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 012E861FF6\n\tfor ;\n\tMon, 2 Feb 2026 20:47:06 +0100 (CET)","by mail-pg1-x529.google.com with SMTP id\n\t41be03b00d2f7-c634be422b2so304822a12.1\n\tfor ;\n\tMon, 02 Feb 2026 11:47:05 -0800 (PST)","from FAIZEL-KB.. ([2001:569:5999:dc00:af0:4465:b482:1e01])\n\tby smtp.googlemail.com with ESMTPSA id\n\td2e1a72fcca58-82379b1bc68sm16667416b3a.2.2026.02.02.11.47.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Feb 2026 11:47:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BtPJpIS4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1770061624; x=1770666424;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=;\n\tb=BtPJpIS4NQpdTjtAo5Gj0WNmOsyuXcWvZis2wV2lmLoaAoPLz+e9iHVLlxPiWJbET2\n\tbp1ik/KYZhNlUmPKw9jXOz+0lQTVjVTTEzxt15kJLJHRsJW+LHjZWJwRN3ZJHxD95we5\n\tyKJSkveseYKPAxCbOufsTCeAL4PBpCHhr437R9It8tDbmJ4+zpMZtU7J/aMy/21wlkSH\n\t8BMBksOymfC7WgBcynznwP21ewJHwiEsjUvkSrnTOpUgIhWpTaXfk/Zj5GwcL2lXnbZZ\n\tLSDAL6iXuyAyB3Jzh0BIyQSO3+/oIvVDeQNaEpyQ5poKX0NdJ9JWuLjUjNA0SfYbkIMp\n\tzbxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770061624; x=1770666424;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=;\n\tb=DuPbHi0OKdUKSvOTbt3K1FGe/S/Xpr2yrDBhiWVSVtdoaSJad6iiRBo+qw8x+5Qfi5\n\tgdScYAfywRh5gxvwMJ57wbQtLZJNkybr40GYnLEGztTjbtoX5DGp2lMDRU/SvJz9/kfD\n\tZIlhZWsKZyaJBGndYhVWwWMQXWDmWqExrc9I32UZW9kxmBb+JnbBMu1Cd8kWAfe+yRRn\n\tWltCMI+8D/7CBkqHSQY86LLG0xtrp3903sYwIW+pGTLWJUWfdVLx+j/KDp5pdrAb67Y4\n\t4t8EXx+juBqHEUe7MFz+h1Q+74mvwmI+QErjH0mT55eixsGxs3QFSUnD+jmfjlH5mOSu\n\t68yg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVAe2qeow5vTZ9YB/Rf0eVkBM01uOHhTGcC63wM1iOuf9N/E/4w2ep9DbKh1HWa5VTH5yxtRdlj18ZDpLbWuzI=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzGFl3iavpgFB8y2dC/zp2RKSvaOjDlcjhUiQqG6u7dBUfE52BF\n\tf6gPJ5ihjyV4zZcI7UDQpdvsnqB3k6V33VSphdnrg7418KKZan0bMYeb","X-Gm-Gg":"AZuq6aK9EsaIC3o7TYjbO+7aRKyY50Ji/cmlSjAgmpaMo2zVJJurq4DF2l4PVKwK/y9\n\tzYQA84LU3a4iOTtnew+B9uSYyA06/n3e769RnS9RejjX0oU0wW9sSpEntMwiIu9smyPcsE3Egpu\n\tE7Qq6pCl79KTmMrAhOZnAZyVHXOuUNjaMIO36H9yHyyB6z8GNkfIiba9WCHTL3q0CoWA/xpX9hI\n\tv/5jUghcXqylWmhHdjfUMAXv95BbhP3ugHO0Yj2QXQszQ50x+HWToOdiwfZVzKkSwzvHLULlpxs\n\tqPQt4E4LeXkPoN7CkSU8FN65fty40n419hHQmpWe6E8SM5AZBywF82XvDGdUUrgZwtE4KG9wB21\n\tABC5a3fpTG0K/0rXjlK3PZhCfEHSNVYk9Bxvu9fuSCJqQ1AJ8LksltgC6EEffjwUyAS8bCalfpS\n\twxXSd/Z3Z9oKVD+7WfCtv+xUTsIas+tJ8Fj587AYZu/v8=","X-Received":"by 2002:a05:6a00:3d4e:b0:808:434f:ba80 with SMTP id\n\td2e1a72fcca58-823aa6ef828mr10305790b3a.3.1770061624631; \n\tMon, 02 Feb 2026 11:47:04 -0800 (PST)","From":"Faizel K B ","To":"Shuah Khan ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tlinux-media@vger.kernel.org","Cc":"Mauro Carvalho Chehab ,\n\tlibcamera-devel@lists.libcamera.org, Faizel K B ","Subject":"[PATCH v2 1/3] media: vimc: sensor: Move vimc_sensor_device to\n\tcommon header","Date":"Mon, 2 Feb 2026 11:46:43 -0800","Message-ID":"<20260202194645.1287757-2-faizel.kb@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260202194645.1287757-1-faizel.kb@gmail.com>","References":"<20260202194645.1287757-1-faizel.kb@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the vimc_sensor_device structure from vimc-sensor.c to\nvimc-common.h to make it accessible to the vimc-streamer component.\n\nSigned-off-by: Faizel K B \n---\n drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++\n drivers/media/test-drivers/vimc/vimc-sensor.c | 26 -----------------\n 2 files changed, 28 insertions(+), 26 deletions(-)","diff":"diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h\nindex 7a45a2117748..35789add6b4a 100644\n--- a/drivers/media/test-drivers/vimc/vimc-common.h\n+++ b/drivers/media/test-drivers/vimc/vimc-common.h\n@@ -12,6 +12,8 @@\n #include \n #include \n #include \n+#include \n+#include \n \n #define VIMC_PDEV_NAME \"vimc\"\n \n@@ -159,6 +161,32 @@ struct vimc_ent_config {\n \tconst struct vimc_ent_type *type;\n };\n \n+enum vimc_sensor_osd_mode {\n+\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n+\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n+\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n+};\n+\n+struct vimc_sensor_device {\n+\tstruct vimc_ent_device ved;\n+\tstruct v4l2_subdev sd;\n+\tstruct tpg_data tpg;\n+\tstruct v4l2_ctrl_handler hdl;\n+\tstruct media_pad pad;\n+\n+\tu8 *frame;\n+\n+\t/*\n+\t * Virtual \"hardware\" configuration, filled when the stream starts or\n+\t * when controls are set.\n+\t */\n+\tstruct {\n+\t\tstruct v4l2_area size;\n+\t\tenum vimc_sensor_osd_mode osd_value;\n+\t\tu64 start_stream_ts;\n+\t} hw;\n+};\n+\n /**\n * vimc_is_source - returns true if the entity has only source pads\n *\ndiff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c\nindex 027767777763..2b07dc1f1278 100644\n--- a/drivers/media/test-drivers/vimc/vimc-sensor.c\n+++ b/drivers/media/test-drivers/vimc/vimc-sensor.c\n@@ -14,32 +14,6 @@\n \n #include \"vimc-common.h\"\n \n-enum vimc_sensor_osd_mode {\n-\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n-\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n-\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n-};\n-\n-struct vimc_sensor_device {\n-\tstruct vimc_ent_device ved;\n-\tstruct v4l2_subdev sd;\n-\tstruct tpg_data tpg;\n-\tstruct v4l2_ctrl_handler hdl;\n-\tstruct media_pad pad;\n-\n-\tu8 *frame;\n-\n-\t/*\n-\t * Virtual \"hardware\" configuration, filled when the stream starts or\n-\t * when controls are set.\n-\t */\n-\tstruct {\n-\t\tstruct v4l2_area size;\n-\t\tenum vimc_sensor_osd_mode osd_value;\n-\t\tu64 start_stream_ts;\n-\t} hw;\n-};\n-\n static const struct v4l2_mbus_framefmt fmt_default = {\n \t.width = 640,\n \t.height = 480,\n","prefixes":["v2","1/3"]}