[{"id":38045,"web_url":"https://patchwork.libcamera.org/comment/38045/","msgid":"<85jywu6hma.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-02-02T20:00:13","subject":"Re: [PATCH 3/3] ipa: simple: Remove duplicate header inclusion","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> The Awb component already references libcamera/control_ids.h. Remove\n> the incorrect duplicate inclusion of \"control_ids.h\".\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/algorithms/awb.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -17,8 +17,6 @@\n> #include \"libipa/colours.h\"\n> #include \"simple/ipa_context.h\"\n> \n> -#include \"control_ids.h\"\n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftAwb)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0268BD78E\n\tfor ;\n\tMon, 2 Feb 2026 20:00:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1713562002;\n\tMon, 2 Feb 2026 21:00:22 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2167161FEE\n\tfor ;\n\tMon, 2 Feb 2026 21:00:20 +0100 (CET)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-674-Cc6wjsDbPiW1Ckmp2Z0KiA-1; Mon, 02 Feb 2026 15:00:17 -0500","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-435ab907109so3280903f8f.3\n\tfor ;\n\tMon, 02 Feb 2026 12:00:17 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e10e46cesm46015189f8f.7.2026.02.02.12.00.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Feb 2026 12:00:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"G7+DfJa3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1770062419;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=pnImZNQVVD1lVSkS63rEWlz2y1QdppL5mxX3whEeJns=;\n\tb=G7+DfJa3nB2QVzouSPE1iHq43+1gaUgTRDn/wIVUx3j3lE6+JPiaA770fPsS6d8gkeUH8K\n\t37u5Lf0pan/2kqGtPYcojIMCZlG0LISsekPibrjBgTNj6oYpchmKRC5Xmd/rbBrE8VGDFG\n\tFpJKDyUxiOYNr+FK11uCn9Pjod1AD4Y=","X-MC-Unique":"Cc6wjsDbPiW1Ckmp2Z0KiA-1","X-Mimecast-MFC-AGG-ID":"Cc6wjsDbPiW1Ckmp2Z0KiA_1770062416","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770062416; x=1770667216;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=pnImZNQVVD1lVSkS63rEWlz2y1QdppL5mxX3whEeJns=;\n\tb=mTWy/6OVQlRrUqW5L0M+uxzNr5W6MaG7CDK1C0UZhNNCkwcSpUBEN0gm1L1FHT66vf\n\td9rWernBLqJ6INMwjqLnaO2J949n+N4yHZXNTdwsj+NNIYmgiudtqCf9geNukfLWYqwE\n\t81gb0gbUnK/WE/dk/zJAY/Rvk/cnO50CHkJRupJ9GLVIbnJqjoc5JCEQyLC3uhXIt/K/\n\tkj6RxV00v5m+ObNb449BSJQWys2n05H5NtnGlcQBSOFCKX2TpiS2YBP+WMYyg07WwZq7\n\tLnTQvl0Ool2DiP4O/6JFGXEvCcekmSzovnyJrEYn4SC8jrq0rxgYUYpKnwWDfXM5QTZH\n\tiHiQ==","X-Gm-Message-State":"AOJu0YxiFkii8uqaJrsUtTGd6ovLBUkF1sfpSa0avVZf0o5kI5IWnmw8\n\tDog3gBuf8UXjHgcN2sIzeECsPve5az1rOgVgdDXpmGdzKWeqc6mJKBSmohJqsmHstXcim+JIfmz\n\tt4iONOGxVkJ844sJULYzOJ0HrJvCzUKvyXFWTiLQ6/+hFnOmIwS/6poSRYnDJLOhALLjf/lzZKb\n\teSWnWZ0Mv7tbZc3DcPRtI/n4LhqCI3ec7j0opoJBi06q9iOVvfOdi8H6amQdc=","X-Gm-Gg":"AZuq6aJNzJWE8M0RFMTFaZkW65SKFPXzV0QYwD+CnPdPA75q3W9ExA/TW6BA1rwWp3w\n\tx2oGJv93G3iHmrQQt7PLyWR/JH03ed6+7LjxPEsH5Fb0FXHjFx0qmJBy/rqppITldpNNULzlHmt\n\tiH7HO8ThfoCLzzjwATJO0a5hKHzDmSqUldkPZAOySynu8nzQy4/dhfXi8/N6LRZ4S5p14JUgwY2\n\tnFVUxjYB/KkKthasF9/f3/qVfdBw5edExc9ei1jQ7HPnOa8jvhah4kF1Qo9jBBfdGg5zjim/kVk\n\t53VLpOHGDzEyRpZeblmImzWUA527vl0FXRMIB3tSBFDb0si+X3xdHhForRMtsNmTnqeWb+O2/Mr\n\tmK1zZjNzfvuyCf358UJh1IFrwMYAVnrP+YX2M3WAwlbQl1GmKrOc7O+HwpEQEDIc=","X-Received":["by 2002:a05:6000:2889:b0:431:74:cca with SMTP id\n\tffacd0b85a97d-435f3abb1a8mr19270235f8f.44.1770062415868; \n\tMon, 02 Feb 2026 12:00:15 -0800 (PST)","by 2002:a05:6000:2889:b0:431:74:cca with SMTP id\n\tffacd0b85a97d-435f3abb1a8mr19270184f8f.44.1770062415356; \n\tMon, 02 Feb 2026 12:00:15 -0800 (PST)"],"From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] ipa: simple: Remove duplicate header inclusion","In-Reply-To":"<20260202-kbingham-fixups-v1-3-7d7dd4b2a27b@ideasonboard.com>\n\t(Kieran Bingham's message of \"Mon, 02 Feb 2026 19:25:05 +0000\")","References":"<20260202-kbingham-fixups-v1-0-7d7dd4b2a27b@ideasonboard.com>\n\t<20260202-kbingham-fixups-v1-3-7d7dd4b2a27b@ideasonboard.com>","Date":"Mon, 02 Feb 2026 21:00:13 +0100","Message-ID":"<85jywu6hma.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"EwWaykvjvI7nvsJSAZJJvXOXF0Tw3AVJO3UxXz9jdRs_1770062416","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38052,"web_url":"https://patchwork.libcamera.org/comment/38052/","msgid":"","date":"2026-02-03T08:20:04","subject":"Re: [PATCH 3/3] ipa: simple: Remove duplicate header inclusion","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 02. 20:25 keltezéssel, Kieran Bingham írta:\n> The Awb component already references libcamera/control_ids.h. Remove\n> the incorrect duplicate inclusion of \"control_ids.h\".\n> \n> Signed-off-by: Kieran Bingham \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/simple/algorithms/awb.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -17,8 +17,6 @@\n> #include \"libipa/colours.h\"\n> #include \"simple/ipa_context.h\"\n> \n> -#include \"control_ids.h\"\n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftAwb)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 751DDBD78E\n\tfor ;\n\tTue, 3 Feb 2026 08:20:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 573D66200F;\n\tTue, 3 Feb 2026 09:20:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2767061FC4\n\tfor ;\n\tTue, 3 Feb 2026 09:20:09 +0100 (CET)","from [192.168.33.51] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCB3A161;\n\tTue, 3 Feb 2026 09:19:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Msp4OJS6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770106767;\n\tbh=vJQ3yzGMDF8ch957ZsUOIwEKfyS5w2QvlazCT5g5HuA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Msp4OJS6SKlj9UToWcGU+00NOgaWdmBXCKBUYq1HKgMA9VXdtTsNyXEW85VjvgQeU\n\tjOHRAdI4QLGN2yyJ8Lvj85Cil6DWAjUBcv3n1JimmNxFFlL7ODP+p2hB917QZBJH+J\n\tCb/ap2EhEKkX6K6rw793Ew4fxT0JpgrTIUert6qc=","Message-ID":"","Date":"Tue, 3 Feb 2026 09:20:04 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/3] ipa: simple: Remove duplicate header inclusion","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260202-kbingham-fixups-v1-0-7d7dd4b2a27b@ideasonboard.com>\n\t<20260202-kbingham-fixups-v1-3-7d7dd4b2a27b@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260202-kbingham-fixups-v1-3-7d7dd4b2a27b@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]