[{"id":38104,"web_url":"https://patchwork.libcamera.org/comment/38104/","msgid":"<20260205233527.GA1376807@killaraus.ideasonboard.com>","date":"2026-02-05T23:35:27","subject":"Re: [RFC PATCH v1 2/3] utils: checkstyle.py: Make custom dependency\n\tchecks possible","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Feb 02, 2026 at 12:25:10PM +0100, Barnabás Pőcze wrote:\n> Previously it was only possible check the presence of a dependency,\n\ns/check/to check/\n\n> but no further checks, such as version checks, could be carried out.\n> Make it possible for any checkers/formatters to specify a custom\n> function for each dependency that is invoked to carry out extra cheks.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/checkstyle.py | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index fa1355c17..06b9f199a 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -381,12 +381,22 @@ class CheckerBase(metaclass=ClassRegistry):\n> \n> issues = []\n> \n> - for command in cls.dependencies:\n> + for dep in cls.dependencies:\n> + check = None\n> + if type(dep) is str:\n> + command = dep\n> + else:\n> + (command, check) = dep\n> +\n> if command not in dependencies:\n> dependencies[command] = shutil.which(command)\n> \n> if not dependencies[command]:\n> issues.append(CommitIssue(f'Missing {command} to run {cls.__name__}'))\n> + elif check:\n> + issues_ = check()\n> + if issues_:\n> + issues.extend(issues_)\n> \n> return issues\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65EAEC31E9\n\tfor ;\n\tThu, 5 Feb 2026 23:35:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 637FA6206A;\n\tFri, 6 Feb 2026 00:35:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30C9461FBF\n\tfor ;\n\tFri, 6 Feb 2026 00:35:29 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C285A2E0;\n\tFri, 6 Feb 2026 00:34:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RUJcyqNq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770334485;\n\tbh=d7GS6IEj5JENjQ+CArg/adnAo3YYm8h7yMtxm/X8MUo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RUJcyqNqnCB5TNZn61YS8nlmBkRlP6Sz6MGpxuz6g4plm1ElboSAwwKV50KAbtTCw\n\tRnkLY9izaOov8nNENzgRhahSsPpDOJfVMDqtkdHJ1QNwcsnRhBnjaDTze0npcoGqRf\n\tkqecISK0fluhfmZiR5Bj9MQLbvLaUcnBG3HOG6qs=","Date":"Fri, 6 Feb 2026 01:35:27 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 2/3] utils: checkstyle.py: Make custom dependency\n\tchecks possible","Message-ID":"<20260205233527.GA1376807@killaraus.ideasonboard.com>","References":"<20260202112511.640320-1-barnabas.pocze@ideasonboard.com>\n\t<20260202112511.640320-3-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260202112511.640320-3-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]