[{"id":38030,"web_url":"https://patchwork.libcamera.org/comment/38030/","msgid":"<85h5s3td11.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T14:01:46","subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes:\n\n> Previously it was not possible to disable libtiff usage if it was\n> detected. Fix that by adding a meson feature option.\n>\n> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> ---\n>  meson_options.txt    | 5 +++++\n>  src/apps/meson.build | 2 +-\n>  2 files changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 58cf52ad1..8ad0de118 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -62,6 +62,11 @@ option('libdw',\n>          value : 'auto',\n>          description : 'Enable libdw integration for backtrace symbolization')\n>  \n> +option('libtiff',\n> +        type : 'feature',\n> +        value : 'auto',\n> +        description : 'Enable libtiff integration the cam and qcam applications for creating DNG files')\n\n\"... *in* the cam and qcam ...\"?\n\n> +\n>  option('libunwind',\n>          type : 'feature',\n>          value : 'auto',\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index af632b9a7..63ef6f173 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -10,7 +10,7 @@ if not libevent.found()\n>      libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n>  endif\n>  \n> -libtiff = dependency('libtiff-4', required : false)\n> +libtiff = dependency('libtiff-4', required : get_option('libtiff'))\n>  \n>  subdir('common')","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 603FCC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Jan 2026 14:01:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A68D61FCE;\n\tFri, 30 Jan 2026 15:01:54 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E99F61FC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Jan 2026 15:01:52 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-20-S2wfyQq9O3uW54RgmgGVzA-1; Fri, 30 Jan 2026 09:01:49 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-4806a27aa31so21431125e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Jan 2026 06:01:49 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4806cddffc0sm242586575e9.5.2026.01.30.06.01.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 06:01:46 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"A9bdc6f2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769781711;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=1648i8F1cIsmHq40drOXieyhYQpOiSvmeVYH+tWzix8=;\n\tb=A9bdc6f2AljrPL7uBcoys4eDhsKTGum2Nw0xXS2mTjmleCYmXGE0Q9LNIhuuuKJAvWT/XG\n\tHOPQP1eeVOCKc4D/zjpK3Ic3ooJQy/JtztsE8hGKwLPYFALJ/DU6Q96HsBRSZQcF2K29fI\n\t10Y+yKlyK8kfZSnx5L+CnbkBI3KVySw=","X-MC-Unique":"S2wfyQq9O3uW54RgmgGVzA-1","X-Mimecast-MFC-AGG-ID":"S2wfyQq9O3uW54RgmgGVzA_1769781708","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769781708; x=1770386508;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=62uUSQrFBETzX4mJscOw+E62px7vdZnzyijgisd+lJ8=;\n\tb=bcpdL4zGbGwAFbtNBCxfFqodEcIPp6RfP7wHFvfYyiE6OQaMgIvRG9E32C5PSrw3VB\n\tVvl/mf1mvkyBytsZ6IBPs0Q9zmfsC5ZMGaKWs1kJAgzWmdWgPZ4c5YI20dBzWfs6U8S5\n\tKkQORxIsRRotpQt2f1VOgX6lz+nAq5Nt7hqnK/V62VCc2CFKiP18p+6yNXwUgXAILUBc\n\tyvqosvs9BWGg6ELc/1mJyOCj/WrKO1aJJ9tsVnI+LebiaMfl1ZQd52x+ZoKlXtwxoGzW\n\taleLBxJnJxrM2syeJXfbXB4N77m053ImHhloYTyknKhYaM1EhHAbAQV6wbKbwxqAaDOe\n\t+5ag==","X-Gm-Message-State":"AOJu0YyXXTyZeuj1P5+WirtDKanVXxkVPQAKVP4exUKxejXaP5Vws+XR\n\t+HSQVBxSCcCiAp/Y/toGICjNu21Bx6N6Y3SmwM4Q5Q5f5g6Dz+d/UGUYUjbITDlTd4nweyskdiT\n\tALXDFlie5YnUwKgcgdPSi6WpldUGXkrox5RvBC7jb1tWnrbL/emGxhC2vLJ8X0HLuGPM43QzTCq\n\tQZ449hJJbzlq3MW4eHnXSPdy4mF9IK1/EiIJs1/SLyfonLmBH1IbYE6s936TE=","X-Gm-Gg":"AZuq6aJ76ZhkGRSd5btySDNqEUM57FXqpsp6/ahMYHE0jMIEyaoERT+TamTstpFSLvO\n\tn7KrvZhVo1DL/Sf3HOlc/ucEcSSytBToOw0IaXewiV2DlQpewN0S8j5+gtBei+IdsRix+0HU8mD\n\tvXURzirHS6BndwmGfDuwFN+1xGofX5bxxAx7MaxrVJVchUxCovXGrpMLDe3+AYdVtpVHF+Grnc7\n\tb3mxj1D4CoN8FYHYFMU6HgBXiPMWFcoQ4O/IR/GOX9s/HmKhrrJIEwN8P7lzWdzJTii6bbaaRhm\n\tlV5cIZi9ka4QGqik03HDABlWsxnAE4b94aryXowrhsnUnWZNhN6xxmOkAAJdTcm8JCaRIAbrtNZ\n\tnZFX346IoqDYOIwfV/c4ggSM3zGCvxNl9zAY117EeGe6QzY2cUIpKV1JkOrFNDjc=","X-Received":["by 2002:a05:600c:a01:b0:480:462e:d640 with SMTP id\n\t5b1f17b1804b1-482db4b53f0mr34149055e9.36.1769781708122; \n\tFri, 30 Jan 2026 06:01:48 -0800 (PST)","by 2002:a05:600c:a01:b0:480:462e:d640 with SMTP id\n\t5b1f17b1804b1-482db4b53f0mr34148595e9.36.1769781707635; \n\tFri, 30 Jan 2026 06:01:47 -0800 (PST)"],"From":"Milan Zamazal <mzamazal@redhat.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","In-Reply-To":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Fri,\n\t30 Jan 2026  12:32:37 +0100\")","References":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 15:01:46 +0100","Message-ID":"<85h5s3td11.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"--kGMX7fz0MgC-mo30-P-fqNdtQBgp2vOptkQ6YjiH0_1769781708","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38035,"web_url":"https://patchwork.libcamera.org/comment/38035/","msgid":"<40b7c0ba-c96b-4263-877c-bf59a0f7e122@ideasonboard.com>","date":"2026-01-30T14:05:12","subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 30. 15:01 keltezéssel, Milan Zamazal írta:\n> Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes:\n> \n>> Previously it was not possible to disable libtiff usage if it was\n>> detected. Fix that by adding a meson feature option.\n>>\n>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>> ---\n>>   meson_options.txt    | 5 +++++\n>>   src/apps/meson.build | 2 +-\n>>   2 files changed, 6 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/meson_options.txt b/meson_options.txt\n>> index 58cf52ad1..8ad0de118 100644\n>> --- a/meson_options.txt\n>> +++ b/meson_options.txt\n>> @@ -62,6 +62,11 @@ option('libdw',\n>>           value : 'auto',\n>>           description : 'Enable libdw integration for backtrace symbolization')\n>>   \n>> +option('libtiff',\n>> +        type : 'feature',\n>> +        value : 'auto',\n>> +        description : 'Enable libtiff integration the cam and qcam applications for creating DNG files')\n> \n> \"... *in* the cam and qcam ...\"?\n\nYes... I have only noticed after sending it, but it is fixed now.\n\n\n> \n>> +\n>>   option('libunwind',\n>>           type : 'feature',\n>>           value : 'auto',\n>> diff --git a/src/apps/meson.build b/src/apps/meson.build\n>> index af632b9a7..63ef6f173 100644\n>> --- a/src/apps/meson.build\n>> +++ b/src/apps/meson.build\n>> @@ -10,7 +10,7 @@ if not libevent.found()\n>>       libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n>>   endif\n>>   \n>> -libtiff = dependency('libtiff-4', required : false)\n>> +libtiff = dependency('libtiff-4', required : get_option('libtiff'))\n>>   \n>>   subdir('common')\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6084ABD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Jan 2026 14:05:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18B8861FD8;\n\tFri, 30 Jan 2026 15:05:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1219F61F84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Jan 2026 15:05:16 +0100 (CET)","from [192.168.33.42] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2ACA55C;\n\tFri, 30 Jan 2026 15:04:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dTNqAgZ6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781877;\n\tbh=wMRHK7IPke3dL6+hRqQZbylGCkxXraJ9ogDBqahvmmo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=dTNqAgZ6UhaPwHZfdVFRK6Cimm5pU8EYWShX1YieyJ76TIutvOmhl8VFjXtBe8qVl\n\tE+VwXL2jFRyL0UQQSEGN2Er98n+FyK1d+cUfSrtOsIYNiblDIJrvivXsVUdhbaURIU\n\tnjBZbK3xGfc545ggU0BLW5l+7HDnp+kckM1CUCv8=","Message-ID":"<40b7c0ba-c96b-4263-877c-bf59a0f7e122@ideasonboard.com>","Date":"Fri, 30 Jan 2026 15:05:12 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com>\n\t<85h5s3td11.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<85h5s3td11.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38108,"web_url":"https://patchwork.libcamera.org/comment/38108/","msgid":"<20260206004010.GG1376807@killaraus.ideasonboard.com>","date":"2026-02-06T00:40:10","subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Fri, Jan 30, 2026 at 12:32:37PM +0100, Barnabás Pőcze wrote:\n> Previously it was not possible to disable libtiff usage if it was\n> detected. Fix that by adding a meson feature option.\n> \n> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> ---\n>  meson_options.txt    | 5 +++++\n>  src/apps/meson.build | 2 +-\n>  2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 58cf52ad1..8ad0de118 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -62,6 +62,11 @@ option('libdw',\n>          value : 'auto',\n>          description : 'Enable libdw integration for backtrace symbolization')\n>  \n> +option('libtiff',\n> +        type : 'feature',\n> +        value : 'auto',\n> +        description : 'Enable libtiff integration the cam and qcam applications for creating DNG files')\n> +\n\nCould we name this option dng or something similar ? It seems clearer\nfor the user to name options after the features they enable instead of\nthe dependency they use, when possible.\n\n>  option('libunwind',\n>          type : 'feature',\n>          value : 'auto',\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index af632b9a7..63ef6f173 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -10,7 +10,7 @@ if not libevent.found()\n>      libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n>  endif\n>  \n> -libtiff = dependency('libtiff-4', required : false)\n> +libtiff = dependency('libtiff-4', required : get_option('libtiff'))\n>  \n>  subdir('common')\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC18CBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  6 Feb 2026 00:40:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A57F062074;\n\tFri,  6 Feb 2026 01:40:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E63961FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Feb 2026 01:40:12 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C19E52E0;\n\tFri,  6 Feb 2026 01:39:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"abkSmo9P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770338368;\n\tbh=ajsCnRNBVhtNwwpnmsGv8Q7Bfq9HnYUEdpAcmewfM4g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=abkSmo9PYdgKYENZ8Ejhm/YMJj/tPWJaCZ0OBN/3DdjMxz61WEW7NMk98ILr0fPf9\n\t349dKbaiLtx5BOZHOR6ubNTKFWKt+D2daYOXaTWj9nSqeteQS4+EDkCdAmF7KPcFE0\n\tNNj6EzRxDqYGC8vtOXtL7VWUCw3ziR7Sgtqr8SX4=","Date":"Fri, 6 Feb 2026 02:40:10 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","Message-ID":"<20260206004010.GG1376807@killaraus.ideasonboard.com>","References":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38113,"web_url":"https://patchwork.libcamera.org/comment/38113/","msgid":"<c1f962e5-a738-4f42-8210-edfefca868ff@ideasonboard.com>","date":"2026-02-06T07:59:46","subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 02. 06. 1:40 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Fri, Jan 30, 2026 at 12:32:37PM +0100, Barnabás Pőcze wrote:\n>> Previously it was not possible to disable libtiff usage if it was\n>> detected. Fix that by adding a meson feature option.\n>>\n>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>> ---\n>>   meson_options.txt    | 5 +++++\n>>   src/apps/meson.build | 2 +-\n>>   2 files changed, 6 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/meson_options.txt b/meson_options.txt\n>> index 58cf52ad1..8ad0de118 100644\n>> --- a/meson_options.txt\n>> +++ b/meson_options.txt\n>> @@ -62,6 +62,11 @@ option('libdw',\n>>           value : 'auto',\n>>           description : 'Enable libdw integration for backtrace symbolization')\n>>   \n>> +option('libtiff',\n>> +        type : 'feature',\n>> +        value : 'auto',\n>> +        description : 'Enable libtiff integration the cam and qcam applications for creating DNG files')\n>> +\n> \n> Could we name this option dng or something similar ? It seems clearer\n> for the user to name options after the features they enable instead of\n> the dependency they use, when possible.\n\nInitially I wanted to call it `{q,}cam-output-dng` or similar but the way\nthe build is set up makes it a bit more inconvenient. If we go with an option\nthat covers both, do you think \"app-output-dng\" would be an acceptable name?\n\n\n> \n>>   option('libunwind',\n>>           type : 'feature',\n>>           value : 'auto',\n>> diff --git a/src/apps/meson.build b/src/apps/meson.build\n>> index af632b9a7..63ef6f173 100644\n>> --- a/src/apps/meson.build\n>> +++ b/src/apps/meson.build\n>> @@ -10,7 +10,7 @@ if not libevent.found()\n>>       libevent = dependency('libevent_pthreads', required : opt_lc_compliance)\n>>   endif\n>>   \n>> -libtiff = dependency('libtiff-4', required : false)\n>> +libtiff = dependency('libtiff-4', required : get_option('libtiff'))\n>>   \n>>   subdir('common')\n>>   \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A50ACC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  6 Feb 2026 07:59:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84DBE62078;\n\tFri,  6 Feb 2026 08:59:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6765B61FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Feb 2026 08:59:50 +0100 (CET)","from [192.168.33.58] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C83072E0;\n\tFri,  6 Feb 2026 08:59:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eE/2Vc9A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770364746;\n\tbh=iUjh3+MxFEmBAvWRyNH4eu94lNQ1ztYUUijxzN8vL9U=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=eE/2Vc9AeTHzMDxtAspemAKPF54YX+WXrmNLfibfdTVanuuy1lBTVYAxb03UAh7Mo\n\tDXLSEX9VMeQ0q2+Kncx3INXA4RjLIhjdbbvWg2HKPCO72mMfD0jZkg2cbvzJ2Os60r\n\tEw3ZKKn+K2XKCgn5+qlf4QWL+1K1eBCfehtR6zok=","Message-ID":"<c1f962e5-a738-4f42-8210-edfefca868ff@ideasonboard.com>","Date":"Fri, 6 Feb 2026 08:59:46 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] meson: Add `libtiff` option to control libtiff\n\tdependency","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260130113237.1595411-1-barnabas.pocze@ideasonboard.com>\n\t<20260206004010.GG1376807@killaraus.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260206004010.GG1376807@killaraus.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]