[{"id":38107,"web_url":"https://patchwork.libcamera.org/comment/38107/","msgid":"<20260206003603.GF1376807@killaraus.ideasonboard.com>","date":"2026-02-06T00:36:03","subject":"Re: [PATCH v1] meson: Add `libdw` option to control libdw dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 30, 2026 at 10:08:19AM +0100, Barnabás Pőcze wrote:\n> Previously it was not possible to disable libdw usage if it was\n> detected. Fix that by adding a meson feature option.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson_options.txt | 5 +++++\n> src/libcamera/base/meson.build | 2 +-\n> 2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index d600cd1be..8121cf5d2 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -42,6 +42,11 @@ option('lc-compliance',\n> value : 'auto',\n> description : 'Compile the lc-compliance test application')\n> \n> +option('libdw',\n> + type : 'feature',\n> + value : 'auto',\n> + description : 'Enable libdw integration for backtrace symbolization')\n> +\n> option('libunwind',\n> type : 'feature',\n> value : 'auto',\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index bcf37f71c..b57774f49 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -26,7 +26,7 @@ libcamera_base_internal_sources = files([\n> 'utils.cpp',\n> ])\n> \n> -libdw = dependency('libdw', required : false)\n> +libdw = dependency('libdw', required : get_option('libdw'))\n> libunwind = dependency('libunwind', required : get_option('libunwind'))\n> \n> if cc.has_header_symbol('execinfo.h', 'backtrace')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC071BD78E\n\tfor ;\n\tFri, 6 Feb 2026 00:36:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 680E562074;\n\tFri, 6 Feb 2026 01:36:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7C0A61FBF\n\tfor ;\n\tFri, 6 Feb 2026 01:36:04 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 454152E0;\n\tFri, 6 Feb 2026 01:35:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hJQvZ433\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770338121;\n\tbh=Ac14gREpyxYIeuf/cemGvfADpyl3xqaFPY9+OuiLFlE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hJQvZ433Zts8ur9f9mCwxeSAyz4v8DcNDx6KgqiGBgG/1pxrtRbadilXt+YIIqIV4\n\t/CmC3mUaqYyxxeaQKG3TyCL8wzkzDRRNg0ujzG4lsT2gKcA0b/3wgsTOELw1pY2v7N\n\tkliTQZev9sV2jUneF4E/hbHG82dOJJYyYhB//xe0=","Date":"Fri, 6 Feb 2026 02:36:03 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] meson: Add `libdw` option to control libdw dependency","Message-ID":"<20260206003603.GF1376807@killaraus.ideasonboard.com>","References":"<20260130090819.1511202-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260130090819.1511202-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38111,"web_url":"https://patchwork.libcamera.org/comment/38111/","msgid":"<177033995093.1808100.14372707844247271520@ping.linuxembedded.co.uk>","date":"2026-02-06T01:05:50","subject":"Re: [PATCH v1] meson: Add `libdw` option to control libdw dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-02-06 00:36:03)\n> On Fri, Jan 30, 2026 at 10:08:19AM +0100, Barnabás Pőcze wrote:\n> > Previously it was not possible to disable libdw usage if it was\n> > detected. Fix that by adding a meson feature option.\n> > \n> > Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > meson_options.txt | 5 +++++\n> > src/libcamera/base/meson.build | 2 +-\n> > 2 files changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index d600cd1be..8121cf5d2 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -42,6 +42,11 @@ option('lc-compliance',\n> > value : 'auto',\n> > description : 'Compile the lc-compliance test application')\n> > \n> > +option('libdw',\n> > + type : 'feature',\n> > + value : 'auto',\n> > + description : 'Enable libdw integration for backtrace symbolization')\n> > +\n> > option('libunwind',\n> > type : 'feature',\n> > value : 'auto',\n> > diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> > index bcf37f71c..b57774f49 100644\n> > --- a/src/libcamera/base/meson.build\n> > +++ b/src/libcamera/base/meson.build\n> > @@ -26,7 +26,7 @@ libcamera_base_internal_sources = files([\n> > 'utils.cpp',\n> > ])\n> > \n> > -libdw = dependency('libdw', required : false)\n> > +libdw = dependency('libdw', required : get_option('libdw'))\n\nThat likely pushes me further to thinking the libjpeg variants should be\nsimply that as an option...\n\nReviewed-by: Kieran Bingham \n\n> > libunwind = dependency('libunwind', required : get_option('libunwind'))\n> > \n> > if cc.has_header_symbol('execinfo.h', 'backtrace')\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15FA7C31E9\n\tfor ;\n\tFri, 6 Feb 2026 01:05:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 993116207A;\n\tFri, 6 Feb 2026 02:05:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57A7F61FBF\n\tfor ;\n\tFri, 6 Feb 2026 02:05:53 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36275460;\n\tFri, 6 Feb 2026 02:05:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wDrTlHVF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770339910;\n\tbh=DtnuYBg5+L7gWiX1lHcXur562BajL45zlnMSjbTxwPY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wDrTlHVFVFamU51hVny+ArFRWCus9kOeBQdyur8LRDCHkDD9x57kVLwOee7YhmL6H\n\t06KJ51LWW+L/+5JE7eE0cZlLVY+8VkkFIPOjP14G8xUZldmfSC11qct6AePRc9NDtN\n\tBlz8LzeDvt+6qcxA6KCChxI8BGZpiy3MfUJLhlYI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260206003603.GF1376807@killaraus.ideasonboard.com>","References":"<20260130090819.1511202-1-barnabas.pocze@ideasonboard.com>\n\t<20260206003603.GF1376807@killaraus.ideasonboard.com>","Subject":"Re: [PATCH v1] meson: Add `libdw` option to control libdw dependency","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Date":"Fri, 06 Feb 2026 01:05:50 +0000","Message-ID":"<177033995093.1808100.14372707844247271520@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]