[{"id":38024,"web_url":"https://patchwork.libcamera.org/comment/38024/","msgid":"<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:41:07","subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> Previously it was not possible to disable egl debayering if every\n> dependency was discovered by meson. Fix that by adding a new option.\n\nNot sure it is needed (testing purposes?) but if it is:\n\nReviewed-by: Milan Zamazal \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> meson_options.txt | 5 +++++\n> src/libcamera/software_isp/meson.build | 8 +++++---\n> 2 files changed, 10 insertions(+), 3 deletions(-)\n>\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 078472940..d600cd1be 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -81,6 +81,11 @@ option('rpi-awb-nn',\n> value : 'auto',\n> description : 'Enable the Raspberry Pi Neural Network AWB algorithm')\n> \n> +option('softisp-debayer-egl',\n> + type : 'feature',\n> + value : 'auto',\n> + description : 'Enable OpenGL ES based debayering in the software ISP')\n> +\n> option('test',\n> type : 'boolean',\n> value : false,\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index cbcd3c1b3..754a0d2d9 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -7,9 +7,11 @@ if not softisp_enabled\n> subdir_done()\n> endif\n> \n> -libegl = dependency('egl', required : false)\n> -libglesv2 = dependency('glesv2', required : false)\n> -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> +libegl = dependency('egl', required : get_option('softisp-debayer-egl'))\n> +libglesv2 = dependency('glesv2', required : get_option('softisp-debayer-egl'))\n> +mesa_works = cc.check_header('EGL/egl.h',\n> + required : get_option('softisp-debayer-egl'),\n> + dependencies : libegl)\n> \n> summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 979D5C3226\n\tfor ;\n\tFri, 30 Jan 2026 13:41:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F33E061FD2;\n\tFri, 30 Jan 2026 14:41:15 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A465261F84\n\tfor ;\n\tFri, 30 Jan 2026 14:41:13 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-519-RUx_mysePQyyygbTlEd1bA-1; Fri, 30 Jan 2026 08:41:11 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-48057c39931so25067655e9.0\n\tfor ;\n\tFri, 30 Jan 2026 05:41:10 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-480705956f1sm167768845e9.11.2026.01.30.05.41.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:41:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Qwomk8lJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769780472;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Ms2eYtxbwvjLM+/6IM5XO90Zad22lyS4HUYzIhwVDJ0=;\n\tb=Qwomk8lJZ4w+5U2e0JG4XuksLwxsTcDaLbhFcZVLYPCCjpQFMPd8H1y8w2Yw11t9LEVL+e\n\tg2WUEh5NbEA5LAqjgsfvL4Q+v0nCYg8ifvJmkB+by0OGoO6rH6JsEzKZpeT7Zfz2E6sNRc\n\tts00zp45LT3NWvLIL6KwIavYlJWLI7k=","X-MC-Unique":"RUx_mysePQyyygbTlEd1bA-1","X-Mimecast-MFC-AGG-ID":"RUx_mysePQyyygbTlEd1bA_1769780470","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769780469; x=1770385269;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=5AEpMlqj51ToLk9ijQoh5YyV/oARyyA2Ml326IAFswg=;\n\tb=Q2P93EF73eJA8hjCVPAgWEM0CuvDmeVU9o3U/RG3FlVk2bBfzj5+/RLRnNAoJ9IrO8\n\tTUzDZH9j1RG+gHPWdC3LXiddIFY1BwpGDdiFgmebxULg1CIMAxIuOHBdAa/vFHFXzEZS\n\tZpmD+GBsZFz/9i6pvN0/afhxwLTEyHxAar/A17lH+AoFgfJQrA7QG53pKVt65fNd1EsZ\n\t024cMqwuvKa9hqS90zgORIXvIi+5h45wazajhqJ3kLCIgGXOHWlEp1cOIlSO7Bbgvevk\n\tVRZ7uJ7jb2IJWGoCXMgPeprcsbtLpwsWUUkp/hAm7xTNvIcU7IwNM/KvHSrIwqW2MALb\n\tZ28A==","X-Gm-Message-State":"AOJu0Yw/hfAOHSUtl9Wp4CPNzvE3sgLNfd6c9YyDY2dXK640tewqVvXX\n\ttYTa6FjQS3/ig6EgBjWiLcT7QN6g0Ibc37uD0Wsqaf9qyp2Zl1sJTCPp1R9lpjdsgxIJ4Jqq5kr\n\tbwxGJ2LKWe++mgoGJi43UoNJYfEu9vJREstSt0+U3RHhPHI01btgdkplVbyyfsifZSZ/0f0mAgH\n\tda71rFMcceqIBzMQFwwaynzdkV2vnqoymzPbb32Ks0Gd7G/xxAWqmnRFX5OcY=","X-Gm-Gg":"AZuq6aJt/5L/MM6scFGce6pIiouK1hwXhXRVcjUE0dwC2Pl9FJTigDuGWX3eoiR+B1Z\n\tGw5+sa3TELGRJk02NLCxC6Eqmlom1HjP41icz4xhkVC9lrFT7FPDw9yA7tdzFm/SDY7XsM4IDQ7\n\tSO3zLh89i/aj7Hmo54Zmuf1Xkz/WBJZJ5h6acEjmAsd9I5W1P9Y/z+V7EpJkU6IruIPvEaAkvMx\n\tMd15PqaEp/T9T6cFuJ+H4vMPOa/oEJPlP0ilwEgqULUes6y/bnAWJTZnTyhI9mxEKi4R9cAC2U1\n\tzKl8k/znRu0kFLXxU8Psmnye7wSdsZDK+fNjyF1hy/V0fBXF/LVypbysDau1IRSOaOgph6J3kJN\n\tiGAe7UhJ6uEfes+bXKI6MVIwSDQlZPJVjhgBihHXhOmhNQHJ9zhRqpEkbV1Ym5tU=","X-Received":["by 2002:a05:600c:64c6:b0:477:5ad9:6df1 with SMTP id\n\t5b1f17b1804b1-482db4593a1mr35689715e9.3.1769780469393; \n\tFri, 30 Jan 2026 05:41:09 -0800 (PST)","by 2002:a05:600c:64c6:b0:477:5ad9:6df1 with SMTP id\n\t5b1f17b1804b1-482db4593a1mr35689385e9.3.1769780469006; \n\tFri, 30 Jan 2026 05:41:09 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","In-Reply-To":"<20260129164032.1380169-7-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:32 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-7-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:41:07 +0100","Message-ID":"<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"JB7LW-1tW8TaT0tYzcCN_lxKWJq3axosRGMNCIA_VxQ_1769780470","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38026,"web_url":"https://patchwork.libcamera.org/comment/38026/","msgid":"<20260130135642.GK3374091@killaraus>","date":"2026-01-30T13:56:42","subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 30, 2026 at 02:41:07PM +0100, Milan Zamazal wrote:\n> Barnabás Pőcze writes:\n> \n> > Previously it was not possible to disable egl debayering if every\n> > dependency was discovered by meson. Fix that by adding a new option.\n> \n> Not sure it is needed (testing purposes?) but if it is:\n\nThis is required for reproducible builds, otherwise a distribution\nthat wants to package libcamera without GPU acceleration could end up\nstill linking to the GL libraries if they happen to be installed on the\nsystem that builds the package.\n\nThis being said, I think we may in the future just unconditionally\nenable GPU acceleration. It's a bit too early for that though.\n\n> Reviewed-by: Milan Zamazal \n> \n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > meson_options.txt | 5 +++++\n> > src/libcamera/software_isp/meson.build | 8 +++++---\n> > 2 files changed, 10 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index 078472940..d600cd1be 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -81,6 +81,11 @@ option('rpi-awb-nn',\n> > value : 'auto',\n> > description : 'Enable the Raspberry Pi Neural Network AWB algorithm')\n> > \n> > +option('softisp-debayer-egl',\n> > + type : 'feature',\n> > + value : 'auto',\n> > + description : 'Enable OpenGL ES based debayering in the software ISP')\n\nIt will soon be able more than debayering, so let's name this option\nsoftisp-egl, or possibly better, softisp-gles. With that,\n\nReviewed-by: Laurent Pinchart \n\n> > +\n> > option('test',\n> > type : 'boolean',\n> > value : false,\n> > diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> > index cbcd3c1b3..754a0d2d9 100644\n> > --- a/src/libcamera/software_isp/meson.build\n> > +++ b/src/libcamera/software_isp/meson.build\n> > @@ -7,9 +7,11 @@ if not softisp_enabled\n> > subdir_done()\n> > endif\n> > \n> > -libegl = dependency('egl', required : false)\n> > -libglesv2 = dependency('glesv2', required : false)\n> > -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> > +libegl = dependency('egl', required : get_option('softisp-debayer-egl'))\n> > +libglesv2 = dependency('glesv2', required : get_option('softisp-debayer-egl'))\n> > +mesa_works = cc.check_header('EGL/egl.h',\n> > + required : get_option('softisp-debayer-egl'),\n> > + dependencies : libegl)\n> > \n> > summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A052BD78E\n\tfor ;\n\tFri, 30 Jan 2026 13:56:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF3DC61FD2;\n\tFri, 30 Jan 2026 14:56:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AE5A61F84\n\tfor ;\n\tFri, 30 Jan 2026 14:56:44 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 65D177FA;\n\tFri, 30 Jan 2026 14:56:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oEq7Bu4A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781365;\n\tbh=UeD1vkbf/iqJhLQ8JZDS7b90fAsUkXmNBP27hjBH94A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oEq7Bu4AARONyJZsS+ZlJpCKM5Xiw/Z0wT+j1bgS6xfeZ986XtS70KFfq5WS34nK8\n\tdwHUrdF3+T8mSbqP87Y5XijSFJ3jGAB0e5Mj8sutLt7ZlAeXq2GdZ6QptoFhU7sMy/\n\tPQVcqrMA+lB3KfksbdBNoNWhIzOv402IMCCmf8pM=","Date":"Fri, 30 Jan 2026 15:56:42 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","Message-ID":"<20260130135642.GK3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-7-barnabas.pocze@ideasonboard.com>\n\t<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38036,"web_url":"https://patchwork.libcamera.org/comment/38036/","msgid":"<3a28c694-1e8d-459c-bb30-bcfcf60ae7e9@ideasonboard.com>","date":"2026-01-30T14:09:58","subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 30. 14:56 keltezéssel, Laurent Pinchart írta:\n> On Fri, Jan 30, 2026 at 02:41:07PM +0100, Milan Zamazal wrote:\n>> Barnabás Pőcze writes:\n>>\n>>> Previously it was not possible to disable egl debayering if every\n>>> dependency was discovered by meson. Fix that by adding a new option.\n>>\n>> Not sure it is needed (testing purposes?) but if it is:\n> \n> This is required for reproducible builds, otherwise a distribution\n> that wants to package libcamera without GPU acceleration could end up\n> still linking to the GL libraries if they happen to be installed on the\n> system that builds the package.\n> \n> This being said, I think we may in the future just unconditionally\n> enable GPU acceleration. It's a bit too early for that though.\n> \n>> Reviewed-by: Milan Zamazal \n>>\n>>> Signed-off-by: Barnabás Pőcze \n>>> ---\n>>> meson_options.txt | 5 +++++\n>>> src/libcamera/software_isp/meson.build | 8 +++++---\n>>> 2 files changed, 10 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/meson_options.txt b/meson_options.txt\n>>> index 078472940..d600cd1be 100644\n>>> --- a/meson_options.txt\n>>> +++ b/meson_options.txt\n>>> @@ -81,6 +81,11 @@ option('rpi-awb-nn',\n>>> value : 'auto',\n>>> description : 'Enable the Raspberry Pi Neural Network AWB algorithm')\n>>> \n>>> +option('softisp-debayer-egl',\n>>> + type : 'feature',\n>>> + value : 'auto',\n>>> + description : 'Enable OpenGL ES based debayering in the software ISP')\n> \n> It will soon be able more than debayering, so let's name this option\n> softisp-egl, or possibly better, softisp-gles. With that,\n> \n> Reviewed-by: Laurent Pinchart \n\nWhat about just `softisp-gpu` then?\n\n \"Enable GPU accelerated processing in the software ISP\"\n\nYes, llvmpipe and similar exist, but this feature has been called \"GPUISP\"\nin multiple places already.\n\n> \n>>> +\n>>> option('test',\n>>> type : 'boolean',\n>>> value : false,\n>>> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n>>> index cbcd3c1b3..754a0d2d9 100644\n>>> --- a/src/libcamera/software_isp/meson.build\n>>> +++ b/src/libcamera/software_isp/meson.build\n>>> @@ -7,9 +7,11 @@ if not softisp_enabled\n>>> subdir_done()\n>>> endif\n>>> \n>>> -libegl = dependency('egl', required : false)\n>>> -libglesv2 = dependency('glesv2', required : false)\n>>> -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n>>> +libegl = dependency('egl', required : get_option('softisp-debayer-egl'))\n>>> +libglesv2 = dependency('glesv2', required : get_option('softisp-debayer-egl'))\n>>> +mesa_works = cc.check_header('EGL/egl.h',\n>>> + required : get_option('softisp-debayer-egl'),\n>>> + dependencies : libegl)\n>>> \n>>> summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 089D6C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:10:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28CEA61FD3;\n\tFri, 30 Jan 2026 15:10:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25FA661F84\n\tfor ;\n\tFri, 30 Jan 2026 15:10:02 +0100 (CET)","from [192.168.33.42] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F2E955C;\n\tFri, 30 Jan 2026 15:09:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lI02MeXM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769782163;\n\tbh=fa9w3BAOhI6nkMKs2sU2zYj/uhYuecbWcBlCI3S9Rt4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=lI02MeXMkyptfrJc2nH8cY+13F4Sfsf1C8vtMz4jPSQYH0WqyHVjvzLqYu2+Vc4bw\n\tTyyly3Tstjp+5B4dV/VmNNZrjTWRZ5rlCrSyfpDawLryi37NcroTy9IrZVvXKRJY41\n\tzZIJi34/6EJLX8gAgQwLPAWFAq7O4CF59KUGPcTQ=","Message-ID":"<3a28c694-1e8d-459c-bb30-bcfcf60ae7e9@ideasonboard.com>","Date":"Fri, 30 Jan 2026 15:09:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-7-barnabas.pocze@ideasonboard.com>\n\t<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<20260130135642.GK3374091@killaraus>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260130135642.GK3374091@killaraus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38037,"web_url":"https://patchwork.libcamera.org/comment/38037/","msgid":"<20260130141132.GR3374091@killaraus>","date":"2026-01-30T14:11:32","subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 30, 2026 at 03:09:58PM +0100, Barnabás Pőcze wrote:\n> 2026. 01. 30. 14:56 keltezéssel, Laurent Pinchart írta:\n> > On Fri, Jan 30, 2026 at 02:41:07PM +0100, Milan Zamazal wrote:\n> >> Barnabás Pőcze writes:\n> >>\n> >>> Previously it was not possible to disable egl debayering if every\n> >>> dependency was discovered by meson. Fix that by adding a new option.\n> >>\n> >> Not sure it is needed (testing purposes?) but if it is:\n> > \n> > This is required for reproducible builds, otherwise a distribution\n> > that wants to package libcamera without GPU acceleration could end up\n> > still linking to the GL libraries if they happen to be installed on the\n> > system that builds the package.\n> > \n> > This being said, I think we may in the future just unconditionally\n> > enable GPU acceleration. It's a bit too early for that though.\n> > \n> >> Reviewed-by: Milan Zamazal \n> >>\n> >>> Signed-off-by: Barnabás Pőcze \n> >>> ---\n> >>> meson_options.txt | 5 +++++\n> >>> src/libcamera/software_isp/meson.build | 8 +++++---\n> >>> 2 files changed, 10 insertions(+), 3 deletions(-)\n> >>>\n> >>> diff --git a/meson_options.txt b/meson_options.txt\n> >>> index 078472940..d600cd1be 100644\n> >>> --- a/meson_options.txt\n> >>> +++ b/meson_options.txt\n> >>> @@ -81,6 +81,11 @@ option('rpi-awb-nn',\n> >>> value : 'auto',\n> >>> description : 'Enable the Raspberry Pi Neural Network AWB algorithm')\n> >>> \n> >>> +option('softisp-debayer-egl',\n> >>> + type : 'feature',\n> >>> + value : 'auto',\n> >>> + description : 'Enable OpenGL ES based debayering in the software ISP')\n> > \n> > It will soon be able more than debayering, so let's name this option\n> > softisp-egl, or possibly better, softisp-gles. With that,\n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> What about just `softisp-gpu` then?\n> \n> \"Enable GPU accelerated processing in the software ISP\"\n> \n> Yes, llvmpipe and similar exist, but this feature has been called \"GPUISP\"\n> in multiple places already.\n\nWorks for me.\n\n> >>> +\n> >>> option('test',\n> >>> type : 'boolean',\n> >>> value : false,\n> >>> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> >>> index cbcd3c1b3..754a0d2d9 100644\n> >>> --- a/src/libcamera/software_isp/meson.build\n> >>> +++ b/src/libcamera/software_isp/meson.build\n> >>> @@ -7,9 +7,11 @@ if not softisp_enabled\n> >>> subdir_done()\n> >>> endif\n> >>> \n> >>> -libegl = dependency('egl', required : false)\n> >>> -libglesv2 = dependency('glesv2', required : false)\n> >>> -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> >>> +libegl = dependency('egl', required : get_option('softisp-debayer-egl'))\n> >>> +libglesv2 = dependency('glesv2', required : get_option('softisp-debayer-egl'))\n> >>> +mesa_works = cc.check_header('EGL/egl.h',\n> >>> + required : get_option('softisp-debayer-egl'),\n> >>> + dependencies : libegl)\n> >>> \n> >>> summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B33E3C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:11:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6051D61FD3;\n\tFri, 30 Jan 2026 15:11:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF30361F84\n\tfor ;\n\tFri, 30 Jan 2026 15:11:33 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6ABAC55C;\n\tFri, 30 Jan 2026 15:10:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DYSG+JtI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769782255;\n\tbh=+N0AFPg6kl/D7E9UkK8Cw911AMT7vlmuvRCOiHnjddM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DYSG+JtI+zkKSAzmq4hPgia+O1gGvlbIi4lo9GPsnhYXJKk+c/kRQIpjrNhDwwIqm\n\tIb/wztQO1b28ntj8BjXjztLMRLIMJ+DrRaACp+ro7l2Vd38wdIABk/G9Zgfgu8BrMW\n\tZ5TPq+ml7SUUYIU2Vl0zl5vqd7gu8KyQ78XC578s=","Date":"Fri, 30 Jan 2026 16:11:32 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 7/7] meson: Guard egl debayering with feature option:\n\tsoftisp-debayer-egl","Message-ID":"<20260130141132.GR3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-7-barnabas.pocze@ideasonboard.com>\n\t<85sebntdzg.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<20260130135642.GK3374091@killaraus>\n\t<3a28c694-1e8d-459c-bb30-bcfcf60ae7e9@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3a28c694-1e8d-459c-bb30-bcfcf60ae7e9@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]