[{"id":38023,"web_url":"https://patchwork.libcamera.org/comment/38023/","msgid":"<85wm0zteiw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:29:27","subject":"Re: [PATCH v1 6/7] meson: Move egl related dependencies to\n\t`software_isp` subdir","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> This way the dependencies are only added if they are actually used.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/meson.build | 6 ------\n> src/libcamera/software_isp/meson.build | 11 ++++++++++-\n> 2 files changed, 10 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 72b7bf02d..575408b2c 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -70,10 +70,6 @@ libcamera_deps = []\n> libatomic = cc.find_library('atomic', required : false)\n> libthreads = dependency('threads')\n> \n> -libegl = dependency('egl', required : false)\n> -libglesv2 = dependency('glesv2', required : false)\n> -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> -\n> subdir('base')\n> subdir('converter')\n> subdir('ipa')\n> @@ -182,8 +178,6 @@ libcamera_deps += [\n> libcamera_base_private,\n> libcrypto,\n> libdl,\n> - libegl,\n> - libglesv2,\n> liblttng,\n> libudev,\n> libyaml,\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 118d3f92f..cbcd3c1b3 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -2,12 +2,17 @@\n> \n> softisp_enabled = pipelines.contains('simple')\n> summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> endif\n> \n> +libegl = dependency('egl', required : false)\n> +libglesv2 = dependency('glesv2', required : false)\n> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> +\n> +summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> +\n> libcamera_internal_sources += files([\n> 'benchmark.cpp',\n> 'debayer.cpp',\n> @@ -22,4 +27,8 @@ if mesa_works\n> '../egl.cpp',\n> 'debayer_egl.cpp',\n> ])\n> + libcamera_deps += [\n> + libegl,\n> + libglesv2,\n> + ]\n> endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CA67BD78E\n\tfor ;\n\tFri, 30 Jan 2026 13:29:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93AF361FCC;\n\tFri, 30 Jan 2026 14:29:35 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D26CE61F84\n\tfor ;\n\tFri, 30 Jan 2026 14:29:33 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-614-DL2N3aEFOK-VgUEAoiSXdQ-1; Fri, 30 Jan 2026 08:29:31 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-4804157a3c9so27128645e9.1\n\tfor ;\n\tFri, 30 Jan 2026 05:29:31 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48066be77b5sm251069375e9.2.2026.01.30.05.29.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:29:28 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"aLkaf0uQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769779772;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Y6UaYCNtv2Hnb+JQF9HqrjjXdm8bL+LG1IfokTtN/JI=;\n\tb=aLkaf0uQeXv9Fq+TDq9wAh559tfTjjNAvSdB6cOyNXC5cMB4Q8MxxQy3jC0bM8X6OhnB2k\n\tsO7BKGvuklWadYFdIuXh70vbmzbi4TJFAZzbmK5BiLwyDoMeV9U5pQyIck7fmx/Sd5+xfD\n\t3AEVuU/qij/Kb3d02Hr9/voQE6O8Weg=","X-MC-Unique":"DL2N3aEFOK-VgUEAoiSXdQ-1","X-Mimecast-MFC-AGG-ID":"DL2N3aEFOK-VgUEAoiSXdQ_1769779770","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769779770; x=1770384570;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=w9KRu81SNuX0gqsmiAehLgebL2winB1METbv1vUkaTk=;\n\tb=WSD6DwHouQrMiFrQUtHIAwXxScdnM8uHQ8CsMfa3bsUy6bngDdlxESlwPcfENRaFSI\n\tCXD9KZA1qpjMHqPBu2pFUpJRed4XSTrwSbK9aHKOYWBZfUF5EI6DHgzqVqEK5tih1EA4\n\tZBphYKu63L7umwKyYtD+X70nU/cJdZNpgugGBIkDVird2hzhwad9j2/NaJGbB1XTfib5\n\tcNfRO1ApkVhxSfMh6vrQnGE02LtGU76x81s8SapzHtHYwR09ouaMdF0evroiLDi7kvKD\n\tbauMhpfp8qecDZbuc8VYA8WE9afNPGxOjDeaDLMFhpI0ZcNirgFhtI3brlDMvcTjyztQ\n\t5XVQ==","X-Gm-Message-State":"AOJu0YxTY5YIGL4Xnk0deR6e4eTPxwl/48ZVVCqcdN2zdqtYWK5TortM\n\tLnuPqT3fBkldCsqGOk6UGlFY3Cr/fdm0wU+PxQsAXJadi+K+EdeqwFvSbsS2oYridoDPvZAnQ6f\n\tRlVQdx/sPjPkwD+ESIGEhEXRm7XTi45Oe0CbIdeUE+qOvDrrXCEBZD6ODmqdzNAT+ULH1WPeBdy\n\t79IEMVzX/EIZ4w2/3lQcyPKdEbdVj7IKhCfD4lnqbfA8Pb0tElXRN87QE5iSg=","X-Gm-Gg":"AZuq6aItSOmK6M+LbAzNPPgwfBpDctrzptEyupHgFjyFH6u/dDWFYiOrjtlhLbqBp+B\n\t+xKhhGA4IXH/m8hJRSx2izu8UjCppUVW98aOmEIVv9P8pKJkCVYR6YcztjaTEeMV6S9pYO7H9lW\n\tiuKLDTunae1f+to/QAq/+ckGFyEZ5G3dQ556AXjjq1HRsbohy8LtLCcM/hiHs43JV7AMLIddJf9\n\tzbuthOozSCW1+fdxmmd4Ps3OZZFFjsqEBxEdnh1DW0MHt0FTS7K7P5yISz75PhwqsyPZ7LCSxcZ\n\tc1P88zksuwT/wktpJvpAomo1sU4YBqiTQLgOidUx6+ljnfVCV6dq+mAwzzS0gjNSsKcR4na64OW\n\tlDv2ouFJj7Yc6ZXbGIFzVjIcLI6BWCGyJa2ThjepHG2kwrprZ32qepL35Dwmf2Dc=","X-Received":["by 2002:a05:600c:34c7:b0:47e:e48b:506d with SMTP id\n\t5b1f17b1804b1-482db47413emr39140605e9.16.1769779769624; \n\tFri, 30 Jan 2026 05:29:29 -0800 (PST)","by 2002:a05:600c:34c7:b0:47e:e48b:506d with SMTP id\n\t5b1f17b1804b1-482db47413emr39140235e9.16.1769779769152; \n\tFri, 30 Jan 2026 05:29:29 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 6/7] meson: Move egl related dependencies to\n\t`software_isp` subdir","In-Reply-To":"<20260129164032.1380169-6-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:31 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-6-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:29:27 +0100","Message-ID":"<85wm0zteiw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"hP9tnJi0B5vY90blIEvXX0BerVzFeGjUZwEUIRTu_qo_1769779770","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38025,"web_url":"https://patchwork.libcamera.org/comment/38025/","msgid":"<20260130135319.GJ3374091@killaraus>","date":"2026-01-30T13:53:19","subject":"Re: [PATCH v1 6/7] meson: Move egl related dependencies to\n\t`software_isp` subdir","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Thu, Jan 29, 2026 at 05:40:31PM +0100, Barnabás Pőcze wrote:\n> This way the dependencies are only added if they are actually used.\n\nI don't object to this for the time being, but note that the plan is to\nmake GPU acceleration available to other pipeline handlers for\npost-processing tasks, unrelated to the soft ISP. We'll have to move the\ndependencies back to the libcamera core then.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/meson.build | 6 ------\n> src/libcamera/software_isp/meson.build | 11 ++++++++++-\n> 2 files changed, 10 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 72b7bf02d..575408b2c 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -70,10 +70,6 @@ libcamera_deps = []\n> libatomic = cc.find_library('atomic', required : false)\n> libthreads = dependency('threads')\n> \n> -libegl = dependency('egl', required : false)\n> -libglesv2 = dependency('glesv2', required : false)\n> -mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> -\n> subdir('base')\n> subdir('converter')\n> subdir('ipa')\n> @@ -182,8 +178,6 @@ libcamera_deps += [\n> libcamera_base_private,\n> libcrypto,\n> libdl,\n> - libegl,\n> - libglesv2,\n> liblttng,\n> libudev,\n> libyaml,\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 118d3f92f..cbcd3c1b3 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -2,12 +2,17 @@\n> \n> softisp_enabled = pipelines.contains('simple')\n> summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> endif\n> \n> +libegl = dependency('egl', required : false)\n> +libglesv2 = dependency('glesv2', required : false)\n> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> +\n> +summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> +\n> libcamera_internal_sources += files([\n> 'benchmark.cpp',\n> 'debayer.cpp',\n> @@ -22,4 +27,8 @@ if mesa_works\n> '../egl.cpp',\n> 'debayer_egl.cpp',\n> ])\n> + libcamera_deps += [\n> + libegl,\n> + libglesv2,\n> + ]\n> endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF90CBD78E\n\tfor ;\n\tFri, 30 Jan 2026 13:53:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E44E861FD2;\n\tFri, 30 Jan 2026 14:53:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6ED861F84\n\tfor ;\n\tFri, 30 Jan 2026 14:53:21 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1CB6A73B;\n\tFri, 30 Jan 2026 14:52:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IlUqjDq6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781163;\n\tbh=1ysTqdhjA43RhICXushddV3CoWQ9MdKzoKvhmS/DYUc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IlUqjDq6LYWIqTxNS1qPtU8swyqv0mVJfa8iJidOHuSgdnBFzD6vKtaijz43kpSU2\n\tchJ37rjKLfPvwZSyuPoBkiDQ0qQ2AbF1s/hUV/yOCMxpv23HrUXwbWVivsgVYd0SGv\n\tGGQHUkcifgmA5elC68gmrGF+EefAFttWL2etstBU=","Date":"Fri, 30 Jan 2026 15:53:19 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 6/7] meson: Move egl related dependencies to\n\t`software_isp` subdir","Message-ID":"<20260130135319.GJ3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-6-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129164032.1380169-6-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]