[{"id":38022,"web_url":"https://patchwork.libcamera.org/comment/38022/","msgid":"<851pj7ut97.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:25:56","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> A dependency might very well have custom include directories,\n> so use it when checking for the header file.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 06ed34101..72b7bf02d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -70,9 +70,9 @@ libcamera_deps = []\n> libatomic = cc.find_library('atomic', required : false)\n> libthreads = dependency('threads')\n> \n> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> \n> subdir('base')\n> subdir('converter')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C1D6C3226\n\tfor ;\n\tFri, 30 Jan 2026 13:26:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B61A861FD2;\n\tFri, 30 Jan 2026 14:26:04 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51C7661F84\n\tfor ;\n\tFri, 30 Jan 2026 14:26:02 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-247-rcV3B9UsMtGJk1QbxHF53Q-1; Fri, 30 Jan 2026 08:25:59 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-4806cb47edaso18341705e9.1\n\tfor ;\n\tFri, 30 Jan 2026 05:25:59 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e10edfccsm21347558f8f.17.2026.01.30.05.25.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:25:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"auYAu9Pn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769779561;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=koF9UOvACPtNHlnpQELRlR7RMO1ixPpANOKEqgCpj+0=;\n\tb=auYAu9Pnad5WIYQmEQh+eOeZpLqh07AiynylZAZaoQyjFcDPHgq5wuhXDMK1t4EjVIctxo\n\tDlGwQXXSSkktBEoggLLj0MSsZz40SrbypIDkOEEw2Dfh0vYYVZPJa9hyFtneEdNqvW+bao\n\tNwFgSQQnzY3JS8pe/EHPgD+G13RZ3HA=","X-MC-Unique":"rcV3B9UsMtGJk1QbxHF53Q-1","X-Mimecast-MFC-AGG-ID":"rcV3B9UsMtGJk1QbxHF53Q_1769779558","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769779558; x=1770384358;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=GR68xyyAzy6n+9hGKg9uN3iS3nR6lzUg9/HRxZaBBDE=;\n\tb=E6XkQdSUdwMd2tjAbuLjU6Qocnq3mEMw1yupsMrOeviRBs1q0Td7gtiuzagUtdJjOp\n\tTC9e3MbgxRBes2Coe0+m+N1De7XolEkUA5wR+HD1aAgCzBcfeQiMVGIY3c/x9lZ9vagk\n\tADhSa1V85ptqsCXqkCczDellmkcB9aAIDwPYzvWS2lx3zQXywRGtQWv6rWl2Xi6aqKDt\n\tkuDKYQaeGEskzOZA863cIwPVRRqN/qEtcZyMvF5Ery5mS44OBbwPX9lgo3JTsLLfXosn\n\tc2PSQTNJOVoHhUZ4Xmud9AozcZXd2NBKHSgdZelKW416FPPLNWEofZSUsLYAhIk2nBBj\n\tHKdA==","X-Gm-Message-State":"AOJu0YzCnOdtECxaBfY05cAj6jHuBDde2YlKy7WnETs8d6+a9c2R9U+R\n\tdRPmCicNO2S+1pALZG3W2M1f4198W/lU41FsWj7auP7fjOG4BrfdSQR1JzCEg0ztyMJyPc04ZHB\n\t7zE+SK88aPfsYNarEOu7VwB2V7QUv4DeQ28BbeMiFBQdnAKpUEmhgJYvwx6VqaJbs49ZfgiBMgC\n\t/uNRWqBTCawhrqY9L0sDcldV8ZJyvUOysS3loVFk9uMBT+D/RDN/wh3ckqXSA=","X-Gm-Gg":"AZuq6aKvBcYpFjxcB6kKEamT4VnJE4xIOCaNVgtAx6TGfTaukMsK3x+YaHN1g6sDknc\n\tMmo3Hj83pqWvj4dYB2aVvQM0o5KBj7sjkjDy9beZx9l+UNJCakvop9OewJkoMUTfybBumD/sl6B\n\t2G7ouLky6FhGwgFkFIH5wUlpEKcZFIreyW3a7ZouWk8BV8cj2cs8RLUkOPB16poW52Mo6zPbMg5\n\tqYAh+KAL7Dgj1PrKQ7/5bEpCCcYBKo3zuJ1mrixNTiiMdDsqU/uzodLFAqH1vD2CUTFEMLIhdP7\n\tNee7HHPKJPi5YgGkBUR8NiS+pnzOtFF5j4p0OA+0oaFoi7ItLr756DVYRawHdilugHj1jvwEJYZ\n\tcnYlkwR/JCUhoibXJprTJ21L1PEAPgyy7r+mmQZMa/S0HIqpJ7/5lbu1iy9G7jcs=","X-Received":["by 2002:a05:600c:19c7:b0:47e:e981:78b4 with SMTP id\n\t5b1f17b1804b1-482db477009mr37476325e9.12.1769779558066; \n\tFri, 30 Jan 2026 05:25:58 -0800 (PST)","by 2002:a05:600c:19c7:b0:47e:e981:78b4 with SMTP id\n\t5b1f17b1804b1-482db477009mr37475935e9.12.1769779557552; \n\tFri, 30 Jan 2026 05:25:57 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","In-Reply-To":"<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:30 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:25:56 +0100","Message-ID":"<851pj7ut97.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"whl14KJ6Iy4Dc68BAHH2G6ucqvMlxCiEN7RTaVMxYw0_1769779558","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38028,"web_url":"https://patchwork.libcamera.org/comment/38028/","msgid":"<20260130140019.GL3374091@killaraus>","date":"2026-01-30T14:00:19","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n> A dependency might very well have custom include directories,\n> so use it when checking for the header file.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 06ed34101..72b7bf02d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -70,9 +70,9 @@ libcamera_deps = []\n> libatomic = cc.find_library('atomic', required : false)\n> libthreads = dependency('threads')\n> \n> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n\nUnrelated to this patch, I'd like a comment to explain why this is\nneeded. There's no information in the git history, and I'd like to\nremove this check in the future when/if it won't be needed anymore.\n\nBryan, Hans, could you shed some light on this ?\n\n> \n> subdir('base')\n> subdir('converter')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 799E0C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:00:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 321E161FD3;\n\tFri, 30 Jan 2026 15:00:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AEB961FC6\n\tfor ;\n\tFri, 30 Jan 2026 15:00:21 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E5BD27FA;\n\tFri, 30 Jan 2026 14:59:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h8fcKN6z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781583;\n\tbh=hre7oWiw4meV6Kkhk+1Hkrt4cv/sGNZjE7DYhLKumEU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h8fcKN6zLqHuRoeqNIBxfktNZjcRezmnnzWcV4iU7lznxyvfI2EHC7OB/C+8mjseH\n\tTWXZOoIJroxwm01lBoGR4st7Kdl8KXChxpMg2MDpktDoSv64lN4QyK2cKuWGe9EFSh\n\tURZi08SC3CqT5rZ7R4KJPmAtq3qmbuXX7QlLLHJo=","Date":"Fri, 30 Jan 2026 16:00:19 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBryan O'Donoghue ,\n\tHans de Goede ","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","Message-ID":"<20260130140019.GL3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38032,"web_url":"https://patchwork.libcamera.org/comment/38032/","msgid":"","date":"2026-01-30T14:02:47","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 30. 15:00 keltezéssel, Laurent Pinchart írta:\n> On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n>> A dependency might very well have custom include directories,\n>> so use it when checking for the header file.\n>>\n>> Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/libcamera/meson.build | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index 06ed34101..72b7bf02d 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -70,9 +70,9 @@ libcamera_deps = []\n>> libatomic = cc.find_library('atomic', required : false)\n>> libthreads = dependency('threads')\n>> \n>> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n>> libegl = dependency('egl', required : false)\n>> libglesv2 = dependency('glesv2', required : false)\n>> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> \n> Unrelated to this patch, I'd like a comment to explain why this is\n> needed. There's no information in the git history, and I'd like to\n> remove this check in the future when/if it won't be needed anymore.\n> \n> Bryan, Hans, could you shed some light on this ?\n\nI have asked about this: https://lists.libcamera.org/pipermail/libcamera-devel/2026-January/056096.html\nbut haven't investigated in depth.\n\n\n> \n>> \n>> subdir('base')\n>> subdir('converter')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5B87C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:02:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D06261FD8;\n\tFri, 30 Jan 2026 15:02:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51CCB61FC6\n\tfor ;\n\tFri, 30 Jan 2026 15:02:51 +0100 (CET)","from [192.168.33.42] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C068855C;\n\tFri, 30 Jan 2026 15:02:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PK14z1Hg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781733;\n\tbh=FmnGtRzXkvxzqBJmOpm30Sp6SGKL7d2JQ+Ui2hf3BVM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=PK14z1HgIAt4qJUqI04oOcVzsChN4ycaI9VGG777PT3Mfq/lrtGcMwB/A0OTmePHi\n\tAtO23ZSfJlTVzF367qRgzWTCQb3+58BuZBfKbB0sEK1DIk+VMarb7eBNQWrhZhiEn0\n\t2R6juLOeQ/+YnOCxpxkl5Kk9MdH1oXFcqXxy505s=","Message-ID":"","Date":"Fri, 30 Jan 2026 15:02:47 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBryan O'Donoghue ,\n\tHans de Goede ","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>\n\t<20260130140019.GL3374091@killaraus>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260130140019.GL3374091@killaraus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38039,"web_url":"https://patchwork.libcamera.org/comment/38039/","msgid":"<371881ea-acfa-4b1c-865c-8fa9eb39b4a8@linaro.org>","date":"2026-01-30T16:48:15","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 30/01/2026 14:00, Laurent Pinchart wrote:\n> On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n>> A dependency might very well have custom include directories,\n>> so use it when checking for the header file.\n>>\n>> Signed-off-by: Barnabás Pőcze \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/libcamera/meson.build | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index 06ed34101..72b7bf02d 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -70,9 +70,9 @@ libcamera_deps = []\n>> libatomic = cc.find_library('atomic', required : false)\n>> libthreads = dependency('threads')\n>> \n>> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n>> libegl = dependency('egl', required : false)\n>> libglesv2 = dependency('glesv2', required : false)\n>> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> \n> Unrelated to this patch, I'd like a comment to explain why this is\n> needed. There's no information in the git history, and I'd like to\n> remove this check in the future when/if it won't be needed anymore.\n> \n> Bryan, Hans, could you shed some light on this ?\nBuilding for chromeos in libcamera CI.\n\nChecking for the libs on that platform isn't enough, you need to check \nfor the header too.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86BEBBD78E\n\tfor ;\n\tFri, 30 Jan 2026 16:47:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0D1661FD2;\n\tFri, 30 Jan 2026 17:47:55 +0100 (CET)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 221BE61F84\n\tfor ;\n\tFri, 30 Jan 2026 17:47:54 +0100 (CET)","by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-42fbc305552so2260035f8f.0\n\tfor ;\n\tFri, 30 Jan 2026 08:47:54 -0800 (PST)","from [192.168.21.135] ([94.107.229.70])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e131ce70sm24181466f8f.27.2026.01.30.08.47.52\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 30 Jan 2026 08:47:52 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"zWul5a5v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1769791673; x=1770396473;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=XzboQknCeXVaGdm/8wpb3Dx7yTofvbAesIqasKNwXFM=;\n\tb=zWul5a5vwUT0C2fo+CXlipmYmU++YCVY+Q3ohVM1C3rJF0akViby4ZEY7UBmDy+ve6\n\tu+FqWyG/O8Mktt6X7ztyMzjXxopuJphvBtJen21pAQ/sHN6bscsIAxed0dqWd2eaS84Z\n\t7mMQfqaXVX2QK8HYPZ8/47C7F3HBggxroEBuwXdNhog9iuyYlXtGSxTqFN2N5WfCmUJy\n\thux+7L5XPbRbDNPZj6q4p98n0jZu55ZYDk5DpIU2WCaqcrTbd3xVeKkntJAyui47tAEm\n\t6/Hhw/8L872I6X8zUeGPX6z++EaUvYL1JWSWEyHszo3UTh9K7vgBWjZFyYKiTnRwsC2X\n\teHqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769791673; x=1770396473;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=XzboQknCeXVaGdm/8wpb3Dx7yTofvbAesIqasKNwXFM=;\n\tb=Bj1Mws/VXvdzKaAV1uHY/nLVTjnrfQn+Y3LfZ8AH1fNyLIHrCXsnPCoXGWX2UUP9xc\n\tbj8X6wf7pIE3+4BJWsRE3bgtRsAMyHFSOOg8+LbTt6h4Da6HqKsmzHR6TNdzRmPVgA6/\n\toewu62TUpc7XbqmuVVqS4a+2jRo4Y45fuUimMyWXxbVSOi3MwPUKScFtEp+k6J115ZIv\n\tEbawf9QDGhyqUNfs1QkK8csZhowSSFOyiZ3WLD5rPRTad6QVwIrXshmAIVMyh/mJCBCh\n\tworFoMrSRb22/HNvgHptFnm7hiwZN+gdqd7SZyG2m7TNVPVotJxRtCsh1OetAR1roX0x\n\tqQtA==","X-Gm-Message-State":"AOJu0YyoPZvul7W/E0WUAh0ycxKWzwGzMkkiZC5kk4vFMJ4kwZ5//ySm\n\tOZQmNyh5bY6CvOgj5xI6T9KtpGcSwVWYhsD/yTwjShmqfxq25+AbD6gSlFLNKtPfWPVfAZSM2Ur\n\tr2rlBRKw=","X-Gm-Gg":"AZuq6aLDaKkS3eBbjniDC/1JuxDGTHAzsI/0TcvjM6IGMPQdIG8Kg9CxxmZycTXIuBj\n\tTbxJVEQCQQzUrr93CBIQMHljqmNRxP9vpFalPPDr6aeYrYvJaNAlUeGYzjrrH82JLHkbQN99BIM\n\tAlrNYLpcp/mZ3wFos29GlTToBrTVVATXNR2mvxCa5vpMFJCA+BAIyUuZWPnCXmwgTnYWpEMa2IU\n\tkXZDk/CmVYbseEeHINVzrvNw54/DNN3H2znwx9RAz5Q5+7+JT8rbMpRFu2NUlcRIiDppfogVh5B\n\tEaEtPTb40rDuflJhmflkAvfrICnf3p0a8yRt856HsG5G7zBA5A2TuaHdQVzv/Pz3Se95CH7h5if\n\tf9xuds7ASn6CD1UuBJCYxCTEirwuSPRBuikR9a7Z/m4jLeWkVAa5jT9AxM+Ke2aIsZOjHgMqVDH\n\taZ6/Lzedly5eNfNAd0bfhIrMD4ig==","X-Received":"by 2002:a5d:5d08:0:b0:430:ff81:2961 with SMTP id\n\tffacd0b85a97d-435f3ab023dmr5312171f8f.51.1769791673507; \n\tFri, 30 Jan 2026 08:47:53 -0800 (PST)","Message-ID":"<371881ea-acfa-4b1c-865c-8fa9eb39b4a8@linaro.org>","Date":"Fri, 30 Jan 2026 16:48:15 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","To":"Laurent Pinchart , =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHans de Goede ","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>\n\t<20260130140019.GL3374091@killaraus>","Content-Language":"en-US","From":"Bryan O'Donoghue ","In-Reply-To":"<20260130140019.GL3374091@killaraus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38040,"web_url":"https://patchwork.libcamera.org/comment/38040/","msgid":"<4ea4664e-64b4-4306-a949-dea7b02da016@linaro.org>","date":"2026-01-30T16:52:41","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 30/01/2026 14:02, Barnabás Pőcze wrote:\n> 2026. 01. 30. 15:00 keltezéssel, Laurent Pinchart írta:\n>> On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n>>> A dependency might very well have custom include directories,\n>>> so use it when checking for the header file.\n>>>\n>>> Signed-off-by: Barnabás Pőcze \n>>\n>> Reviewed-by: Laurent Pinchart \n>>\n>>> ---\n>>>   src/libcamera/meson.build | 2 +-\n>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>>> index 06ed34101..72b7bf02d 100644\n>>> --- a/src/libcamera/meson.build\n>>> +++ b/src/libcamera/meson.build\n>>> @@ -70,9 +70,9 @@ libcamera_deps = []\n>>>   libatomic = cc.find_library('atomic', required : false)\n>>>   libthreads = dependency('threads')\n>>> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n>>>   libegl = dependency('egl', required : false)\n>>>   libglesv2 = dependency('glesv2', required : false)\n>>> +mesa_works = cc.check_header('EGL/egl.h', required : false, \n>>> dependencies : libegl)\n>>\n>> Unrelated to this patch, I'd like a comment to explain why this is\n>> needed. There's no information in the git history, and I'd like to\n>> remove this check in the future when/if it won't be needed anymore.\n>>\n>> Bryan, Hans, could you shed some light on this ?\n> \n> I have asked about this: https://lists.libcamera.org/pipermail/ \n> libcamera-devel/2026-January/056096.html\n> but haven't investigated in depth.\nYeah \"depends\" does what it is supposed to do on all of the other build \ntargets but for chromeos not so much.\n\nThe most expedient test was for the headers perhaps there's a better \nsolution. depends on its own won't cover though.\n\nI guess whatever way chromeos - still gentoo/portage ? - packages this \nthe headers and the libs don't come together or - come to think of it \nnow - more likely the headers aren't in the include path.\n\nI'd have to have a look at the chromeos - docker ? - image to understand \nif the headers are just not in the default include path which as i've \ntyped this email, I think is likely.\n\ni.e. you'd expect to get the libs and the headers in one package - so \nlikely depends() is correct but INCLUDES somehow is not....\n\nOr perhaps the heades really are missing, I can't easily tell. If one of \nyou can have a look I'm happy to make a patch or even if you can show me \nhow to look...\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAFE7C3226\n\tfor ;\n\tFri, 30 Jan 2026 16:52:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1129761FD2;\n\tFri, 30 Jan 2026 17:52:21 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9682861F84\n\tfor ;\n\tFri, 30 Jan 2026 17:52:19 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-42fbc305552so2264156f8f.0\n\tfor ;\n\tFri, 30 Jan 2026 08:52:19 -0800 (PST)","from [192.168.21.135] ([94.107.229.70])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e1322eefsm24435561f8f.30.2026.01.30.08.52.18\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 30 Jan 2026 08:52:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"siLnczyo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1769791939; x=1770396739;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=aabb3giblzyXd3Jn4f20nzbLJdIUfqobdh7WEBZIOFw=;\n\tb=siLnczyoPHwxrPGy5sZkn5J6or9/HMrmwxYFOPPfpjzoYecROY/Qkg/FYdcN/M64v+\n\tPVDeRY6qoE684ODUGBaxkoNjr83EOa4QV6ICVu9YjtUAa0FrxxikMEyASmzFAkl6YxLE\n\tf/HB2Qyd6vPVHtsdR82bg6LJpEVzDrixB5C/uoXVdYn3Tlu9RdIZeXIO7thaK6Nq72x/\n\tdNcLsWg4AE88hz+eNoylS+y1EMzm60A+wbOyD6AyKdww6X0RnQH7f9T5V2gku3yiCz43\n\tjxUDdDIB6h/u1SW1u9jUSAkblJe/8KbFham0zye1SX/mcN42UaaY+n50sNRePL2MuabB\n\tI3gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769791939; x=1770396739;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=aabb3giblzyXd3Jn4f20nzbLJdIUfqobdh7WEBZIOFw=;\n\tb=lCr35CRdJfAMCF1zIzrWVVwtJNDvFFyhZ3+cO2iJuHj92m8uIcjDmbnfkNFdA3p58M\n\t3rLuWkaQXdhZ47JlwRgASB/0U2U/BisN2HvKN2pvRYQeo6HtEjNJFHRQ7qVf8bDb0GaJ\n\tJZMIhFC2DCrsCxTmS78m+IW4ygJWlrYojr9hk8XUzcR0Z+ymEgfDb2joSXH241bVRGFr\n\tCtHLdvcw0baX+Vb7oDtMp1eAgqD6v9n9up0l6XOJKqYcl+ai5D1O8qhcwLsFUkwI/h2v\n\truICkJCZ4CTPaVBnenB5wNIUmyxTZn191MkvJH6WXg1yzFB/sTfe88w6rhG1iQsZK3t3\n\tF2UA==","X-Gm-Message-State":"AOJu0YwEyZlRjR7Ohdq6ubcAp1iurUWcPMLZiwF4lg1p0SODcV9yU8v6\n\t6fv6tITmf/zHnUDutyU546lrkEoMAagvMr3uie5LjGJynHBEa3iVdJEWFsSADQqxLSg=","X-Gm-Gg":"AZuq6aICW6u5jF3SVUSKvHDSpPqf4TN9mljoISTSGHHJzxDLYnq5GSj5NUOYtxAThcO\n\tHdHtEKv08UYLStKb01hAT5eR02lvBTXSQZTA4Tvn6NzulX677G8DWSTLwlkTJz7bQF2YIRf9Nus\n\t1p1km9++GARDGQ+O5BVMzSLe/Ts/BxbvyhmZelCjeHKMY1XjQdMccgfbDe0+ZEjfSlsvj0b/AcF\n\tFYvwOAUKS2YLS6UQ0iaPfjOHlBIefKxtaFpzMfwwbn4j7BVyytZvkN/7HRK/CdEw3EYKlDoJgdE\n\t5iQyIU6It8MxZZlAxbV9Tt46G5jg034NIQxATk1OgPq7YKGbZ1fmgkRVyZcSDKBQ2qzB84T9r71\n\tS5qbf/2HucTjpYzJu+zOTb7a5cd40HC/T+4RrhmKrCWltFSUDD1GiSGlmVCUar4ElzLmjjnYk8j\n\txE0yURf1U0mfrq2JGCgL/easLd+w==","X-Received":"by 2002:a05:6000:2408:b0:435:907f:e436 with SMTP id\n\tffacd0b85a97d-435f3ab0248mr5215870f8f.52.1769791938968; \n\tFri, 30 Jan 2026 08:52:18 -0800 (PST)","Message-ID":"<4ea4664e-64b4-4306-a949-dea7b02da016@linaro.org>","Date":"Fri, 30 Jan 2026 16:52:41 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHans de Goede ","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>\n\t<20260130140019.GL3374091@killaraus>\n\t","Content-Language":"en-US","From":"Bryan O'Donoghue ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38100,"web_url":"https://patchwork.libcamera.org/comment/38100/","msgid":"<20260205145849.GN156228@killaraus>","date":"2026-02-05T14:58:49","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 30, 2026 at 04:52:41PM +0000, Bryan O'Donoghue wrote:\n> On 30/01/2026 14:02, Barnabás Pőcze wrote:\n> > 2026. 01. 30. 15:00 keltezéssel, Laurent Pinchart írta:\n> >> On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n> >>> A dependency might very well have custom include directories,\n> >>> so use it when checking for the header file.\n> >>>\n> >>> Signed-off-by: Barnabás Pőcze \n> >>\n> >> Reviewed-by: Laurent Pinchart \n> >>\n> >>> ---\n> >>>   src/libcamera/meson.build | 2 +-\n> >>>   1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> >>> index 06ed34101..72b7bf02d 100644\n> >>> --- a/src/libcamera/meson.build\n> >>> +++ b/src/libcamera/meson.build\n> >>> @@ -70,9 +70,9 @@ libcamera_deps = []\n> >>>   libatomic = cc.find_library('atomic', required : false)\n> >>>   libthreads = dependency('threads')\n> >>> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n> >>>   libegl = dependency('egl', required : false)\n> >>>   libglesv2 = dependency('glesv2', required : false)\n> >>> +mesa_works = cc.check_header('EGL/egl.h', required : false, \n> >>> dependencies : libegl)\n> >>\n> >> Unrelated to this patch, I'd like a comment to explain why this is\n> >> needed. There's no information in the git history, and I'd like to\n> >> remove this check in the future when/if it won't be needed anymore.\n> >>\n> >> Bryan, Hans, could you shed some light on this ?\n> > \n> > I have asked about this: https://lists.libcamera.org/pipermail/ \n> > libcamera-devel/2026-January/056096.html\n> > but haven't investigated in depth.\n> \n> Yeah \"depends\" does what it is supposed to do on all of the other build \n> targets but for chromeos not so much.\n> \n> The most expedient test was for the headers perhaps there's a better \n> solution. depends on its own won't cover though.\n> \n> I guess whatever way chromeos - still gentoo/portage ? - packages this \n> the headers and the libs don't come together or - come to think of it \n> now - more likely the headers aren't in the include path.\n> \n> I'd have to have a look at the chromeos - docker ? - image to understand \n> if the headers are just not in the default include path which as i've \n> typed this email, I think is likely.\n> \n> i.e. you'd expect to get the libs and the headers in one package - so \n> likely depends() is correct but INCLUDES somehow is not....\n> \n> Or perhaps the heades really are missing, I can't easily tell. If one of \n> you can have a look I'm happy to make a patch or even if you can show me \n> how to look...\n\nI checked, and as far as I can tell, they are indeed missing.\n\nThis is probably fixable, by adding media-libs/libglvnd to the container\nimage (possibly by setting the libglvnd USE flag for the\nmedia-libs/mesa-iris package). I'm giving it a try, now that I have a\nfaster machine with plenty of empty disk space :-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13360C31E9\n\tfor ;\n\tThu, 5 Feb 2026 14:58:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 234DE62062;\n\tThu, 5 Feb 2026 15:58:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E09162010\n\tfor ;\n\tThu, 5 Feb 2026 15:58:51 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1CD74227;\n\tThu, 5 Feb 2026 15:58:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"twUDXYAs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770303488;\n\tbh=V39GlPGagNs62kXBdarSLopyY+FqDPVWblo27ic4WUE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=twUDXYAsySZrnCNVQQxMl/AtimgIbubPpNV20bEgCE3QYQWfqVQbfhHc0uDdAQ3BC\n\tdESmvAxK6SinjqnNJ/R7UgoGNMqeNQQ5VseAPRjWRBONSulDuYhvqRiunUUkeWVu7M\n\t7GXNQdGH8alJwUQhsldlA0XlD1JCuq4DzMKkIbMI=","Date":"Thu, 5 Feb 2026 16:58:49 +0200","From":"Laurent Pinchart ","To":"Bryan O'Donoghue ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org, Hans de Goede\n\t","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","Message-ID":"<20260205145849.GN156228@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>\n\t<20260130140019.GL3374091@killaraus>\n\t\n\t<4ea4664e-64b4-4306-a949-dea7b02da016@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<4ea4664e-64b4-4306-a949-dea7b02da016@linaro.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38101,"web_url":"https://patchwork.libcamera.org/comment/38101/","msgid":"<20260205181302.GA1328592@killaraus.ideasonboard.com>","date":"2026-02-05T18:13:02","subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Feb 05, 2026 at 04:58:51PM +0200, Laurent Pinchart wrote:\n> On Fri, Jan 30, 2026 at 04:52:41PM +0000, Bryan O'Donoghue wrote:\n> > On 30/01/2026 14:02, Barnabás Pőcze wrote:\n> > > 2026. 01. 30. 15:00 keltezéssel, Laurent Pinchart írta:\n> > >> On Thu, Jan 29, 2026 at 05:40:30PM +0100, Barnabás Pőcze wrote:\n> > >>> A dependency might very well have custom include directories,\n> > >>> so use it when checking for the header file.\n> > >>>\n> > >>> Signed-off-by: Barnabás Pőcze \n> > >>\n> > >> Reviewed-by: Laurent Pinchart \n> > >>\n> > >>> ---\n> > >>>   src/libcamera/meson.build | 2 +-\n> > >>>   1 file changed, 1 insertion(+), 1 deletion(-)\n> > >>>\n> > >>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > >>> index 06ed34101..72b7bf02d 100644\n> > >>> --- a/src/libcamera/meson.build\n> > >>> +++ b/src/libcamera/meson.build\n> > >>> @@ -70,9 +70,9 @@ libcamera_deps = []\n> > >>>   libatomic = cc.find_library('atomic', required : false)\n> > >>>   libthreads = dependency('threads')\n> > >>> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n> > >>>   libegl = dependency('egl', required : false)\n> > >>>   libglesv2 = dependency('glesv2', required : false)\n> > >>> +mesa_works = cc.check_header('EGL/egl.h', required : false, \n> > >>> dependencies : libegl)\n> > >>\n> > >> Unrelated to this patch, I'd like a comment to explain why this is\n> > >> needed. There's no information in the git history, and I'd like to\n> > >> remove this check in the future when/if it won't be needed anymore.\n> > >>\n> > >> Bryan, Hans, could you shed some light on this ?\n> > > \n> > > I have asked about this: https://lists.libcamera.org/pipermail/ \n> > > libcamera-devel/2026-January/056096.html\n> > > but haven't investigated in depth.\n> > \n> > Yeah \"depends\" does what it is supposed to do on all of the other build \n> > targets but for chromeos not so much.\n> > \n> > The most expedient test was for the headers perhaps there's a better \n> > solution. depends on its own won't cover though.\n> > \n> > I guess whatever way chromeos - still gentoo/portage ? - packages this \n> > the headers and the libs don't come together or - come to think of it \n> > now - more likely the headers aren't in the include path.\n> > \n> > I'd have to have a look at the chromeos - docker ? - image to understand \n> > if the headers are just not in the default include path which as i've \n> > typed this email, I think is likely.\n> > \n> > i.e. you'd expect to get the libs and the headers in one package - so \n> > likely depends() is correct but INCLUDES somehow is not....\n> > \n> > Or perhaps the heades really are missing, I can't easily tell. If one of \n> > you can have a look I'm happy to make a patch or even if you can show me \n> > how to look...\n> \n> I checked, and as far as I can tell, they are indeed missing.\n> \n> This is probably fixable, by adding media-libs/libglvnd to the container\n> image (possibly by setting the libglvnd USE flag for the\n> media-libs/mesa-iris package). I'm giving it a try, now that I have a\n> faster machine with plenty of empty disk space :-)\n\nI enabled the libglvnd USE flag for the media-libs/mesa-iris package, but that\ndidn't help. It installed the media-libs/libglvnd package, which\nprovided more GL-related headers, but not the EGL headers. This is\nbecause the ebuild ([1]) explicitly deletes the headers in its install\nphase:\n\nmultilib_src_install_all() {\n\t# Remove redundant GLES headers\n\trm -f \"${D}\"/usr/include/{EGL,GLES2,GLES3,KHR}/*.h || die \"Removing GLES headers failed.\"\n}\n\ngit blame informs me that ([2])\n\n When mesa is built with glvnd=true, it does not install gl headers.\n So libglvnd must install them instead, while avoiding the same\n redundant GLES headers that mesa ebuilds avoid.\n\nThe mesa-iris ebuild contains\n\nsrc_install() {\n\ttools_to_cleanup=$(get_tools_to_cleanup)\n\n\tmeson_src_install\n\n\trm -v -rf \"${ED}/usr/include\"\n\n\t# Clean up the unneeded tools if any.\n\tfor tool in ${tools_to_cleanup}; do\n\t\trm -v -rf \"${ED}/usr/bin/${tool}\"\n\tdone\n}\n\nand git blame doesn't explain why. It may be a bug in Chrome OS.\n\nAs we don't have a Soraka connected to CI at the moment, I'll disable\nthe cros build job. We can try to fix the issue when we reenable it\nlater.\n\n[1] https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/refs/heads/release-R135-16209.B/media-libs/libglvnd/libglvnd-1.7.0.ebuild\n[2] https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f72e921b72ed881a504ff5bb79cdd0fbd4612bff%5E%21/media-libs/libglvnd/libglvnd-1.3.3.ebuild","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5A5BBD78E\n\tfor ;\n\tThu, 5 Feb 2026 18:13:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C155662063;\n\tThu, 5 Feb 2026 19:13:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD57C62010\n\tfor ;\n\tThu, 5 Feb 2026 19:13:03 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BF33FD0;\n\tThu, 5 Feb 2026 19:12:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bcXnXMw7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770315140;\n\tbh=rXDQNbdj1dakRVlz7oQOxY4jIHXTs1PqUm0wgridB0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bcXnXMw7tx9ni6MPgPzhuFCXJGgpCectG/3yd+UsrK4LUAnd+M264W/z6o30rhYRZ\n\t3v15U2KeJcD9CaD1QG5179GrdKLkHXlmug+rsqJ/ICA+qAlOqBy6dpr+PL/syGztFx\n\taEakhwe5WiETKqePlf1WdooG33sk0P0lB4MklZN0=","Date":"Thu, 5 Feb 2026 20:13:02 +0200","From":"Laurent Pinchart ","To":"Bryan O'Donoghue ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org, Hans de Goede\n\t","Subject":"Re: [PATCH v1 5/7] meson: Use dependency object when checking for\n\theaders","Message-ID":"<20260205181302.GA1328592@killaraus.ideasonboard.com>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-5-barnabas.pocze@ideasonboard.com>\n\t<20260130140019.GL3374091@killaraus>\n\t\n\t<4ea4664e-64b4-4306-a949-dea7b02da016@linaro.org>\n\t<20260205145849.GN156228@killaraus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260205145849.GN156228@killaraus>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]