[{"id":38021,"web_url":"https://patchwork.libcamera.org/comment/38021/","msgid":"<855x8juto4.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:16:59","subject":"Re: [PATCH v1 4/7] meson: Remove `gles_headless_enabled`","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> Use the `mesa_works` variable instead to simplify, the two variables\n> have the same value.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/meson.build | 6 ------\n> src/libcamera/software_isp/meson.build | 4 ++--\n> 2 files changed, 2 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 28ce93de6..06ed34101 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,12 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if mesa_works\n> - gles_headless_enabled = true\n> -else\n> - gles_headless_enabled = false\n> -endif\n> -\n> subdir('base')\n> subdir('converter')\n> subdir('ipa')\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 4c61909fd..118d3f92f 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -2,7 +2,7 @@\n> \n> softisp_enabled = pipelines.contains('simple')\n> summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> -summary({'SoftISP GPU acceleration' : gles_headless_enabled}, section : 'Configuration')\n> +summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([\n> 'swstats_cpu.cpp',\n> ])\n> \n> -if gles_headless_enabled\n> +if mesa_works\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> '../egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC4A4BD78E\n\tfor ;\n\tFri, 30 Jan 2026 13:17:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8AC661FD1;\n\tFri, 30 Jan 2026 14:17:08 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F6AF61F84\n\tfor ;\n\tFri, 30 Jan 2026 14:17:06 +0100 (CET)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-442-EjcChnQEOEa9iI7OT8H2uw-1; Fri, 30 Jan 2026 08:17:04 -0500","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-48057c39931so24883475e9.0\n\tfor ;\n\tFri, 30 Jan 2026 05:17:03 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e132303fsm22847712f8f.36.2026.01.30.05.17.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:17:00 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"fCf6CcuP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769779025;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=jiPbkfJmFBLF9vejLMeyJck09TkZtfTnDptLOZDgLns=;\n\tb=fCf6CcuPht3RSIH36DcAbJKsqoByJRbTdc1fCIn4MTaW8Jdsnw+Jc4AWdzeEkaZG5J+2Sg\n\trNlTGBSSnW8SPp6gNsVjQ7SSYd1VH6xhNhK7JvLF1xkZrbGqJof42kxDTTsBHqBVz0uz+2\n\tWazgSP3bsrcZK551dcFDVHlj0DmVnds=","X-MC-Unique":"EjcChnQEOEa9iI7OT8H2uw-1","X-Mimecast-MFC-AGG-ID":"EjcChnQEOEa9iI7OT8H2uw_1769779023","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769779022; x=1770383822;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=no6lhivuXXitBIAzMQUd8yt6SHZDWye52PD//Qkj1I0=;\n\tb=Bq4q2HUXTypvHgP+V5RM8koZW7LCCZ0tKGKWjR/b7kBcBE40V8KCyXsSTQdNybOHiF\n\t0xCV6HRqhn1yxe7OJ6DijRB21bYIYxSdaPKXQDrdRQ/Syk33GGSWecvGjKEb6+DWFG+d\n\tglX1PmOajAs0wlxAPER3vA2L5M/VVdLqY84ZjzWe5cR0D/6tzq0c7PtPZ9njkDdgekEy\n\tK4QGwXTNVObhy9yyaWUR3s0C4WYLnk8UrZnJGJZLaCZZKqGVhJFHpkkviL0yVstzOzAR\n\tXTn6F2iKN7R0WRkOMxZn870C7yLme8fIBOjyc8VYUqiDiqwvFF/ScXzQPdQejKx3y7Uo\n\tAkCA==","X-Gm-Message-State":"AOJu0YymmS75eIQGRneOtzoA78lUGa5NMIYgQLkPpnbzjGm/ENZsRZ0T\n\tPw+ytxeLVBOBbQkyChYjJfoSpJirs0PyDP24eSiayyFB/sD8u1beJybJ/jSDnyH2ZqBuDDtmFdn\n\t95xo29AVxd1dIz9QFQlX30YCvnQi+kztScTJfNT/K//W5GDP/owsUno+r3t5cS5HT+A2gqaBta8\n\t2vp6A1v4qeDQyDyn++uGpQDe4Ok73PfOAJ+1Cv5JjmC39kzmDfiMC/pQnbehw=","X-Gm-Gg":"AZuq6aJGc8g60Eo8fnlAlgT4ncxOg+lNL4vjBvspTHtUNF4lGpyjo2jQ48EASyq8KUE\n\tpS3QVm6S/TQy3xSyCXt3ooHjfn2e6SHDpabak5caNecZc9xbjrDqRkz9maXQa49n7bEQOnissZx\n\twbv8oXBJhu8efm8Optt6qxgqYNxSlFSKXxVs6iiHjRV41cNd6EAPhwxtnDg8yD1q4GxU0FmNIh9\n\twYfrWkEK9P+DKBtfV0AhNF51nR9OHZrQBVb0AG5C3JVBPPzrKfJXSVdk3idIOblST0UyK526031\n\tIj8RitTqS3ufqsrMr+1C1dyNsTAzcH13uSKYaR3CnFJC0niPn0PDFuhah/txyuImSOWunlCA+R/\n\tLkIfKKdJ1rpWKfdydAWpMoNU4TlBGewO7TiiX34zXLMPvEZ/Mc3lh5tLAREM0mpU=","X-Received":["by 2002:a05:600c:4f47:b0:47d:403e:4eaf with SMTP id\n\t5b1f17b1804b1-482db460714mr38777495e9.10.1769779022266; \n\tFri, 30 Jan 2026 05:17:02 -0800 (PST)","by 2002:a05:600c:4f47:b0:47d:403e:4eaf with SMTP id\n\t5b1f17b1804b1-482db460714mr38776455e9.10.1769779021203; \n\tFri, 30 Jan 2026 05:17:01 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 4/7] meson: Remove `gles_headless_enabled`","In-Reply-To":"<20260129164032.1380169-4-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:29 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-4-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:16:59 +0100","Message-ID":"<855x8juto4.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9EI9PL-jjd61Cd-TgncjuJ413_ocaZOhwEe2PzLePpY_1769779023","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38034,"web_url":"https://patchwork.libcamera.org/comment/38034/","msgid":"<20260130140356.GP3374091@killaraus>","date":"2026-01-30T14:03:56","subject":"Re: [PATCH v1 4/7] meson: Remove `gles_headless_enabled`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 29, 2026 at 05:40:29PM +0100, Barnabás Pőcze wrote:\n> Use the `mesa_works` variable instead to simplify, the two variables\n> have the same value.\n\nmesa_works is a weird name. I'd rename it to gles_enabled or\ngles_available. This can be done on top.\n\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/meson.build | 6 ------\n> src/libcamera/software_isp/meson.build | 4 ++--\n> 2 files changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 28ce93de6..06ed34101 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,12 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if mesa_works\n> - gles_headless_enabled = true\n> -else\n> - gles_headless_enabled = false\n> -endif\n> -\n> subdir('base')\n> subdir('converter')\n> subdir('ipa')\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 4c61909fd..118d3f92f 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -2,7 +2,7 @@\n> \n> softisp_enabled = pipelines.contains('simple')\n> summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> -summary({'SoftISP GPU acceleration' : gles_headless_enabled}, section : 'Configuration')\n> +summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([\n> 'swstats_cpu.cpp',\n> ])\n> \n> -if gles_headless_enabled\n> +if mesa_works\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> '../egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A31F6BD78E\n\tfor ;\n\tFri, 30 Jan 2026 14:03:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62F8161FCE;\n\tFri, 30 Jan 2026 15:03:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B569861FC6\n\tfor ;\n\tFri, 30 Jan 2026 15:03:57 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3802D55C;\n\tFri, 30 Jan 2026 15:03:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jghw95o8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781799;\n\tbh=c621R/z8zAROxj+F9m+hfjJ5KbL1DXEy9f5R1v7rNMY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jghw95o8J2mX3HHpeKrhrnS3PgCC6NVlymLbocbMG97TfcySa96+1BOup8mHM9/PD\n\tspXdSQl6bXs69yjbsOznsuActRmWKS/PDuy7JTc7GB8yPRf1awgsu5X8QXl14BAsTu\n\tutTaBwjxRHKZkJe77PerWtd8dCGbVkTxaP7r71P0=","Date":"Fri, 30 Jan 2026 16:03:56 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 4/7] meson: Remove `gles_headless_enabled`","Message-ID":"<20260130140356.GP3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129164032.1380169-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]