[{"id":38020,"web_url":"https://patchwork.libcamera.org/comment/38020/","msgid":"<85a4xvuu23.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:08:36","subject":"Re: [PATCH v1 3/7] meson: Simplify condition","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> If `softisp_enabled` is false, then `subdir_done()` is called above.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index a55b76b58..4c61909fd 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([\n> 'swstats_cpu.cpp',\n> ])\n> \n> -if softisp_enabled and gles_headless_enabled\n> +if gles_headless_enabled\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> '../egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9509DC3226\n\tfor ;\n\tFri, 30 Jan 2026 13:08:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DD1461FD2;\n\tFri, 30 Jan 2026 14:08:44 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33AEC61F84\n\tfor ;\n\tFri, 30 Jan 2026 14:08:42 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-538-lLItsPprPCCzQ_UK-0CmNQ-1; Fri, 30 Jan 2026 08:08:39 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-430ffc4dc83so2478288f8f.3\n\tfor ;\n\tFri, 30 Jan 2026 05:08:39 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-435e10ee04csm22465513f8f.12.2026.01.30.05.08.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:08:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"X1YxPIc3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769778520;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=OvuFfO3HIMDjFOLb46RQcXvm9ulnY29eUSwulqvx7Sk=;\n\tb=X1YxPIc37TXwaSKPtdomHURYa8NODOg0iLt4wCbhsK/dIGeNqOTJcLGRnCNeJB0KIeDyWU\n\tJRzHQ78daSsAR0wSFabRv2/XYWF9JGI5+P6K+ecBe1gbmf1zgX75LaqUfOsgO8p25qVE0q\n\trdKgxqKGlnD2FuAHaNFGtkdZDWcw9P0=","X-MC-Unique":"lLItsPprPCCzQ_UK-0CmNQ-1","X-Mimecast-MFC-AGG-ID":"lLItsPprPCCzQ_UK-0CmNQ_1769778518","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769778518; x=1770383318;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8b4809curO+8uFJ8VTnK2Na9AAIFX3TfRowVFGdSWVM=;\n\tb=VN1Oxb3AQTm/i6+/pkP52WQW5Z2yl9bQN2uLuepe2+CRQmaMTvkYtrm/+9yyu2DTI3\n\t+rhbNgiUQa2+FV7N51caz/z0TpUv6cjdBHSa7HLPukVy+wLk+mTqKiJgkzyaHh0iAhX2\n\tM5dsC20ruo1WmFFE1laXs5Y7bs6lG2bgyMpCyDhsKIpROOT69IoffjYZ/9Mm8HcbacWd\n\tzqqI6E2dimJOe6W3vNwD8+tRz8kFCSrk4rgH13LFs5NsE5ZqaFOrl1xuW2FvKCHSDxnB\n\tg7J8Ox3XObsG83cAgxn9tdvaG8koOo5/z3aMalvzSokqg0j0yOJtcvv+PSbwtbiv+EHd\n\tAolA==","X-Gm-Message-State":"AOJu0Yw/LhpoVxz8Z2YgzNLt1vo1yUqxfG7G2h1GpXUSSZvpVMQ/9CLV\n\t/BLX2bnSOvD22qpp16R1bQgQfsMOoXS/X8/znxPQh1MbvapU85sp3xtg45J0ehZ3s630k8nxXjp\n\tbdno2swAl1iNSIRZZe6gTrHhtuAjKBAjCxNASIC6TOfEsZsg9Mva5ifQ2qFuNrCNeX/MkRA5+p7\n\tE4PtkbdvZXtB0tmdVSQtgF5he/Al/p3+4Aaho4Hl8WfPy/+mv9X7AdYOhL7SA=","X-Gm-Gg":"AZuq6aJqYMSb1jDJv23GPzUmcaEnbmYdUjFKz96TXwcDcYAQrlzorytPaFOfPaVhmiO\n\tfOha9Ec6Wv2RPjpzAhIhqcbZ8fI7HCSoe/sddi2ucaahAJll5wFJ4t7c5QvanTOoWbtkAUAwl75\n\te19ngVkZaVhH1ONryyO163yVkZJjMoIxQNVVedDZpTkYzkKDbPRDZBtWEuYt8rRGTf1xy7iFpEu\n\t9Hmclb3mhw+ojOOP/4i8tx0L+pQEGIRZhMnX4TXi5QwuMLwI49z4M4UiReVTuboDaIJbdfwyxOU\n\tERTdjJG1aLrJaPkgmmJIPAW2wTslQsMnXvm3UTf1XsUxQI5o7PnQKbzGjA86T//iIyciY6lDgHf\n\tUQvyJ41EYXiqyN1pXenCgKAxPTI/r04zWRTHFzWtmNreWrHkawDQMMUojPMCslQg=","X-Received":["by 2002:a05:6000:2408:b0:435:907f:e436 with SMTP id\n\tffacd0b85a97d-435f3ab0248mr4218662f8f.52.1769778517775; \n\tFri, 30 Jan 2026 05:08:37 -0800 (PST)","by 2002:a05:6000:2408:b0:435:907f:e436 with SMTP id\n\tffacd0b85a97d-435f3ab0248mr4218614f8f.52.1769778517304; \n\tFri, 30 Jan 2026 05:08:37 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 3/7] meson: Simplify condition","In-Reply-To":"<20260129164032.1380169-3-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:28 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-3-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:08:36 +0100","Message-ID":"<85a4xvuu23.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"DyxLUatdKE6FuE_Ry9WFilJK2AAXE2QYqXMZQfsnydM_1769778518","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38033,"web_url":"https://patchwork.libcamera.org/comment/38033/","msgid":"<20260130140251.GO3374091@killaraus>","date":"2026-01-30T14:02:51","subject":"Re: [PATCH v1 3/7] meson: Simplify condition","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 29, 2026 at 05:40:28PM +0100, Barnabás Pőcze wrote:\n> If `softisp_enabled` is false, then `subdir_done()` is called above.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/software_isp/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index a55b76b58..4c61909fd 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([\n> 'swstats_cpu.cpp',\n> ])\n> \n> -if softisp_enabled and gles_headless_enabled\n> +if gles_headless_enabled\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> '../egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFA6AC3226\n\tfor ;\n\tFri, 30 Jan 2026 14:02:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92B6F61FCE;\n\tFri, 30 Jan 2026 15:02:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E794C61FC8\n\tfor ;\n\tFri, 30 Jan 2026 15:02:52 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3DBA77FA;\n\tFri, 30 Jan 2026 15:02:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T8mxfCg/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781734;\n\tbh=TbfT/mknBImvgRlLcYS+2FUL4ZwYygUToKB/v4/iT1E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T8mxfCg/LQ0SqbuStrEhHCZaM8S4DsgJVNBQUnJuhUGUnMyLGaDbAWzAft/KQi2j0\n\tnVazElBeCDt/lKxUq9uqDR/wmeYMdwgF+dV3PD+oFv5TRI3bJNt+2j8p7eGyPYc7GO\n\tCGU/3tZCqlU+5b1FTh2plaY8kvgXHRwwusa9Buhc=","Date":"Fri, 30 Jan 2026 16:02:51 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 3/7] meson: Simplify condition","Message-ID":"<20260130140251.GO3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-3-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129164032.1380169-3-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]