[{"id":38018,"web_url":"https://patchwork.libcamera.org/comment/38018/","msgid":"<85ldhfuuiu.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T12:58:33","subject":"Re: [PATCH v1 1/7] meson: Drop unnecessary egl, gles feature defines","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/meson.build | 8 --------\n> 1 file changed, 8 deletions(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index d15943586..c6c109a30 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if libegl.found()\n> - config_h.set('HAVE_LIBEGL', 1)\n> -endif\n> -\n> -if libglesv2.found()\n> - config_h.set('HAVE_GLESV2', 1)\n> -endif\n> -\n> if mesa_works\n> libcamera_internal_sources += files([\n> 'egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32F69C3226\n\tfor ;\n\tFri, 30 Jan 2026 12:58:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EFF361FD2;\n\tFri, 30 Jan 2026 13:58:41 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD6DD61F84\n\tfor ;\n\tFri, 30 Jan 2026 13:58:39 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-364-FwzZBPyRPBeQDM8y-_VX-g-1; Fri, 30 Jan 2026 07:58:37 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-47edfdc6c1aso17024175e9.3\n\tfor ;\n\tFri, 30 Jan 2026 04:58:36 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-482da91a227sm26940615e9.2.2026.01.30.04.58.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 04:58:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Mcb8a9NC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769777918;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=nqDeUsQ/FcpMQX05ouROcCM+k0SrySTOvJ/osVLYiT0=;\n\tb=Mcb8a9NCltkESbVndZQEpYsOTfzJwmyTaOpkDLM1QAnsVnneIQhd8dNozjfnmgtxF1ry43\n\tFZVs+sfCg+RxQ7x3hNjLwtsL0yQ4DTRnOWIPTPFG/c03KIYESvpLmYP1UYyLLjbMlujv/n\n\tBQFIL6RTuJJ0642axgUXJeM+7Z6m9Po=","X-MC-Unique":"FwzZBPyRPBeQDM8y-_VX-g-1","X-Mimecast-MFC-AGG-ID":"FwzZBPyRPBeQDM8y-_VX-g_1769777916","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769777915; x=1770382715;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=hkqX9FzUkaYuc8XBI6cju34ADD1A+nB2eMdijMf+44E=;\n\tb=jn17JTiWaaX0h2IcTU2JRKpCqk0BoPhNYYvRef2JP2dbrQokBkt6b5pllGRTL9fFPk\n\tldz8yVJmNuf3VLTQ3oSg83Tb+VBmNNAzWlDkrMySXMJfzBGdqy0lJTcP0lYXvjo3Sduj\n\trjGaV3ZzbhuLth08mkemtRKQmTcExaSrgB44tYj3BcUCFJF01tXA7a6qcc5NBeH33+Cp\n\tsnzkQwoF/SQUj4oKMRqjfvwSSqdE85HJHw+fmjjFdj+gbDnEQGRFgotHM4971IY6/tq+\n\tXGD57//BSCHngcDeApDVttKNrNsNez/Bun0HBdqrZoP1DT9xThv/FifQ8q3AwLW0NtGK\n\t0mhA==","X-Gm-Message-State":"AOJu0Yxr8vcThpuTNqeZmJEGU9+ycJX+DTpX80ELnOeG/YSduYYGS/Z4\n\tJzt+KyfIScKbFXM7MOV3mu7aeT4O74uYBo47xKPPrZXlTouWnxbm4q8MTgySNcSPoi3cy/dFpN3\n\tQlb464dLhMVVuPjkfGCYLVYV0BYJm0ZpXPB04uzNKPReJUjqdlO6G9m9LYz9w/1FpSFocwhzfMm\n\tY9LOsz7mDf4tMwPXafchT4Qu3PgVG4KGrlH8ITFpqeOPT2kECFhOPjVXYfBKI=","X-Gm-Gg":"AZuq6aJriv4ey9WJy25osl86g3kOtmkCYdcH8/V7A9P+Jg9roDoRzy7I8fes/MRucXi\n\trxJp/EVJHnqdRfrdwx8k9KhUc2qJqM8qjnWBryv9NS8btQdlYbz+awe0gRstJbS7QbkZVGfpHGY\n\twxp5ymepSXQ09x7SshGzuGwHqUUj+evBIkk1wH4zLPmtVSz9z7ZqJfirf1vVoMB6gEZUupbbaDW\n\tH3ozFM8uDNtRthXYlBjc8XDfD3Wb+XfHVUdm5nRRQ1dtxsRABYKz+U1+zodQw7VPQJt5IzuJWw9\n\t0pCTAAu1caI8fWEsVVaUvmFg77jKJTT3LBns+V9rShaPvfy9EZA8bxRwFlKlTJq8hSk0eFp3tLa\n\t2mNx8Zv/eduJEnQG7yh7+sKM1mTyyaPCr8BsmCtxtSlo1twHc3K3cRxKz8tGVFlw=","X-Received":["by 2002:a05:600c:4ec7:b0:47d:264e:b35a with SMTP id\n\t5b1f17b1804b1-482db46b3eemr33427985e9.13.1769777915302; \n\tFri, 30 Jan 2026 04:58:35 -0800 (PST)","by 2002:a05:600c:4ec7:b0:47d:264e:b35a with SMTP id\n\t5b1f17b1804b1-482db46b3eemr33427635e9.13.1769777914817; \n\tFri, 30 Jan 2026 04:58:34 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/7] meson: Drop unnecessary egl, gles feature defines","In-Reply-To":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:26 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 13:58:33 +0100","Message-ID":"<85ldhfuuiu.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"J7AiI_kbYWAyHYd6bRYTS8W4_GFRlWKt49Fvi6sUBks_1769777916","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38029,"web_url":"https://patchwork.libcamera.org/comment/38029/","msgid":"<20260130140038.GM3374091@killaraus>","date":"2026-01-30T14:00:38","subject":"Re: [PATCH v1 1/7] meson: Drop unnecessary egl, gles feature defines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 29, 2026 at 05:40:26PM +0100, Barnabás Pőcze wrote:\n> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/meson.build | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index d15943586..c6c109a30 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if libegl.found()\n> - config_h.set('HAVE_LIBEGL', 1)\n> -endif\n> -\n> -if libglesv2.found()\n> - config_h.set('HAVE_GLESV2', 1)\n> -endif\n> -\n> if mesa_works\n> libcamera_internal_sources += files([\n> 'egl.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81840C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:00:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39FDE61FCE;\n\tFri, 30 Jan 2026 15:00:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D33D61FC6\n\tfor ;\n\tFri, 30 Jan 2026 15:00:39 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 089937FA;\n\tFri, 30 Jan 2026 15:00:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J4zKzI13\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781601;\n\tbh=7v9AHbUqOpDbLd6b6R285Fbl9G+tsZOmdEri+H1G95I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J4zKzI13pyia4W1yWBvwqOJnrZFika4o7Auwshw9lev+Ofk0hFN84Ye2GK8Uw27Ru\n\tCHGTTiWnE7k62gSeREx17FEtKQ//TogfRCDyLnnT3OBsA+mRT1Yz3+ggQz3CXBEAkr\n\t4r+aV78gLwvcBFB24ep4zCu74c5P8DXY1ia+28h0=","Date":"Fri, 30 Jan 2026 16:00:38 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/7] meson: Drop unnecessary egl, gles feature defines","Message-ID":"<20260130140038.GM3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]