[{"id":38019,"web_url":"https://patchwork.libcamera.org/comment/38019/","msgid":"<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-30T13:07:20","subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Barnabás,\n\nthank you for the cleanup.\n\nBarnabás Pőcze writes:\n\n> There are no other users of `egl.cpp`, so simplify by adding\n> it the sources array at the same time.\n\n\"it to the ...\"?\n\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/meson.build | 3 ---\n> src/libcamera/software_isp/meson.build | 1 +\n> 2 files changed, 1 insertion(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c6c109a30..28ce93de6 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> if mesa_works\n> - libcamera_internal_sources += files([\n> - 'egl.cpp',\n> - ])\n> gles_headless_enabled = true\n> else\n> gles_headless_enabled = false\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index c61ac7d59..a55b76b58 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n> if softisp_enabled and gles_headless_enabled\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> + '../egl.cpp',\n\nShould egl.cpp be moved to this directory then?\n\n> 'debayer_egl.cpp',\n> ])\n> endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF5CCBD78E\n\tfor ;\n\tFri, 30 Jan 2026 13:07:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16B7E61FD2;\n\tFri, 30 Jan 2026 14:07:29 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BF2461F84\n\tfor ;\n\tFri, 30 Jan 2026 14:07:27 +0100 (CET)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-44-v0lsKvTSP7m0Ro84ZQCJxg-1; Fri, 30 Jan 2026 08:07:24 -0500","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-47ee056e5cfso20901235e9.1\n\tfor ;\n\tFri, 30 Jan 2026 05:07:23 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48066c428basm276021815e9.12.2026.01.30.05.07.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jan 2026 05:07:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"DiQbFhte\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769778446;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KFHXxoFt1hd3wQEi0DLxFPn/ogM48dU/Srwc98AUjcY=;\n\tb=DiQbFhteb9bbURnxrtVAMMN8injtM/pDvQFmB8DJdva6ZY5u8kVc1NSgG2xOJy0wseK3Zp\n\t22HHVtEvyV3lXWkX2wjMuWVey8r5hkuExlaKXcXTrW9K+O3MyoKkGq30zx7w5T0g/x3NDT\n\tzqWmhnoc9i3tfwuA+xRK6XYiYI+P9rc=","X-MC-Unique":"v0lsKvTSP7m0Ro84ZQCJxg-1","X-Mimecast-MFC-AGG-ID":"v0lsKvTSP7m0Ro84ZQCJxg_1769778443","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769778442; x=1770383242;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=EAnoh6J1JZW8SFhiqwJBaIuS/7uB7+PWP+tUzfTWFKU=;\n\tb=uMMFjzk7u1bNgmB3OaqIALRrp3pT8Fj5dVkGS7HDWuun09qcQGBSGIwNQmt6+vJPuK\n\tmQt51vPJ4ARAtgHhUiMuV498hauMzh3afm/gmzGkLAwYxITjmhB6Ey6e4fUFoc79nIkn\n\t4W1eThe3+UOHZ7g6JY7ZrnW3UQEn+UUMAfwZwzpfvsKJ+1YEfhkTCIspMxpcg6AEJkur\n\t+tMTI/9nNTnc6feVeF7sjUjO4kdup6CkocHEb5sg0PjdANhPkbLUyzANheylLpok96Qk\n\tZWAeSpqpc987c+OEzp19FHZVrE/6zhNYD439AMtGTThl81yI6dQm1B/JL+ixehK7DL9V\n\te1aQ==","X-Gm-Message-State":"AOJu0YzVE+lu2EjhJ7zKPTJ/F5RtPGQSVHIG5aiaaXr9JmRKPCTf0G32\n\txDddL+yUptLCz7yW8Ti5vINk5pLhzQtRKhudhCDkd2W+ntJVStqNqSbSplVA8NTNz5fJgZkSwd2\n\tjAB6AEF3OCXDtW6+ivj4/TOy9jZZ/Ophwq809ghHvnDJf/7GkM+dc+NAyqZoAMuz+J4PfulaUws\n\tVYdsBevOdtA5mKed+mxh+Re2HeWMqJpUBH6/ZIHdH/Pj9p1qIs0wmX0T4tpag=","X-Gm-Gg":"AZuq6aJ6/S3k1pngUi8X72f/BadkoLTLmdT59ObBnMYIHllOd4C3PQbKWAH+aGkslU1\n\taIWcJS90JpLztIKKI/sGCXxva+B0o/unllPtEggChk+jRPuilhzqK/pM4Zn7bxoxA8xeW9utaZs\n\tzvOrVzXbtVBQ6/z3ZGWtDsQ4wChWeghE8dCLOnnEyYma7bGg9e8itdiuwSK+8mG7/wRIZ24OJkT\n\tiGHjIPn+DIsPAkUxSQTarjclvGcuAfRHSUgYmLugORklSCRhaMsEhcK5xRVTHB6ewH5f+0k5lDy\n\tQ2ocRgXC5UAZSjKIkbv7jw2jiBoBAtC9JuVMb1VEXArL0O0WW1ON6fiLxj8KpwmtKvkl92cSSiB\n\tzMQr3PGTIZ3Ivr45ApdcjXK3hkDGZOctNsRAiXpxl7sMVu3qbDKnTjEUatoY7Y1k=","X-Received":["by 2002:a05:600c:a087:b0:479:35e7:a0e3 with SMTP id\n\t5b1f17b1804b1-482db48f2ccmr35500095e9.30.1769778441993; \n\tFri, 30 Jan 2026 05:07:21 -0800 (PST)","by 2002:a05:600c:a087:b0:479:35e7:a0e3 with SMTP id\n\t5b1f17b1804b1-482db48f2ccmr35499715e9.30.1769778441596; \n\tFri, 30 Jan 2026 05:07:21 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","In-Reply-To":"<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t29 Jan 2026 17:40:27 +0100\")","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>","Date":"Fri, 30 Jan 2026 14:07:20 +0100","Message-ID":"<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Jb5UrRDZJsBYKpnRjQd_5oceVTNxyjmNzzMYFf_e-Mw_1769778443","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38031,"web_url":"https://patchwork.libcamera.org/comment/38031/","msgid":"<20260130140235.GN3374091@killaraus>","date":"2026-01-30T14:02:35","subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 30, 2026 at 02:07:20PM +0100, Milan Zamazal wrote:\n> Hi Barnabás,\n> \n> thank you for the cleanup.\n> \n> Barnabás Pőcze writes:\n> \n> > There are no other users of `egl.cpp`, so simplify by adding\n> > it the sources array at the same time.\n> \n> \"it to the ...\"?\n> \n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/libcamera/meson.build | 3 ---\n> > src/libcamera/software_isp/meson.build | 1 +\n> > 2 files changed, 1 insertion(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index c6c109a30..28ce93de6 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n> > libglesv2 = dependency('glesv2', required : false)\n> > \n> > if mesa_works\n> > - libcamera_internal_sources += files([\n> > - 'egl.cpp',\n> > - ])\n> > gles_headless_enabled = true\n> > else\n> > gles_headless_enabled = false\n> > diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> > index c61ac7d59..a55b76b58 100644\n> > --- a/src/libcamera/software_isp/meson.build\n> > +++ b/src/libcamera/software_isp/meson.build\n> > @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n> > if softisp_enabled and gles_headless_enabled\n> > config_h.set('HAVE_DEBAYER_EGL', 1)\n> > libcamera_internal_sources += files([\n> > + '../egl.cpp',\n> \n> Should egl.cpp be moved to this directory then?\n\nIn the not too distant future I would like to refactor the code to\ncreate a GPU processing class that will be available to other pipeline\nhandlers, independently from the soft ISP. At that point egl.cpp will\nprobably go to src/libcamera/gpu/. I don't mind where we store it for\nthe time being.\n\n> > 'debayer_egl.cpp',\n> > ])\n> > endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36553C3226\n\tfor ;\n\tFri, 30 Jan 2026 14:02:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E412061FCE;\n\tFri, 30 Jan 2026 15:02:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AB8261FC6\n\tfor ;\n\tFri, 30 Jan 2026 15:02:36 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0E24455C;\n\tFri, 30 Jan 2026 15:01:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Po9v949h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769781718;\n\tbh=kwKaJB66aS2u6fKmZXTPc5X74NDLskygKRy4nrs8JJo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Po9v949hWhA9aw3W/2fhIVmq8skG4fA68H4U2liXfntQq2MqrN6DPim8N7i4/kYg5\n\tI97bSe6NDMQRha5xk1b81lfvF7Cobj/eyaQMVGBZ4cc7vGJdNRa3okzYWF2r2tNsyL\n\tplI5ecwtH52OehG48CeCKKlFJgWgC2frqeyO7lFY=","Date":"Fri, 30 Jan 2026 16:02:35 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","Message-ID":"<20260130140235.GN3374091@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>\n\t<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38089,"web_url":"https://patchwork.libcamera.org/comment/38089/","msgid":"<0fb563a0-d617-460a-89ca-38b01a55cedb@ideasonboard.com>","date":"2026-02-05T10:33:18","subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 30. 15:02 keltezéssel, Laurent Pinchart írta:\n> On Fri, Jan 30, 2026 at 02:07:20PM +0100, Milan Zamazal wrote:\n>> Hi Barnabás,\n>>\n>> thank you for the cleanup.\n>>\n>> Barnabás Pőcze writes:\n>>\n>>> There are no other users of `egl.cpp`, so simplify by adding\n>>> it the sources array at the same time.\n>>\n>> \"it to the ...\"?\n>>\n>>> Signed-off-by: Barnabás Pőcze \n>>> ---\n>>> src/libcamera/meson.build | 3 ---\n>>> src/libcamera/software_isp/meson.build | 1 +\n>>> 2 files changed, 1 insertion(+), 3 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>>> index c6c109a30..28ce93de6 100644\n>>> --- a/src/libcamera/meson.build\n>>> +++ b/src/libcamera/meson.build\n>>> @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n>>> libglesv2 = dependency('glesv2', required : false)\n>>> \n>>> if mesa_works\n>>> - libcamera_internal_sources += files([\n>>> - 'egl.cpp',\n>>> - ])\n>>> gles_headless_enabled = true\n>>> else\n>>> gles_headless_enabled = false\n>>> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n>>> index c61ac7d59..a55b76b58 100644\n>>> --- a/src/libcamera/software_isp/meson.build\n>>> +++ b/src/libcamera/software_isp/meson.build\n>>> @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n>>> if softisp_enabled and gles_headless_enabled\n>>> config_h.set('HAVE_DEBAYER_EGL', 1)\n>>> libcamera_internal_sources += files([\n>>> + '../egl.cpp',\n>>\n>> Should egl.cpp be moved to this directory then?\n> \n> In the not too distant future I would like to refactor the code to\n> create a GPU processing class that will be available to other pipeline\n> handlers, independently from the soft ISP. At that point egl.cpp will\n> probably go to src/libcamera/gpu/. I don't mind where we store it for\n> the time being.\n\nI went with the simplest option, that is, not moving egl.cpp because then the header\nfile would also need to be moved, which brings more changes with it. Nonetheless, there is\nan argument to be made for moving it: it is only used by the software_isp parts.\nSo I can move it if that seems best for now?\n\n\n> \n>>> 'debayer_egl.cpp',\n>>> ])\n>>> endif\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6FD9ABD78E\n\tfor ;\n\tThu, 5 Feb 2026 10:33:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6911C62055;\n\tThu, 5 Feb 2026 11:33:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9325C61F84\n\tfor ;\n\tThu, 5 Feb 2026 11:33:22 +0100 (CET)","from [192.168.33.53] (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5CD6227;\n\tThu, 5 Feb 2026 11:32:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uZQbVHIq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770287559;\n\tbh=IQSK7wwPwoNOVeXI0USXnMZRYPoKk24vbZHrLMNXKww=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=uZQbVHIqCuJF46n7HKR/CGgMgZIkBx0DzUWZ6YszMmqnwhhzWT6m+a4NEUlNVGv7u\n\tZ+K6lD/WniiWcIl9BSzJaPj4xNjREsAjcbY+7NNKyTD8snbcA1TKKnFcCWjB2fJyBU\n\ts87pEGmSbO+0Bec1f2/lUpj/27WK0c4X9oPQ23Ks=","Message-ID":"<0fb563a0-d617-460a-89ca-38b01a55cedb@ideasonboard.com>","Date":"Thu, 5 Feb 2026 11:33:18 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>\n\t<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<20260130140235.GN3374091@killaraus>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260130140235.GN3374091@killaraus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38092,"web_url":"https://patchwork.libcamera.org/comment/38092/","msgid":"<20260205113813.GG156228@killaraus>","date":"2026-02-05T11:38:13","subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Feb 05, 2026 at 11:33:18AM +0100, Barnabás Pőcze wrote:\n> 2026. 01. 30. 15:02 keltezéssel, Laurent Pinchart írta:\n> > On Fri, Jan 30, 2026 at 02:07:20PM +0100, Milan Zamazal wrote:\n> >> Hi Barnabás,\n> >>\n> >> thank you for the cleanup.\n> >>\n> >> Barnabás Pőcze writes:\n> >>\n> >>> There are no other users of `egl.cpp`, so simplify by adding\n> >>> it the sources array at the same time.\n> >>\n> >> \"it to the ...\"?\n> >>\n> >>> Signed-off-by: Barnabás Pőcze \n> >>> ---\n> >>> src/libcamera/meson.build | 3 ---\n> >>> src/libcamera/software_isp/meson.build | 1 +\n> >>> 2 files changed, 1 insertion(+), 3 deletions(-)\n> >>>\n> >>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> >>> index c6c109a30..28ce93de6 100644\n> >>> --- a/src/libcamera/meson.build\n> >>> +++ b/src/libcamera/meson.build\n> >>> @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n> >>> libglesv2 = dependency('glesv2', required : false)\n> >>> \n> >>> if mesa_works\n> >>> - libcamera_internal_sources += files([\n> >>> - 'egl.cpp',\n> >>> - ])\n> >>> gles_headless_enabled = true\n> >>> else\n> >>> gles_headless_enabled = false\n> >>> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> >>> index c61ac7d59..a55b76b58 100644\n> >>> --- a/src/libcamera/software_isp/meson.build\n> >>> +++ b/src/libcamera/software_isp/meson.build\n> >>> @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n> >>> if softisp_enabled and gles_headless_enabled\n> >>> config_h.set('HAVE_DEBAYER_EGL', 1)\n> >>> libcamera_internal_sources += files([\n> >>> + '../egl.cpp',\n> >>\n> >> Should egl.cpp be moved to this directory then?\n> > \n> > In the not too distant future I would like to refactor the code to\n> > create a GPU processing class that will be available to other pipeline\n> > handlers, independently from the soft ISP. At that point egl.cpp will\n> > probably go to src/libcamera/gpu/. I don't mind where we store it for\n> > the time being.\n> \n> I went with the simplest option, that is, not moving egl.cpp because then the header\n> file would also need to be moved, which brings more changes with it. Nonetheless, there is\n> an argument to be made for moving it: it is only used by the software_isp parts.\n> So I can move it if that seems best for now?\n\nUp to you.\n\n> >>> 'debayer_egl.cpp',\n> >>> ])\n> >>> endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C028C31E9\n\tfor ;\n\tThu, 5 Feb 2026 11:38:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8562F62056;\n\tThu, 5 Feb 2026 12:38:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EC9162010\n\tfor ;\n\tThu, 5 Feb 2026 12:38:15 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5CFD7D0;\n\tThu, 5 Feb 2026 12:37:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hv5ukDmR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770291452;\n\tbh=D7Vyi6v70sIgm7mJ77zSe5gthncJVKvBXJSzYXjrHeU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hv5ukDmRakyEZNWpuU7XRuyOpJbKgKBHuShEOx8VxTeJw+zS3lm8u5yuXZ5riHK3o\n\th7QVnTfRXlxuoL7Jod1cRvDBKUoqMpiTNOvGLZj3lHaCyLz2Ec4e6YpNGjCyD8RAGz\n\tuAxIvHxhgDUJp9akCUFDiypmAhUVJOveRPbjIsUs=","Date":"Thu, 5 Feb 2026 13:38:13 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","Message-ID":"<20260205113813.GG156228@killaraus>","References":"<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>\n\t<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>\n\t<85ecn7uu47.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<20260130140235.GN3374091@killaraus>\n\t<0fb563a0-d617-460a-89ca-38b01a55cedb@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<0fb563a0-d617-460a-89ca-38b01a55cedb@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]