[{"id":38012,"web_url":"https://patchwork.libcamera.org/comment/38012/","msgid":"<20260129105720.GD3317328@killaraus>","date":"2026-01-29T10:57:20","subject":"Re: [PATCH v1] libcamera: base: Add missing `private.h` includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 29, 2026 at 11:29:11AM +0100, Barnabás Pőcze wrote:\n> Certain private header files failed to include `private.h`, fix that.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/memfd.h | 2 ++\n> include/libcamera/base/regex.h | 2 ++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> index 705d9929e..5ffa0f227 100644\n> --- a/include/libcamera/base/memfd.h\n> +++ b/include/libcamera/base/memfd.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> #include \n> #include \n> \n> diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h\n> index 1ae21c1f9..45f4da8cb 100644\n> --- a/include/libcamera/base/regex.h\n> +++ b/include/libcamera/base/regex.h\n> @@ -5,6 +5,8 @@\n> * std::regex wrapper for gcc\n> */\n> \n> +#include \n> +\n> #pragma GCC diagnostic push\n> #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__\n> #pragma GCC diagnostic ignored \"-Wmaybe-uninitialized\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A06DFC3226\n\tfor ;\n\tThu, 29 Jan 2026 10:57:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C8D061FD1;\n\tThu, 29 Jan 2026 11:57:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1FA2615B2\n\tfor ;\n\tThu, 29 Jan 2026 11:57:21 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0F8F21AED; \n\tThu, 29 Jan 2026 11:56:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y2zukuEk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769684204;\n\tbh=CvEBfZR53R/tbKkfBMJMGuzqlRh65XWr8O2UFIep8Qc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y2zukuEkZi9DefiS/nfCrEgqUDAC9Aqf5MOr4WTPT+LXXqb+L8R7Ax1wMWDEhLbs1\n\t6PRVBM1ErXrXZE1N80DlvXWkbiBIhjvnK2Y5SsmXDR4FAXtVVx261C0dMrm0uZDQ29\n\tfo+dpCuGK0LWLe/9VRbmqfKn/VHPrz1S31/81KnI=","Date":"Thu, 29 Jan 2026 12:57:20 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: base: Add missing `private.h` includes","Message-ID":"<20260129105720.GD3317328@killaraus>","References":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38015,"web_url":"https://patchwork.libcamera.org/comment/38015/","msgid":"<176969713773.4065899.15088509395608824858@ping.linuxembedded.co.uk>","date":"2026-01-29T14:32:17","subject":"Re: [PATCH v1] libcamera: base: Add missing `private.h` includes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-29 10:29:11)\n> Certain private header files failed to include `private.h`, fix that.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/base/memfd.h | 2 ++\n> include/libcamera/base/regex.h | 2 ++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> index 705d9929e..5ffa0f227 100644\n> --- a/include/libcamera/base/memfd.h\n> +++ b/include/libcamera/base/memfd.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> #include \n> #include \n> \n> diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h\n> index 1ae21c1f9..45f4da8cb 100644\n> --- a/include/libcamera/base/regex.h\n> +++ b/include/libcamera/base/regex.h\n> @@ -5,6 +5,8 @@\n> * std::regex wrapper for gcc\n> */\n> \n> +#include \n> +\n> #pragma GCC diagnostic push\n> #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__\n> #pragma GCC diagnostic ignored \"-Wmaybe-uninitialized\"\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48AD9BD78E\n\tfor ;\n\tThu, 29 Jan 2026 14:32:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8615C61FC9;\n\tThu, 29 Jan 2026 15:32:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67017615B2\n\tfor ;\n\tThu, 29 Jan 2026 15:32:21 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81E131661;\n\tThu, 29 Jan 2026 15:31:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tyCzBaa7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769697103;\n\tbh=3FRJCVn6r2x7G6q1cesq+mP1dXBkj/17gzyX1iL6BHE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=tyCzBaa7ZunfLGJsSImgiOtjirQsM9keW8x2nqvEylIKaUqD5H5w8cqNT6MCH/ma8\n\tn4VoU9NR83Fy0s/Uisd+DChjfScPxQsMBGNhaPxYy34ZaA9fpyqYFPrw76KsA8Laib\n\tcAd0Lnzazmdh1jLVVBbctccGrZpbsDlTPioNg0dw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","References":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: base: Add missing `private.h` includes","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 29 Jan 2026 14:32:17 +0000","Message-ID":"<176969713773.4065899.15088509395608824858@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]