{"id":26037,"url":"https://patchwork.libcamera.org/api/patches/26037/?format=json","web_url":"https://patchwork.libcamera.org/patch/26037/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","date":"2026-01-29T10:29:11","name":"[v1] libcamera: base: Add missing `private.h` includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"56674c50ffe3d2865553a0df06e426c06d6f1d90","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26037/mbox/","series":[{"id":5754,"url":"https://patchwork.libcamera.org/api/series/5754/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5754","date":"2026-01-29T10:29:11","name":"[v1] libcamera: base: Add missing `private.h` includes","version":1,"mbox":"https://patchwork.libcamera.org/series/5754/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26037/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26037/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22B17C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Jan 2026 10:29:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20A5661FD1;\n\tThu, 29 Jan 2026 11:29:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98372615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Jan 2026 11:29:15 +0100 (CET)","from pb-laptop.local (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D39586A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Jan 2026 11:28:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YF6Uuqa5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769682517;\n\tbh=YA5ZgJaCJ6kqquF8M4PjD9YJHxVw5r6nf4btG8Rh/xw=;\n\th=From:To:Subject:Date:From;\n\tb=YF6Uuqa5u9YAm+wDcob3L5FFgeTyiB/+d7/nGZoMe23pEq1zZ+F/SbXsGkiNQ2jV4\n\tpK+QMwuFESRXQbmhAVt4nppN4vjIdK5o6TCb58K2HCPtp9Fdek/Hl2ie66lB0eHpb9\n\tbK7oUE3Yuc4gcnLQ7zWwZHFPfSgE+Rty5Kc+z6Jk=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: base: Add missing `private.h` includes","Date":"Thu, 29 Jan 2026 11:29:11 +0100","Message-ID":"<20260129102911.1200364-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Certain private header files failed to include `private.h`, fix that.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/memfd.h | 2 ++\n include/libcamera/base/regex.h | 2 ++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\nindex 705d9929e..5ffa0f227 100644\n--- a/include/libcamera/base/memfd.h\n+++ b/include/libcamera/base/memfd.h\n@@ -7,6 +7,8 @@\n \n #pragma once\n \n+#include <libcamera/base/private.h>\n+\n #include <libcamera/base/flags.h>\n #include <libcamera/base/unique_fd.h>\n \ndiff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h\nindex 1ae21c1f9..45f4da8cb 100644\n--- a/include/libcamera/base/regex.h\n+++ b/include/libcamera/base/regex.h\n@@ -5,6 +5,8 @@\n  * std::regex wrapper for gcc\n  */\n \n+#include <libcamera/base/private.h>\n+\n #pragma GCC diagnostic push\n #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__\n #pragma GCC diagnostic ignored \"-Wmaybe-uninitialized\"\n","prefixes":["v1"]}