[{"id":38290,"web_url":"https://patchwork.libcamera.org/comment/38290/","msgid":"<177194902281.1513537.4052339544109848651@t16>","date":"2026-02-24T16:03:42","subject":"Re: [PATCH v6 5/8] libcamera: camera_manager: Add LayerManager","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Paul,\n\nQuoting Paul Elder (2026-01-29 08:28:11)\n> Add to the CameraManager a LayerManager member. This allows us to have\n> one LayerManager that handles loading all the layer shared objects, and\n> then each Camera can access the layer via the LayerManager through the\n> CameraManager.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> \n> ---\n> No change in v6\n> \n> No change in v5\n> \n> Changes in v4:\n> - Put LayerManager directly in CameraManager, as opposed to a unique\n> pointer\n> \n> No change in v3\n> \n> New in v2\n> ---\n> include/libcamera/internal/camera_manager.h | 3 +++\n> src/libcamera/camera_manager.cpp | 1 +\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> index 755928ce60a5..cc3ede02507f 100644\n> --- a/include/libcamera/internal/camera_manager.h\n> +++ b/include/libcamera/internal/camera_manager.h\n> @@ -19,6 +19,7 @@\n> #include \n> \n> #include \"libcamera/internal/global_configuration.h\"\n> +#include \"libcamera/internal/layer_manager.h\"\n> #include \"libcamera/internal/process.h\"\n> \n> namespace libcamera {\n> @@ -45,6 +46,7 @@ public:\n> }\n> \n> IPAManager *ipaManager() const { return ipaManager_.get(); }\n> + const LayerManager *layerManager() const { return &layerManager_; }\n> \n> protected:\n> void run() override;\n> @@ -71,6 +73,7 @@ private:\n> std::unique_ptr enumerator_;\n> \n> std::unique_ptr ipaManager_;\n> + LayerManager layerManager_;\n\nLooks good to me!\n\nReviewed-by: Isaac Scott \n\nBest wishes,\nIsaac\n\n> \n> const GlobalConfiguration configuration_;\n> };\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 23185467ba02..554cd935339a 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -16,6 +16,7 @@\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/global_configuration.h\"\n> +#include \"libcamera/internal/layer_manager.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> \n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21D87C0DA4\n\tfor ;\n\tTue, 24 Feb 2026 16:03:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBA25622A1;\n\tTue, 24 Feb 2026 17:03:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96D1562080\n\tfor ;\n\tTue, 24 Feb 2026 17:03:45 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7D1FAB4;\n\tTue, 24 Feb 2026 17:02:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jxIAd1fu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771948968;\n\tbh=y68PRYLxQ3BAIRmuBkEupPGOi/wzjISKZEtKy2TCWNc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jxIAd1fuirtcsK2y0Nt7DibaxEoDIriBkJrBeh4+G1BNP7GWnPPVQPHY2AzPSnXjt\n\t6n0eUqp910secMun/eY9YKZqSJP/nTDMPPa625pjx6V54O3rhuk6Kw5W4RIO3NJI40\n\tWRnxm1lr6FTmS8bdVASt0GqQPzulyBOXApz7M9HE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260129082814.1777779-6-paul.elder@ideasonboard.com>","References":"<20260129082814.1777779-1-paul.elder@ideasonboard.com>\n\t<20260129082814.1777779-6-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v6 5/8] libcamera: camera_manager: Add LayerManager","From":"Isaac Scott ","Cc":"Paul Elder ,\n\tKieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 24 Feb 2026 16:03:42 +0000","Message-ID":"<177194902281.1513537.4052339544109848651@t16>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]