{"id":26025,"url":"https://patchwork.libcamera.org/api/patches/26025/?format=json","web_url":"https://patchwork.libcamera.org/patch/26025/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128-sklug-lsc-resampling-v2-dev-v6-14-af7d95f03d22@ideasonboard.com>","date":"2026-01-28T16:00:31","name":"[v6,14/15] libcamera: control_ids: Introduce LensShadingCorrectionEnable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"160857b2380d199ac1b3ee8976dbb3a6f197fdd9","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26025/mbox/","series":[{"id":5751,"url":"https://patchwork.libcamera.org/api/series/5751/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5751","date":"2026-01-28T16:00:17","name":"Add resampling support for polynomial LSC data","version":6,"mbox":"https://patchwork.libcamera.org/series/5751/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26025/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26025/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 034BAC3200\n\tfor ;\n\tWed, 28 Jan 2026 16:01:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B94AE61FDE;\n\tWed, 28 Jan 2026 17:01:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9F9361FD3\n\tfor ;\n\tWed, 28 Jan 2026 17:01:05 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1a60:e70f:ec38:13a9])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A735D27F9; \n\tWed, 28 Jan 2026 17:00:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SnZvPjLj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769616028;\n\tbh=39NlPgCqW5Nob5gyChWODILLQLQ7MiOEgExqaUFdo7A=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=SnZvPjLjkdYUWNzSWNAcCj+J31YYfOMV4GO5Fg+iY0v/cNGaTZFISatJruuyzD9D3\n\tFokFkX//76bmbqH3XmYrkVTZEaHul71pcBpKFsgTFxUTS5ezN11RQfxPfpli3ftKW4\n\tgHUHU7JO9Gt9baJFkaovOgTxx5hSBG8F4YQ4Nx1Y=","From":"Stefan Klug ","Date":"Wed, 28 Jan 2026 17:00:31 +0100","Subject":"[PATCH v6 14/15] libcamera: control_ids: Introduce\n\tLensShadingCorrectionEnable","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260128-sklug-lsc-resampling-v2-dev-v6-14-af7d95f03d22@ideasonboard.com>","References":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","In-Reply-To":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , \n\tJacopo Mondi , \n\tKieran Bingham , \n\tLaurent Pinchart ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce a LensShadingCorrectionEnable control to enable and disable\nLSC. This is useful to assess the working and quality of the lens\nshading correction at runtime.\n\nWhile at it drop the reference to the tuning file in the description of\nthe LensDewarpEnable control, as that information doesn't belong to the\ncontrols.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\n\nChanges in v6:\n- Improved the control description\n- Dropped the reference to the tuning file\n- Collected tags\n\nChanges in v5:\n- Readd this patch to have a separate patch for the control id\n- Dropped android specific changes\n\nChanges in v2:\n- Renamed LensShadingEnable to LensShadingCorrectionEnable\n- Fixed android code to properly handle the boolean value\n- Added \"only if tuned\" info sentence to the control description\n---\n src/libcamera/control_ids_core.yaml | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 8e99bd84825f6060dbc323be3f4b0cd6283e0942..f26a1b1b08bd1684cb76d75ecc32bdb9f8b0f6e5 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1353,7 +1353,12 @@ controls:\n type: bool\n direction: inout\n description: |\n- Enable or disable lens dewarping. This control is only available if lens\n- dewarp parameters are configured in the tuning file.\n+ Enable or disable lens dewarping.\n+\n+ - LensShadingCorrectionEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable the lens shading correction.\n \n ...\n","prefixes":["v6","14/15"]}