{"id":26017,"url":"https://patchwork.libcamera.org/api/patches/26017/?format=json","web_url":"https://patchwork.libcamera.org/patch/26017/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128-sklug-lsc-resampling-v2-dev-v6-6-af7d95f03d22@ideasonboard.com>","date":"2026-01-28T16:00:23","name":"[v6,06/15] ipa: rkisp1: lsc: Rename res to samples","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7d680e9facf116abc0cb0f0374c98d165b8b7f24","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26017/mbox/","series":[{"id":5751,"url":"https://patchwork.libcamera.org/api/series/5751/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5751","date":"2026-01-28T16:00:17","name":"Add resampling support for polynomial LSC data","version":6,"mbox":"https://patchwork.libcamera.org/series/5751/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26017/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26017/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BD5AC3200\n\tfor ;\n\tWed, 28 Jan 2026 16:00:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB15061FDF;\n\tWed, 28 Jan 2026 17:00:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AFC561FDC\n\tfor ;\n\tWed, 28 Jan 2026 17:00:42 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1a60:e70f:ec38:13a9])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 65330201D; \n\tWed, 28 Jan 2026 17:00:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VJrUIpBG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769616005;\n\tbh=bUAx3KWol+8DHvGGtMRVj9JEIzD3b8KDiHv8Y1padcU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=VJrUIpBGYavDPezW6hhiLrQNdUyUCQ4GeUX3VVZ+MRIrW0o1CUY7OecDHg6mMVut+\n\tTPD2d34aDSy7MNiErZjdMmvu39w6CXLhKx5O74PdrjUWRGwRrC7KfG2IwdDfQ7Adad\n\tM81i8HpIKuEiYlBEf0aFb1Zzz9i90YvwmAShhzT8=","From":"Stefan Klug ","Date":"Wed, 28 Jan 2026 17:00:23 +0100","Subject":"[PATCH v6 06/15] ipa: rkisp1: lsc: Rename res to samples","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260128-sklug-lsc-resampling-v2-dev-v6-6-af7d95f03d22@ideasonboard.com>","References":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","In-Reply-To":"<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ,\n\tRui Wang ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename res to samples to better describe the intent. This was noted in\nreview after the series was merged.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Barnabás Pőcze \nReviewed-by: Rui Wang \n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 972bb57f4a8385b29fa97e7ac3c8025cf1f9980e..4b7aaaf05abd7e56231bb231d36ad07778f93540 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -166,12 +166,12 @@ private:\n \t\tdouble y0 = cropRectangle_.y / m;\n \t\tdouble w = cropRectangle_.width / m;\n \t\tdouble h = cropRectangle_.height / m;\n-\t\tstd::vector res;\n+\t\tstd::vector samples;\n \n \t\tASSERT(xSizes_.size() * 2 + 1 == k);\n \t\tASSERT(ySizes_.size() * 2 + 1 == k);\n \n-\t\tres.reserve(k * k);\n+\t\tsamples.reserve(k * k);\n \n \t\tstd::vector xPos(sizesListToPositions(xSizes_));\n \t\tstd::vector yPos(sizesListToPositions(ySizes_));\n@@ -189,10 +189,10 @@ private:\n \t\t\t\t\tpoly.sampleAtNormalizedPixelPos(xp, yp) *\n \t\t\t\t\t1024);\n \t\t\t\tv = std::min(std::max(v, 1024), 4095);\n-\t\t\t\tres.push_back(v);\n+\t\t\t\tsamples.push_back(v);\n \t\t\t}\n \t\t}\n-\t\treturn res;\n+\t\treturn samples;\n \t}\n \n \tSize sensorSize_;\n","prefixes":["v6","06/15"]}