[{"id":37990,"web_url":"https://patchwork.libcamera.org/comment/37990/","msgid":"<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>","date":"2026-01-28T12:53:46","subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 28. 13:40 keltezéssel, Kieran Bingham írta:\n> GCC-16 has updated the warnings enabled and now includes\n> -Wsfinae-incomplete triggering breakage in the included headers from\n> Qt6:\n> \n> /usr/include/qt6/QtCore/qregularexpression.h:31:21: error: defining ‘QRegularExpression’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=]\n> \n> This is a Qt header issue outside of libcamera’s control. Disable the\n> warning for qcam to restore buildability with newer GCC versions.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n> \n> I see there's a conditional section to only disable some warnings for\n> specific versions, but I have no indication here as to when or if this\n> warning will be fixed - so I've chosen to just put it directly into the\n> main flags to disable the warning.\n> \n> It's out side of our control, and doesn't impact what we can do.\n> \n>   src/apps/qcam/meson.build | 1 +\n>   1 file changed, 1 insertion(+)\n> \n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index 33600095ff9d..8eb815eed863 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -40,6 +40,7 @@ qt6_cpp_args = [\n>       apps_cpp_args,\n>       '-DQT_NO_KEYWORDS',\n>       '-Wno-extra-semi',\n> +    '-Wno-sfinae-incomplete',\n>   ]\n\nMaybe a link to https://qt-project.atlassian.net/browse/QTBUG-143470 or similar could be added.\nOtherwise I don't really see a reasonable option other than disabling the warning.\nI also checked if gcc fails when disabling unknown warnings, but those appear to be ignored.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   \n>   # gcc 12 and 13 output a false positive variable shadowing warning with Qt","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5175C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 12:53:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FEED61FD0;\n\tWed, 28 Jan 2026 13:53:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E558B61FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 13:53:49 +0100 (CET)","from [192.168.33.40] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08C29E70;\n\tWed, 28 Jan 2026 13:53:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gCbVDflI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769604793;\n\tbh=skN+pdGluIyxVztkLXZKojdYOiDSbZunTVYwpawrOL4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=gCbVDflIyyD7Osk1jyTDz7s+BxO21wrn85fO92OrTuCKvd41pEioFV6riRePcJaY7\n\tl41KBPo0xEKdSKeN6+SRaeeXEf0UsP4Islfy3yIX6EAWE7vBiz1kwCZ+xQ3QhZfXOq\n\twM1HMG4sL2AzdV3fSpzbXQR2eijE5Eu5nSG1zKnA=","Message-ID":"<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>","Date":"Wed, 28 Jan 2026 13:53:46 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20260128124011.104617-1-kieran.bingham@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260128124011.104617-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37992,"web_url":"https://patchwork.libcamera.org/comment/37992/","msgid":"<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","date":"2026-01-28T13:08:13","subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-28 12:53:46)\n> 2026. 01. 28. 13:40 keltezéssel, Kieran Bingham írta:\n> > GCC-16 has updated the warnings enabled and now includes\n> > -Wsfinae-incomplete triggering breakage in the included headers from\n> > Qt6:\n> > \n> > /usr/include/qt6/QtCore/qregularexpression.h:31:21: error: defining ‘QRegularExpression’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=]\n> > \n> > This is a Qt header issue outside of libcamera’s control. Disable the\n> > warning for qcam to restore buildability with newer GCC versions.\n> > \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > ---\n> > \n> > I see there's a conditional section to only disable some warnings for\n> > specific versions, but I have no indication here as to when or if this\n> > warning will be fixed - so I've chosen to just put it directly into the\n> > main flags to disable the warning.\n> > \n> > It's out side of our control, and doesn't impact what we can do.\n> > \n> >   src/apps/qcam/meson.build | 1 +\n> >   1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > index 33600095ff9d..8eb815eed863 100644\n> > --- a/src/apps/qcam/meson.build\n> > +++ b/src/apps/qcam/meson.build\n> > @@ -40,6 +40,7 @@ qt6_cpp_args = [\n> >       apps_cpp_args,\n> >       '-DQT_NO_KEYWORDS',\n> >       '-Wno-extra-semi',\n> > +    '-Wno-sfinae-incomplete',\n> >   ]\n> \n> Maybe a link to https://qt-project.atlassian.net/browse/QTBUG-143470 or similar could be added.\n> Otherwise I don't really see a reasonable option other than disabling the warning.\n> I also checked if gcc fails when disabling unknown warnings, but those appear to be ignored.\n\nOhh thanks - your search-fu was better than mine - I missed that.!\n\nThis patch doesn't close that bug, so I don't think Closes: is\nappropriate so I wonder if this is :\n\nLink: https://qt-project.atlassian.net/browse/QTBUG-143470\nor \nBug: https://qt-project.atlassian.net/browse/QTBUG-143470\n\n\n> \n> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> \n> \n> >   \n> >   # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCA9DC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 13:08:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E83861FC9;\n\tWed, 28 Jan 2026 14:08:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6175461FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 14:08:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E90DC6F;\n\tWed, 28 Jan 2026 14:07:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uIHfERWm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769605659;\n\tbh=F9RWDI6TiAPGFldCFxiDBAThZkr9zbTglQu9OiL27lA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=uIHfERWm6Qapinke4bwupSWh13B1BiCTFqXPXuyVDReQeXCCl6DopixKTfEQTTn4z\n\t199BuQhj9oZVR0iXBpLhukH5Mzkt5Atwxh+XHUWQH75Umfjbux2uAUxKHmGsn4H/ZM\n\tzU8rum63FkJQIqHEM/638j5GaaCRUec1c3xQv6Yc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>","References":"<20260128124011.104617-1-kieran.bingham@ideasonboard.com>\n\t<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>","Subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Wed, 28 Jan 2026 13:08:13 +0000","Message-ID":"<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37993,"web_url":"https://patchwork.libcamera.org/comment/37993/","msgid":"<4e8ed1e0-68f6-4514-85d5-062ad3e08b03@ideasonboard.com>","date":"2026-01-28T13:10:43","subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 28. 14:08 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2026-01-28 12:53:46)\n>> 2026. 01. 28. 13:40 keltezéssel, Kieran Bingham írta:\n>>> GCC-16 has updated the warnings enabled and now includes\n>>> -Wsfinae-incomplete triggering breakage in the included headers from\n>>> Qt6:\n>>>\n>>> /usr/include/qt6/QtCore/qregularexpression.h:31:21: error: defining ‘QRegularExpression’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=]\n>>>\n>>> This is a Qt header issue outside of libcamera’s control. Disable the\n>>> warning for qcam to restore buildability with newer GCC versions.\n>>>\n>>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>> ---\n>>>\n>>> I see there's a conditional section to only disable some warnings for\n>>> specific versions, but I have no indication here as to when or if this\n>>> warning will be fixed - so I've chosen to just put it directly into the\n>>> main flags to disable the warning.\n>>>\n>>> It's out side of our control, and doesn't impact what we can do.\n>>>\n>>>    src/apps/qcam/meson.build | 1 +\n>>>    1 file changed, 1 insertion(+)\n>>>\n>>> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n>>> index 33600095ff9d..8eb815eed863 100644\n>>> --- a/src/apps/qcam/meson.build\n>>> +++ b/src/apps/qcam/meson.build\n>>> @@ -40,6 +40,7 @@ qt6_cpp_args = [\n>>>        apps_cpp_args,\n>>>        '-DQT_NO_KEYWORDS',\n>>>        '-Wno-extra-semi',\n>>> +    '-Wno-sfinae-incomplete',\n>>>    ]\n>>\n>> Maybe a link to https://qt-project.atlassian.net/browse/QTBUG-143470 or similar could be added.\n>> Otherwise I don't really see a reasonable option other than disabling the warning.\n>> I also checked if gcc fails when disabling unknown warnings, but those appear to be ignored.\n> \n> Ohh thanks - your search-fu was better than mine - I missed that.!\n> \n> This patch doesn't close that bug, so I don't think Closes: is\n> appropriate so I wonder if this is :\n> \n> Link: https://qt-project.atlassian.net/browse/QTBUG-143470\n> or\n> Bug: https://qt-project.atlassian.net/browse/QTBUG-143470\n\n\"Bug\" is no longer accepted by checkstyle.py as far as I know, so that leaves \"Link\".\n\n\n> \n> \n>>\n>> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>>\n>>\n>>>    \n>>>    # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 928A0C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 13:10:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE16B61FC5;\n\tWed, 28 Jan 2026 14:10:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1655D61FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 14:10:47 +0100 (CET)","from [192.168.33.40] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09A563A2;\n\tWed, 28 Jan 2026 14:10:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P2+uulet\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769605810;\n\tbh=/Q4xXeqH5vUKxP83/s9HqmTYnxYeym9DYHoYtvQiegw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=P2+uuletOxp6ZazGuXOwf1yyXgotOqD01UKRP5+T472p7Lr6P4XFmU2GEXi5OamT4\n\tQ0Q+WvNosdTdQ4rt8solZTmDvrdbsxYJ6vLclonHC9+e3M1jUxVaofhsB49s15GesM\n\tP00VgpPy6OSnbx+u+eSgPhU9VOmj51Bxvm+CvAFI=","Message-ID":"<4e8ed1e0-68f6-4514-85d5-062ad3e08b03@ideasonboard.com>","Date":"Wed, 28 Jan 2026 14:10:43 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20260128124011.104617-1-kieran.bingham@ideasonboard.com>\n\t<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>\n\t<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37994,"web_url":"https://patchwork.libcamera.org/comment/37994/","msgid":"<20260128131534.GB3210848@killaraus>","date":"2026-01-28T13:15:34","subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jan 28, 2026 at 01:08:13PM +0000, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2026-01-28 12:53:46)\n> > 2026. 01. 28. 13:40 keltezéssel, Kieran Bingham írta:\n> > > GCC-16 has updated the warnings enabled and now includes\n> > > -Wsfinae-incomplete triggering breakage in the included headers from\n> > > Qt6:\n> > > \n> > > /usr/include/qt6/QtCore/qregularexpression.h:31:21: error: defining ‘QRegularExpression’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=]\n> > > \n> > > This is a Qt header issue outside of libcamera’s control. Disable the\n> > > warning for qcam to restore buildability with newer GCC versions.\n> > > \n> > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > ---\n> > > \n> > > I see there's a conditional section to only disable some warnings for\n> > > specific versions, but I have no indication here as to when or if this\n> > > warning will be fixed - so I've chosen to just put it directly into the\n> > > main flags to disable the warning.\n> > > \n> > > It's out side of our control, and doesn't impact what we can do.\n> > > \n> > >   src/apps/qcam/meson.build | 1 +\n> > >   1 file changed, 1 insertion(+)\n> > > \n> > > diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> > > index 33600095ff9d..8eb815eed863 100644\n> > > --- a/src/apps/qcam/meson.build\n> > > +++ b/src/apps/qcam/meson.build\n> > > @@ -40,6 +40,7 @@ qt6_cpp_args = [\n> > >       apps_cpp_args,\n> > >       '-DQT_NO_KEYWORDS',\n> > >       '-Wno-extra-semi',\n> > > +    '-Wno-sfinae-incomplete',\n> > >   ]\n> > \n> > Maybe a link to https://qt-project.atlassian.net/browse/QTBUG-143470 or similar could be added.\n> > Otherwise I don't really see a reasonable option other than disabling the warning.\n> > I also checked if gcc fails when disabling unknown warnings, but those appear to be ignored.\n> \n> Ohh thanks - your search-fu was better than mine - I missed that.!\n> \n> This patch doesn't close that bug, so I don't think Closes: is\n> appropriate so I wonder if this is :\n> \n> Link: https://qt-project.atlassian.net/browse/QTBUG-143470\n> or \n> Bug: https://qt-project.atlassian.net/browse/QTBUG-143470\n\nBug is mostly synonymous for Closes:. I'd use Link:.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> > \n> > >   # gcc 12 and 13 output a false positive variable shadowing warning with Qt","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D6A5C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 13:15:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDDDF61FCB;\n\tWed, 28 Jan 2026 14:15:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 256C461FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 14:15:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D37B23A2;\n\tWed, 28 Jan 2026 14:14:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mtGYcsW7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769606099;\n\tbh=72wg00n9OB6m/MYlV+Jo+2PAGy2NqEgFCO9HSqRnBCk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mtGYcsW7KiGVv/33Y3Ww0oP8HxzyusBvRCd50RSAsBjp5vlZyefWt4E+W+pQsnj6N\n\t49nCzYxEk2eUdxRRsqLuscXcoA3lCEO5OZv8alS2yrK+suB0uYy1SGLh3Ofc70oRPR\n\tsFv6LdpzxO9hvCK3XTHv4yqfyFyxTZwBpJ78fK9Q=","Date":"Wed, 28 Jan 2026 15:15:34 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Subject":"Re: [PATCH] apps: qcam: Disable -Wsfinae-incomplete","Message-ID":"<20260128131534.GB3210848@killaraus>","References":"<20260128124011.104617-1-kieran.bingham@ideasonboard.com>\n\t<4dd881a9-b8ec-4298-97f6-99101200fba9@ideasonboard.com>\n\t<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<176960569326.3376561.5406319551758724008@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]