{"id":26006,"url":"https://patchwork.libcamera.org/api/patches/26006/?format=json","web_url":"https://patchwork.libcamera.org/patch/26006/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260128114402.31570-14-mzamazal@redhat.com>","date":"2026-01-28T11:44:00","name":"[v5,13/15] libcamera: ipa: simple: Set contrast metadata unconditionally","commit_ref":"c43aeaade01452007b1a0b6544355fc1010cfa2b","pull_url":null,"state":"accepted","archived":false,"hash":"7ad77f9c682c7a047a6872bfc9683f7d0faa8ead","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26006/mbox/","series":[{"id":5748,"url":"https://patchwork.libcamera.org/api/series/5748/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5748","date":"2026-01-28T11:43:47","name":"Simple pipeline IPA cleanup","version":5,"mbox":"https://patchwork.libcamera.org/series/5748/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26006/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26006/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1893C3200\n\tfor ;\n\tWed, 28 Jan 2026 11:44:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E27B61FE8;\n\tWed, 28 Jan 2026 12:44:49 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E1C061FD0\n\tfor ;\n\tWed, 28 Jan 2026 12:44:43 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-90-PrxF4spXPpu7g_QDc2WRZQ-1;\n\tWed, 28 Jan 2026 06:44:41 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id DF13D1944F12; Wed, 28 Jan 2026 11:44:39 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id B2D2719560B2; Wed, 28 Jan 2026 11:44:37 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FeXCFqjx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600682;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=2k9B05U/io3wxXZ1qBvWXjn6uBX2Bf69MxM3QNtNULg=;\n\tb=FeXCFqjxyihsjSWDJPeRh135Ag9fr/YvqNrYji0IFHS6C3N5AinCEhhMr/ijdaXu3sH3ZL\n\twMD6Ue4DHgbBcNQtuXcRkWHmB9t9ROfpC5LWTPPRB1pKHxRhfN4p4uIHqF7dVyJ28fPPvx\n\te1ZyURHbSCZ3dgbKsBZNDMZA3cUS2VU=","X-MC-Unique":"PrxF4spXPpu7g_QDc2WRZQ-1","X-Mimecast-MFC-AGG-ID":"PrxF4spXPpu7g_QDc2WRZQ_1769600680","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Robert Mader\n\t","Subject":"[PATCH v5 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","Date":"Wed, 28 Jan 2026 12:44:00 +0100","Message-ID":"<20260128114402.31570-14-mzamazal@redhat.com>","In-Reply-To":"<20260128114402.31570-1-mzamazal@redhat.com>","References":"<20260128114402.31570-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"c_-jTULAiNJxzVqY_KVRbVU4xVZNLlqUuRZAJTQAZss_1769600680","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's do the same with contrast as with other metadata.\n\nReviewed-by: Barnabás Pőcze \nReviewed-by: Robert Mader \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/adjust.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex 23f6f6ad7..acdd3f741 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n \tmetadata.set(controls::Gamma, gamma);\n \n \tconst auto &contrast = frameContext.contrast;\n-\tif (contrast)\n-\t\tmetadata.set(controls::Contrast, contrast.value());\n+\tmetadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));\n \n \tconst auto &saturation = frameContext.saturation;\n \tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n","prefixes":["v5","13/15"]}