[{"id":386,"web_url":"https://patchwork.libcamera.org/comment/386/","msgid":"<20190117204250.GD23244@pendragon.ideasonboard.com>","date":"2019-01-17T20:42:50","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jan 17, 2019 at 08:20:42PM +0000, Kieran Bingham wrote:\n> The checkstyle utility highlights some minor warnings against the logger\n> implementation.\n> \n> Fix these up.\n> \n> Fixes: edbd2059d8a4 (\"libcamera: Add initial logger\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/log.h | 6 +++---\n> src/libcamera/log.cpp | 2 +-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n> index c1af3741ffee..cc3f9404a3d4 100644\n> --- a/src/libcamera/include/log.h\n> +++ b/src/libcamera/include/log.h\n> @@ -23,11 +23,11 @@ class LogMessage\n> {\n> public:\n> \tLogMessage(const char *fileName, unsigned int line,\n> -\t\t LogSeverity severity);\n> -\tLogMessage(const LogMessage&) = delete;\n> +\t\t LogSeverity severity);\n> +\tLogMessage(const LogMessage &) = delete;\n> \t~LogMessage();\n> \n> -\tstd::ostream& stream() { return msgStream; }\n> +\tstd::ostream &stream() { return msgStream; }\n> \n> private:\n> \tstd::ostringstream msgStream;\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 9b2ae1bac8c8..74cba383363d 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -66,7 +66,7 @@ namespace libcamera {\n> \n> static const char *log_severity_name(LogSeverity severity)\n> {\n> -\tstatic const char * const names[] = {\n> +\tstatic const char *const names[] = {\n\nI'm not too sure about this one, but if it helps, let's change it.\n\n> \t\t\" DBG\",\n> \t\t\" INFO\",\n> \t\t\" WARN\",","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07CEF60B2D\n\tfor ;\n\tThu, 17 Jan 2019 21:42:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9063753E;\n\tThu, 17 Jan 2019 21:42:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547757770;\n\tbh=RmnQDVbyW8IPVq4ErTp8Ro5+IdkpZukSCyoX5izN2Fs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lb0ZBVFig7YIhY2An+QWpPdMLqb1XjSA1vqlGwlY6R9sFLSGjUh9QEdERpLq8AEO5\n\txkZCi3Ixezy3J1PAEIU645MjkXFPGZ68NxQXNSyBMNE1NYtpnOFY3vA6l078VOpkkr\n\to6JYX55XPGSRsaLaoVg1VtK7NeuN1nYJY8Bg9md8=","Date":"Thu, 17 Jan 2019 22:42:50 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117204250.GD23244@pendragon.ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:42:51 -0000"}},{"id":389,"web_url":"https://patchwork.libcamera.org/comment/389/","msgid":"","date":"2019-01-17T21:43:23","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/01/2019 20:42, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Jan 17, 2019 at 08:20:42PM +0000, Kieran Bingham wrote:\n>> The checkstyle utility highlights some minor warnings against the logger\n>> implementation.\n>>\n>> Fix these up.\n>>\n>> Fixes: edbd2059d8a4 (\"libcamera: Add initial logger\")\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/libcamera/include/log.h | 6 +++---\n>> src/libcamera/log.cpp | 2 +-\n>> 2 files changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n>> index c1af3741ffee..cc3f9404a3d4 100644\n>> --- a/src/libcamera/include/log.h\n>> +++ b/src/libcamera/include/log.h\n>> @@ -23,11 +23,11 @@ class LogMessage\n>> {\n>> public:\n>> \tLogMessage(const char *fileName, unsigned int line,\n>> -\t\t LogSeverity severity);\n>> -\tLogMessage(const LogMessage&) = delete;\n>> +\t\t LogSeverity severity);\n>> +\tLogMessage(const LogMessage &) = delete;\n>> \t~LogMessage();\n>> \n>> -\tstd::ostream& stream() { return msgStream; }\n>> +\tstd::ostream &stream() { return msgStream; }\n>> \n>> private:\n>> \tstd::ostringstream msgStream;\n>> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n>> index 9b2ae1bac8c8..74cba383363d 100644\n>> --- a/src/libcamera/log.cpp\n>> +++ b/src/libcamera/log.cpp\n>> @@ -66,7 +66,7 @@ namespace libcamera {\n>> \n>> static const char *log_severity_name(LogSeverity severity)\n>> {\n>> -\tstatic const char * const names[] = {\n>> +\tstatic const char *const names[] = {\n> \n> I'm not too sure about this one, but if it helps, let's change it.\n\nI had to go back and think about this... but I think I do prefer it.\n\n> \n>> \t\t\" DBG\",\n>> \t\t\" INFO\",\n>> \t\t\" WARN\",\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78BB760B2D\n\tfor ;\n\tThu, 17 Jan 2019 22:43:25 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0508353E;\n\tThu, 17 Jan 2019 22:43:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547761405;\n\tbh=JgaVhqLKnLGuKMcRt+npyafKRGnKA2LxWxXtyREoAVo=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=db/jk3Am7XDhdDJJGT9Ohtf6k991JnDs40wHUo9jaZG2hJn3OaY91hYZMDFL9OK6g\n\tqEZHoH9Z5ld8Y42ESlyYbsBjtWgqqALjrxWybf30KxoFOMeOlr4uz2Y5Jv1KoVMoYo\n\t5fd1xsXyoZa2YsP/lJbWPU2DHsFgx0plCRQr1Fcw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-5-kieran.bingham@ideasonboard.com>\n\t<20190117204250.GD23244@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 17 Jan 2019 21:43:23 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190117204250.GD23244@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 21:43:25 -0000"}},{"id":395,"web_url":"https://patchwork.libcamera.org/comment/395/","msgid":"<20190117220201.GO6484@bigcity.dyn.berto.se>","date":"2019-01-17T22:02:01","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-01-17 20:20:42 +0000, Kieran Bingham wrote:\n> The checkstyle utility highlights some minor warnings against the logger\n> implementation.\n> \n> Fix these up.\n> \n> Fixes: edbd2059d8a4 (\"libcamera: Add initial logger\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/log.h | 6 +++---\n> src/libcamera/log.cpp | 2 +-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n> index c1af3741ffee..cc3f9404a3d4 100644\n> --- a/src/libcamera/include/log.h\n> +++ b/src/libcamera/include/log.h\n> @@ -23,11 +23,11 @@ class LogMessage\n> {\n> public:\n> \tLogMessage(const char *fileName, unsigned int line,\n> -\t\t LogSeverity severity);\n> -\tLogMessage(const LogMessage&) = delete;\n> +\t\t LogSeverity severity);\n> +\tLogMessage(const LogMessage &) = delete;\n> \t~LogMessage();\n> \n> -\tstd::ostream& stream() { return msgStream; }\n> +\tstd::ostream &stream() { return msgStream; }\n> \n> private:\n> \tstd::ostringstream msgStream;\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 9b2ae1bac8c8..74cba383363d 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -66,7 +66,7 @@ namespace libcamera {\n> \n> static const char *log_severity_name(LogSeverity severity)\n> {\n> -\tstatic const char * const names[] = {\n> +\tstatic const char *const names[] = {\n> \t\t\" DBG\",\n> \t\t\" INFO\",\n> \t\t\" WARN\",\n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46C2260B2D\n\tfor ;\n\tThu, 17 Jan 2019 23:02:03 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id v1-v6so9954726ljd.0\n\tfor ;\n\tThu, 17 Jan 2019 14:02:03 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tc19sm485653lfg.86.2019.01.17.14.02.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 17 Jan 2019 14:02:01 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xxvgl9fVJ1nqMju12Kx53vnS2ai6V/8cx5ZGa54Slk0=;\n\tb=dNeLdpQYflaAYXizhmuqf2qLtuAn/Akmf/i/Sa0h4kIdgnede2RVl3k4Xr+yPPYr0v\n\ttLvDo2F8KTv9/8HdOm73FLS0rlJl3bKrfnZOpLR9pRBACB7AhucuvCCtfL3wGvB6iqxC\n\tmI5rzWROrXOFkJHxeF+z+4fg/plwOBk4xdqL+nvkhbo6CHaYLQqB+7ULvmIHmHB3iJwf\n\tl3toAn4t/qMvWqU04aYqR8PU5hQax5K/QzOoyyOc9mBdetG2P9xrZuneQEk1muZvPCXI\n\tn7gsFXvb/26o0bHsrzyxNsLtJYFnAlrV42hHt0aE1J1qxcnnEGqP9RTwBpdc8PTWx/Z+\n\tpnCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xxvgl9fVJ1nqMju12Kx53vnS2ai6V/8cx5ZGa54Slk0=;\n\tb=S90uXA0wB3IxGY6Lcdcsr0KijXf+NRHqHcs3VyrxWjsOVPcXJfxSMW+yGUC4c/w2qt\n\tQdv1Q5kea7FPvjff/e4AaZ6n5dlMDBeiZif6QB/biUwYBC5ilMWLXlmgB1fuISLBWVri\n\tz1QrSfzknrikdxQCIVRuf0sEVYh6yOcZWRK4Z+uau6jlH9JiA0OihWkI2GRmKxjozTyy\n\t4oiE1TBp1DEMHYhgKyVboZufxpwKqg8M/zWnZAwVG2hkPXmpV7A/GH0fVkL1njsuMtUv\n\t0WxFG1Fxx/lLT3WtThFHP7F71DOmwfkCNelvhj0/OcUUZtOTNMj2z0kn+Zwc5xw5wETu\n\tIdYg==","X-Gm-Message-State":"AJcUukdAEVUIXxMCoXoWhcFuBdyfWsbNhreuxQfFLL2qT7cadXBs3SZg\n\t8sR3n4atIuZiASn8UhxK8+vUNA==","X-Google-Smtp-Source":"ALg8bN7u62qWeqtqLwkpXBFjQNrMj33cnQxDeSbqPvXyIiYjjo9ks2X3md9KDN3/HGUyL36HEBrqZA==","X-Received":"by 2002:a2e:4218:: with SMTP id\n\tp24-v6mr10642734lja.58.1547762522651; \n\tThu, 17 Jan 2019 14:02:02 -0800 (PST)","Date":"Thu, 17 Jan 2019 23:02:01 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117220201.GO6484@bigcity.dyn.berto.se>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 22:02:03 -0000"}}]