{"id":260,"url":"https://patchwork.libcamera.org/api/patches/260/?format=json","web_url":"https://patchwork.libcamera.org/patch/260/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","date":"2019-01-17T20:20:42","name":"[libcamera-devel,4/5] libcamera: log: Fix coding style warnings","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fbc2bcdf969743cc3db6233a13679dd671223f1b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/260/mbox/","series":[{"id":87,"url":"https://patchwork.libcamera.org/api/series/87/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=87","date":"2019-01-17T20:20:38","name":"General fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/87/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/260/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/260/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFC4060CA0\n\tfor ;\n\tThu, 17 Jan 2019 21:20:49 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E750558;\n\tThu, 17 Jan 2019 21:20:49 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547756449;\n\tbh=Ovaadbu20ctBxwhPphEykrE8yWk+xYxrxdgU8sbZ7rU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jm2BR1vhUq0n8Qs+eatHeOB4zThjIY4xI5WWmtZCiDD3xhFt4cc+4VaMl71FDCWG0\n\tw3CzHKwSRezXoBXue2+ehRJZyWY7HWj/cTmnbNCehfoptdqMdaE323i9PMmcx1bZTY\n\tp0sXd/PCVQxs2rO12K+yUdUXgH9AKmPG7glFnYys=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Thu, 17 Jan 2019 20:20:42 +0000","Message-Id":"<20190117202043.21420-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style\n\twarnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:20:50 -0000"},"content":"The checkstyle utility highlights some minor warnings against the logger\nimplementation.\n\nFix these up.\n\nFixes: edbd2059d8a4 (\"libcamera: Add initial logger\")\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/include/log.h | 6 +++---\n src/libcamera/log.cpp | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\nindex c1af3741ffee..cc3f9404a3d4 100644\n--- a/src/libcamera/include/log.h\n+++ b/src/libcamera/include/log.h\n@@ -23,11 +23,11 @@ class LogMessage\n {\n public:\n \tLogMessage(const char *fileName, unsigned int line,\n-\t\t LogSeverity severity);\n-\tLogMessage(const LogMessage&) = delete;\n+\t\t LogSeverity severity);\n+\tLogMessage(const LogMessage &) = delete;\n \t~LogMessage();\n \n-\tstd::ostream& stream() { return msgStream; }\n+\tstd::ostream &stream() { return msgStream; }\n \n private:\n \tstd::ostringstream msgStream;\ndiff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex 9b2ae1bac8c8..74cba383363d 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -66,7 +66,7 @@ namespace libcamera {\n \n static const char *log_severity_name(LogSeverity severity)\n {\n-\tstatic const char * const names[] = {\n+\tstatic const char *const names[] = {\n \t\t\" DBG\",\n \t\t\" INFO\",\n \t\t\" WARN\",\n","prefixes":["libcamera-devel","4/5"]}