[{"id":39,"web_url":"https://patchwork.libcamera.org/comment/39/","msgid":"<20181211081420.GB5491@w540>","date":"2018-12-11T08:14:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix miscellaneous\n\tcoding style issues","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n thanks\n\nOn Tue, Dec 11, 2018 at 12:03:30AM +0200, Laurent Pinchart wrote:\n> Those issues were pointed out during review.\n>\n> Signed-off-by: Laurent Pinchart \n\nAcked-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/include/log.h | 2 +-\n> src/libcamera/log.cpp | 8 ++++----\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n> index 76acd1520868..41f8a756bf0c 100644\n> --- a/src/libcamera/include/log.h\n> +++ b/src/libcamera/include/log.h\n> @@ -33,6 +33,6 @@ private:\n>\n> #define LOG(severity) LogMessage(__FILE__, __LINE__, Log##severity).stream()\n>\n> -};\n> +} /* namespace libcamera */\n>\n> #endif /* __LIBCAMERA_LOG_H__ */\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 18ccfa32d8b4..2a3824972c9a 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2018, Google Inc.\n> *\n> - * log.h - Logging infrastructure\n> + * log.cpp - Logging infrastructure\n> */\n>\n> #include \n> @@ -14,7 +14,7 @@\n> #include \"utils.h\"\n>\n> /**\n> - * \\file log.h\n> + * \\file log.cpp\n> * \\brief Logging infrastructure\n> */\n>\n> @@ -48,7 +48,7 @@ static const char *log_severity_name(LogSeverity severity)\n> \t\t\" ERR\",\n> \t};\n>\n> -\tif ((unsigned int)severity < ARRAY_SIZE(names))\n> +\tif (static_cast(severity) < ARRAY_SIZE(names))\n> \t\treturn names[severity];\n> \telse\n> \t\treturn \"UNKN\";\n> @@ -78,4 +78,4 @@ LogMessage::~LogMessage()\n> \tfflush(stderr);\n> }\n>\n> -};\n> +} /* namespace libcamera */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08A9D60A71\n\tfor ;\n\tTue, 11 Dec 2018 09:14:22 +0100 (CET)","from w540 (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 63803FF80E;\n\tTue, 11 Dec 2018 08:14:22 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 11 Dec 2018 09:14:20 +0100","From":"jacopo mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20181211081420.GB5491@w540>","References":"<20181210220330.20774-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"TakKZr9L6Hm6aLOc\"","Content-Disposition":"inline","In-Reply-To":"<20181210220330.20774-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix miscellaneous\n\tcoding style issues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Dec 2018 08:14:23 -0000"}}]