[{"id":37897,"web_url":"https://patchwork.libcamera.org/comment/37897/","msgid":"<aXMqmX2N0bSWU8Yf@zed>","date":"2026-01-23T08:02:22","subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Rui\n\nOn Thu, Jan 22, 2026 at 06:47:05PM -0500, Rui Wang wrote:\n> Register NoiseReductionMode controls based on the tuning data and default\n> to the active DPF mode. Remove the static NoiseReductionMode entry from\n> the IPA control map now that DPF owns its registration.\n\nI might have missed why you need a separate function to re-loop over\nmodes instead of doing this when parsing modes.\n\nWas the patch I sent not functional ? Do you prefer a different\napproach ? Can you share your design decisions or simply reply to that\nemail if you didn't agree with the suggestion explaining why ?\n\n>\n> Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>\n> Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n>\n> ---\n>   changelog :\n>     --No change since v10\n> ---\n>  src/ipa/rkisp1/algorithms/dpf.cpp | 21 +++++++++++++++++++++\n>  src/ipa/rkisp1/algorithms/dpf.h   |  1 +\n>  src/ipa/rkisp1/rkisp1.cpp         |  1 -\n>  3 files changed, 22 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index 78a79fa5..282b8672 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -52,6 +52,9 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n>  \tif (ret)\n>  \t\treturn ret;\n>\n> +\t/* Register available controls. */\n> +\tregisterControls(context);\n> +\n>  \treturn 0;\n>  }\n>\n> @@ -112,6 +115,24 @@ int Dpf::parseConfig(const YamlObject &tuningData)\n>  \treturn 0;\n>  }\n>\n> +void Dpf::registerControls(IPAContext &context)\n> +{\n> +\t/*\n> +\t * Populate the control map with the available noise reduction modes.\n> +\t * This allows applications to query and select from the modes defined\n> +\t * in the tuning data.\n> +\t */\n> +\tstd::vector<ControlValue> modes{ controls::draft::NoiseReductionModeOff };\n> +\tfor (const auto &mode : noiseReductionModes_) {\n> +\t\tmodes.emplace_back(mode.modeValue);\n> +\t}\n> +\t/*\n> +\t * Set the default mode to the active mode.\n> +\t */\n> +\tcontext.ctrlMap[&controls::draft::NoiseReductionMode] =\n> +\t\tControlInfo(modes, activeMode_->modeValue);\n> +}\n> +\n>  int Dpf::parseSingleConfig(const YamlObject &tuningData,\n>  \t\t\t   rkisp1_cif_isp_dpf_config &config,\n>  \t\t\t   rkisp1_cif_isp_dpf_strength_config &strengthConfig)\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\n> index 11fc88e4..43effcbe 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.h\n> +++ b/src/ipa/rkisp1/algorithms/dpf.h\n> @@ -37,6 +37,7 @@ private:\n>  \t};\n>\n>  \tint parseConfig(const YamlObject &tuningData);\n> +\tvoid registerControls(IPAContext &context);\n>  \tint parseSingleConfig(const YamlObject &tuningData,\n>  \t\t\t      rkisp1_cif_isp_dpf_config &config,\n>  \t\t\t      rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index fbcc3910..402ed62c 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -120,7 +120,6 @@ const IPAHwSettings ipaHwSettingsV12{\n>  /* List of controls handled by the RkISP1 IPA */\n>  const ControlInfoMap::Map rkisp1Controls{\n>  \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n> -\t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n>  };\n>\n>  } /* namespace */\n> --\n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 625DCBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jan 2026 08:02:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C96461FC4;\n\tFri, 23 Jan 2026 09:02:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 796C561F61\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jan 2026 09:02:26 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D35A8FA;\n\tFri, 23 Jan 2026 09:01:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jD6aOJd0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769155313;\n\tbh=VRFuXYyP2CkqUk5IBF4IPC6rZ8bsQ3MW8FrFbCv/9aM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jD6aOJd0pL8QoUXT5m53ba6+dhVNCnEm2ghoPmVQF+lLuHt46VarzDJcjfY+2jSVf\n\tKKMKKSFWJiL0Z5g5MPT54r3U2eneRD2SAjN2+I2Vr+s5oqz3ycPkPToTC4ehtkLTsY\n\t/QEDtsVz6xmYpIjtabbl7uhNL1JMpVhdSBQhopWY=","Date":"Fri, 23 Jan 2026 09:02:22 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Rui Wang <rui.wang@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tIsaac Scott <isaac.scott@ideasonboard.com>","Subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","Message-ID":"<aXMqmX2N0bSWU8Yf@zed>","References":"<20260122234709.2061370-1-rui.wang@ideasonboard.com>\n\t<20260122234709.2061370-4-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260122234709.2061370-4-rui.wang@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37923,"web_url":"https://patchwork.libcamera.org/comment/37923/","msgid":"<b376825d-4a7e-47cc-94e2-6277defeac88@ideasonboard.com>","date":"2026-01-23T16:56:59","subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2026-01-23 03:02, Jacopo Mondi wrote:\n> Hi Rui\n>\n> On Thu, Jan 22, 2026 at 06:47:05PM -0500, Rui Wang wrote:\n>> Register NoiseReductionMode controls based on the tuning data and default\n>> to the active DPF mode. Remove the static NoiseReductionMode entry from\n>> the IPA control map now that DPF owns its registration.\n> I might have missed why you need a separate function to re-loop over\n> modes instead of doing this when parsing modes.\n>\n> Was the patch I sent not functional ? Do you prefer a different\n> approach ? Can you share your design decisions or simply reply to that\n> email if you didn't agree with the suggestion explaining why ?\n\nHello Jacopo,\n\n\nThe patch you sharing of add ctrlMap is working ,\n\nI am thinking all controls can be declare in registerControls , and in \nfuture manual mode\n\nwould explicit many controls will add here. but actually , it will \nintroduce a looper to push back\n\neach element from noiseReductionModes_ to control map.and it can also \ndecouple the ctrlMap\n\nwith tuning config\n\nRui\n\n>\n>> Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>\n>> Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n>>\n>> ---\n>>    changelog :\n>>      --No change since v10\n>> ---\n>>   src/ipa/rkisp1/algorithms/dpf.cpp | 21 +++++++++++++++++++++\n>>   src/ipa/rkisp1/algorithms/dpf.h   |  1 +\n>>   src/ipa/rkisp1/rkisp1.cpp         |  1 -\n>>   3 files changed, 22 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n>> index 78a79fa5..282b8672 100644\n>> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n>> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n>> @@ -52,6 +52,9 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n>>   \tif (ret)\n>>   \t\treturn ret;\n>>\n>> +\t/* Register available controls. */\n>> +\tregisterControls(context);\n>> +\n>>   \treturn 0;\n>>   }\n>>\n>> @@ -112,6 +115,24 @@ int Dpf::parseConfig(const YamlObject &tuningData)\n>>   \treturn 0;\n>>   }\n>>\n>> +void Dpf::registerControls(IPAContext &context)\n>> +{\n>> +\t/*\n>> +\t * Populate the control map with the available noise reduction modes.\n>> +\t * This allows applications to query and select from the modes defined\n>> +\t * in the tuning data.\n>> +\t */\n>> +\tstd::vector<ControlValue> modes{ controls::draft::NoiseReductionModeOff };\n>> +\tfor (const auto &mode : noiseReductionModes_) {\n>> +\t\tmodes.emplace_back(mode.modeValue);\n>> +\t}\n>> +\t/*\n>> +\t * Set the default mode to the active mode.\n>> +\t */\n>> +\tcontext.ctrlMap[&controls::draft::NoiseReductionMode] =\n>> +\t\tControlInfo(modes, activeMode_->modeValue);\n>> +}\n>> +\n>>   int Dpf::parseSingleConfig(const YamlObject &tuningData,\n>>   \t\t\t   rkisp1_cif_isp_dpf_config &config,\n>>   \t\t\t   rkisp1_cif_isp_dpf_strength_config &strengthConfig)\n>> diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\n>> index 11fc88e4..43effcbe 100644\n>> --- a/src/ipa/rkisp1/algorithms/dpf.h\n>> +++ b/src/ipa/rkisp1/algorithms/dpf.h\n>> @@ -37,6 +37,7 @@ private:\n>>   \t};\n>>\n>>   \tint parseConfig(const YamlObject &tuningData);\n>> +\tvoid registerControls(IPAContext &context);\n>>   \tint parseSingleConfig(const YamlObject &tuningData,\n>>   \t\t\t      rkisp1_cif_isp_dpf_config &config,\n>>   \t\t\t      rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n>> index fbcc3910..402ed62c 100644\n>> --- a/src/ipa/rkisp1/rkisp1.cpp\n>> +++ b/src/ipa/rkisp1/rkisp1.cpp\n>> @@ -120,7 +120,6 @@ const IPAHwSettings ipaHwSettingsV12{\n>>   /* List of controls handled by the RkISP1 IPA */\n>>   const ControlInfoMap::Map rkisp1Controls{\n>>   \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n>> -\t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n>>   };\n>>\n>>   } /* namespace */\n>> --\n>> 2.43.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D39EBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jan 2026 16:57:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A06BD61FC9;\n\tFri, 23 Jan 2026 17:57:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 461D2615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jan 2026 17:57:12 +0100 (CET)","from [192.168.31.114] (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17C16103D;\n\tFri, 23 Jan 2026 17:56:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dojFIYmZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769187398;\n\tbh=ljvlWiZC0+2poUG2qlPAth6O2IqRQI8kUYVtTnR+WLc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=dojFIYmZZ6HMxcITP33MCXaGEge0ywEw+ShgyhN5mNAvb95tWhTHmnPVFqg0kUvPZ\n\tFvoFTtDYzWyHES3+YqCBVBK82psJX6pUsKpmt8nISfQoK6tgt/NDlcPNZRgb2I6wlV\n\tiuLERjaojOBllBvXwC69xAYfPRh5ceO/bu3YfkwQ=","Message-ID":"<b376825d-4a7e-47cc-94e2-6277defeac88@ideasonboard.com>","Date":"Fri, 23 Jan 2026 11:56:59 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tIsaac Scott <isaac.scott@ideasonboard.com>","References":"<20260122234709.2061370-1-rui.wang@ideasonboard.com>\n\t<20260122234709.2061370-4-rui.wang@ideasonboard.com>\n\t<aXMqmX2N0bSWU8Yf@zed>","Content-Language":"en-US","From":"rui wang <rui.wang@ideasonboard.com>","In-Reply-To":"<aXMqmX2N0bSWU8Yf@zed>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38062,"web_url":"https://patchwork.libcamera.org/comment/38062/","msgid":"<bd834592-ee8a-4c57-a93f-fe42ea07a013@ideasonboard.com>","date":"2026-02-03T18:30:51","subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2026-01-23 03:02, Jacopo Mondi wrote:\n> Hi Rui\n>\n> On Thu, Jan 22, 2026 at 06:47:05PM -0500, Rui Wang wrote:\n>> Register NoiseReductionMode controls based on the tuning data and default\n>> to the active DPF mode. Remove the static NoiseReductionMode entry from\n>> the IPA control map now that DPF owns its registration.\n> I might have missed why you need a separate function to re-loop over\n> modes instead of doing this when parsing modes.\n>\n> Was the patch I sent not functional ? Do you prefer a different\n> approach ? Can you share your design decisions or simply reply to that\n> email if you didn't agree with the suggestion explaining why ?\n\nHello Jacopo,\n\nyour shared patch work in agc component.\n\n  yes , registerControl would loop the map  again\n\nI am considering about adding all dpf regs into control map for manual \nmode , that's why I add this function here.\n\nand all controls register would be in one function.\n\nand if you think it is redudant in current stage. I will move it into \nmap parse function  to reduce one time loop.\n\n\n\n>\n>> Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>\n>> Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n>>\n>> ---\n>>    changelog :\n>>      --No change since v10\n>> ---\n>>   src/ipa/rkisp1/algorithms/dpf.cpp | 21 +++++++++++++++++++++\n>>   src/ipa/rkisp1/algorithms/dpf.h   |  1 +\n>>   src/ipa/rkisp1/rkisp1.cpp         |  1 -\n>>   3 files changed, 22 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n>> index 78a79fa5..282b8672 100644\n>> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n>> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n>> @@ -52,6 +52,9 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n>>   \tif (ret)\n>>   \t\treturn ret;\n>>\n>> +\t/* Register available controls. */\n>> +\tregisterControls(context);\n>> +\n>>   \treturn 0;\n>>   }\n>>\n>> @@ -112,6 +115,24 @@ int Dpf::parseConfig(const YamlObject &tuningData)\n>>   \treturn 0;\n>>   }\n>>\n>> +void Dpf::registerControls(IPAContext &context)\n>> +{\n>> +\t/*\n>> +\t * Populate the control map with the available noise reduction modes.\n>> +\t * This allows applications to query and select from the modes defined\n>> +\t * in the tuning data.\n>> +\t */\n>> +\tstd::vector<ControlValue> modes{ controls::draft::NoiseReductionModeOff };\n>> +\tfor (const auto &mode : noiseReductionModes_) {\n>> +\t\tmodes.emplace_back(mode.modeValue);\n>> +\t}\n>> +\t/*\n>> +\t * Set the default mode to the active mode.\n>> +\t */\n>> +\tcontext.ctrlMap[&controls::draft::NoiseReductionMode] =\n>> +\t\tControlInfo(modes, activeMode_->modeValue);\n>> +}\n>> +\n>>   int Dpf::parseSingleConfig(const YamlObject &tuningData,\n>>   \t\t\t   rkisp1_cif_isp_dpf_config &config,\n>>   \t\t\t   rkisp1_cif_isp_dpf_strength_config &strengthConfig)\n>> diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\n>> index 11fc88e4..43effcbe 100644\n>> --- a/src/ipa/rkisp1/algorithms/dpf.h\n>> +++ b/src/ipa/rkisp1/algorithms/dpf.h\n>> @@ -37,6 +37,7 @@ private:\n>>   \t};\n>>\n>>   \tint parseConfig(const YamlObject &tuningData);\n>> +\tvoid registerControls(IPAContext &context);\n>>   \tint parseSingleConfig(const YamlObject &tuningData,\n>>   \t\t\t      rkisp1_cif_isp_dpf_config &config,\n>>   \t\t\t      rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n>> index fbcc3910..402ed62c 100644\n>> --- a/src/ipa/rkisp1/rkisp1.cpp\n>> +++ b/src/ipa/rkisp1/rkisp1.cpp\n>> @@ -120,7 +120,6 @@ const IPAHwSettings ipaHwSettingsV12{\n>>   /* List of controls handled by the RkISP1 IPA */\n>>   const ControlInfoMap::Map rkisp1Controls{\n>>   \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n>> -\t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n>>   };\n>>\n>>   } /* namespace */\n>> --\n>> 2.43.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C79D3BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  3 Feb 2026 18:31:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E532E62019;\n\tTue,  3 Feb 2026 19:31:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA70261A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  3 Feb 2026 19:31:04 +0100 (CET)","from [192.168.31.114] (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD4191C6;\n\tTue,  3 Feb 2026 19:30:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MCMvEYWo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770143423;\n\tbh=aqkqXa81e27nvYjTIso/vD0mhEJapTIoP/ibwX5Vg9E=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=MCMvEYWoN+0YYV92NfZ0hT8a2/XiklL4qF5tSliPXqAijMZzm/D6yS92ESZSq403R\n\tk5kAgnjQjvCY6x5HvJH88THRXn2I3MjbROVx4FRviuJwgf8MgNVw/ucGxOyN+FQFrr\n\t0F9WFmOk6IYfYpv7ms+NWJALFiqNJZgvBpMPGwDw=","Message-ID":"<bd834592-ee8a-4c57-a93f-fe42ea07a013@ideasonboard.com>","Date":"Tue, 3 Feb 2026 13:30:51 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v11 3/7] ipa: rkisp1: algorithms: register noise\n\treduction controls","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tIsaac Scott <isaac.scott@ideasonboard.com>","References":"<20260122234709.2061370-1-rui.wang@ideasonboard.com>\n\t<20260122234709.2061370-4-rui.wang@ideasonboard.com>\n\t<aXMqmX2N0bSWU8Yf@zed>","Content-Language":"en-US","From":"rui wang <rui.wang@ideasonboard.com>","In-Reply-To":"<aXMqmX2N0bSWU8Yf@zed>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]