[{"id":37951,"web_url":"https://patchwork.libcamera.org/comment/37951/","msgid":"<4d0e3ea3-c245-474a-8946-9f569f52222c@collabora.com>","date":"2026-01-26T15:27:53","subject":"Re: [PATCH v4 15/15] libcamera: ipa: simple: Disable Ccm algorithm\n\tby default again","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Reviewed-by: Robert Mader \n\nOn 22.01.26 17:19, Milan Zamazal wrote:\n> The default CCM in uncalibrated.yaml is just an identity transformation\n> and has been enabled by default only to always provide a correction\n> matrix to GPU ISP. It slows down CPU ISP when CCM is not used.\n>\n> Now, when a default correction matrix is always provided to GPU ISP, we\n> can disable the Ccm algorithm in uncalibrated.yaml again. The check for\n> ccmEnabled in GPU ISP is no longer needed and it must be removed in\n> order not to fail when Ccm algorithm is not enabled. ccmEnabled flag is\n> still needed in CPU ISP where the processing differs based on whether\n> CCM is present or not.\n>\n> Reviewed-by: Barnabás Pőcze \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------\n> src/libcamera/software_isp/debayer_egl.cpp | 5 +----\n> 2 files changed, 7 insertions(+), 10 deletions(-)\n>\n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index c6feda36d..fc90ca526 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -8,12 +8,12 @@ algorithms:\n> # Color correction matrices can be defined here. The CCM algorithm\n> # has a significant performance impact, and should only be enabled\n> # if tuned.\n> - - Ccm:\n> - ccms:\n> - - ct: 6500\n> - ccm: [ 1, 0, 0,\n> - 0, 1, 0,\n> - 0, 0, 1]\n> + # - Ccm:\n> + # ccms:\n> + # - ct: 6500\n> + # ccm: [ 1, 0, 0,\n> + # 0, 1, 0,\n> + # 0, 0, 1]\n> - Adjust:\n> - Agc:\n> ...\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index af04d60ca..3ed9b93df 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -288,7 +288,7 @@ unsigned int DebayerEGL::frameSize()\n> \n> int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \t\t\t const std::vector> &outputCfgs,\n> -\t\t\t bool ccmEnabled)\n> +\t\t\t [[maybe_unused]] bool ccmEnabled)\n> {\n> \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> \t\treturn -EINVAL;\n> @@ -296,9 +296,6 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \tif (stats_->configure(inputCfg) != 0)\n> \t\treturn -EINVAL;\n> \n> -\tif (!ccmEnabled)\n> -\t\treturn -EINVAL;\n> -\n> \tconst Size &stats_pattern_size = stats_->patternSize();\n> \tif (inputConfig_.patternSize.width != stats_pattern_size.width ||\n> \t inputConfig_.patternSize.height != stats_pattern_size.height) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCE38C3200\n\tfor ;\n\tMon, 26 Jan 2026 15:28:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0378061FC7;\n\tMon, 26 Jan 2026 16:28:04 +0100 (CET)","from sender4-pp-e109.zoho.com (sender4-pp-e109.zoho.com\n\t[136.143.188.109])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5883B61A35\n\tfor ;\n\tMon, 26 Jan 2026 16:28:02 +0100 (CET)","by mx.zohomail.com with SMTPS id 1769441275701710.6324147869874;\n\tMon, 26 Jan 2026 07:27:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"E+dkzozI\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1769441278; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=eDg/yPrg7NMZQ2PDUakSO2h5uOPyF0symYvPlUMshOWnkaVWT7UKnlCgLy4cIqAdwsJCuRDd2Uu0ZcX8vlq4zrDqSP5Y1ZgG2fpwcyJECljv72RQKSulCGIx9ycG/THK/nu0VJ4K+ssrUTViHgQoXTPSowKzNgYqFy4izuRRPrs=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1769441278;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=LEZNsJvBvSR0e9JbBKst91LmdmSKghnBwM+2GXIsaB4=; \n\tb=T/L3IQAfEr0guSN0YiomHQuUgSyr4m3mhTRlqaSwizRaPzHgT+lAdGOOd2lI7grPfY978MZSOft/+yetgWzVk0zVh3axWrHtyzk4gSSOHQn7kYiwFZbKHe1jwkir4G5mEDiSXe7zYgL6FzYuU35ufR9UxFlZxbfPxrUZ57AsYI0=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1769441278;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=LEZNsJvBvSR0e9JbBKst91LmdmSKghnBwM+2GXIsaB4=;\n\tb=E+dkzozIZiyUwJpRjzj+O+NaW6Rpm89NBAGu2tZWOTt3xT8CI9fdtvXql0toQ3uh\n\tw9fVsxjnq+4Na3LST5Ak1JeppwbAu9X00CmiBqIMNeZrd2UqbA4jHQ152iBxfD6XQSu\n\tE/zE5+1EmdZmLIcCMg3S/sget0Ea6AQqy/cbilu4=","Message-ID":"<4d0e3ea3-c245-474a-8946-9f569f52222c@collabora.com>","Date":"Mon, 26 Jan 2026 16:27:53 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 15/15] libcamera: ipa: simple: Disable Ccm algorithm\n\tby default again","To":"libcamera-devel@lists.libcamera.org","References":"<20260122161935.208562-1-mzamazal@redhat.com>\n\t<20260122161935.208562-16-mzamazal@redhat.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20260122161935.208562-16-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]