[{"id":37946,"web_url":"https://patchwork.libcamera.org/comment/37946/","msgid":"<46222a60-d4ac-4f57-aefe-7d9b765b5fc3@ideasonboard.com>","date":"2026-01-26T14:48:30","subject":"Re: [PATCH v4 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 22. 17:19 keltezéssel, Milan Zamazal írta:\n> Let's do the same with contrast as with other metadata.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/simple/algorithms/adjust.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\n> index 23f6f6ad7..acdd3f741 100644\n> --- a/src/ipa/simple/algorithms/adjust.cpp\n> +++ b/src/ipa/simple/algorithms/adjust.cpp\n> @@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n> \tmetadata.set(controls::Gamma, gamma);\n> \n> \tconst auto &contrast = frameContext.contrast;\n> -\tif (contrast)\n> -\t\tmetadata.set(controls::Contrast, contrast.value());\n> +\tmetadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));\n> \n> \tconst auto &saturation = frameContext.saturation;\n> \tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C60FC3200\n\tfor ;\n\tMon, 26 Jan 2026 14:48:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3435361FCB;\n\tMon, 26 Jan 2026 15:48:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEC2961A35\n\tfor ;\n\tMon, 26 Jan 2026 15:48:33 +0100 (CET)","from [192.168.33.36] (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93C9F22F;\n\tMon, 26 Jan 2026 15:47:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uvSNsKme\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769438878;\n\tbh=kqhovhCdMay9MznKNKHbBXjfFjcpIBrYbtL1vGojNd8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=uvSNsKmeNCZlHcC5wdw5WvF+3cXKfPdA5zHkrNuvQnvpSkRlTVTrt6a1StkRV/DIJ\n\tPi+oNDYbrPZnxM93TbBVz/KBed7Koj5oW+nYCyB2uKI/as1OrOCLXSnzsxFia6IaK+\n\tk2DX5/C8y2bl9HoN9eDrLFL5G7D6wK/02vRAL5NA=","Message-ID":"<46222a60-d4ac-4f57-aefe-7d9b765b5fc3@ideasonboard.com>","Date":"Mon, 26 Jan 2026 15:48:30 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","References":"<20260122161935.208562-1-mzamazal@redhat.com>\n\t\n\t<20260122161935.208562-14-mzamazal@redhat.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260122161935.208562-14-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37950,"web_url":"https://patchwork.libcamera.org/comment/37950/","msgid":"<082921b1-a640-41a4-9be6-95dbef0a5c5c@collabora.com>","date":"2026-01-26T15:19:07","subject":"Re: [PATCH v4 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Reviewed-by: Robert Mader \n\nOn 22.01.26 17:19, Milan Zamazal wrote:\n> Let's do the same with contrast as with other metadata.\n>\n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/algorithms/adjust.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\n> index 23f6f6ad7..acdd3f741 100644\n> --- a/src/ipa/simple/algorithms/adjust.cpp\n> +++ b/src/ipa/simple/algorithms/adjust.cpp\n> @@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n> \tmetadata.set(controls::Gamma, gamma);\n> \n> \tconst auto &contrast = frameContext.contrast;\n> -\tif (contrast)\n> -\t\tmetadata.set(controls::Contrast, contrast.value());\n> +\tmetadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));\n> \n> \tconst auto &saturation = frameContext.saturation;\n> \tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37DD0C3220\n\tfor ;\n\tMon, 26 Jan 2026 15:19:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E048761FCF;\n\tMon, 26 Jan 2026 16:19:16 +0100 (CET)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8822E61A35\n\tfor ;\n\tMon, 26 Jan 2026 16:19:15 +0100 (CET)","by mx.zohomail.com with SMTPS id 1769440750215296.06766086276207; \n\tMon, 26 Jan 2026 07:19:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"iQN8nwkL\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1769440752; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=biOVRNRh63hcU3FECOAWlwzP6B/rPU9Sj2bJCZssFR0LPw9A7qC5reDRwvfrI6LXxvkVjka9Oh6vN5LohSKhSxee+wpnjgknIUP4g6VyGOaevHXd+mSP+hSWGkF3K8e+ZDaHOc0aGQdKsMYQdFVibBsOVjDF85CUqYrsapWdUtc=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1769440752;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=UC4Q07RQq9IEDw2G4OBDQAQ6pFBbVmUDwDAlQW8rIWM=; \n\tb=dHAW1l1nacXEqHaElzGfpaOsSN50l3168XOyuZNlUMK64SD/rbnMLJLCTrSA5AfUPB5feHCMNrJrURwxwI+iIDtXX2DJqYz1/OE0fMh3q0RodMiOVTcX3XOrUBLFehZHzZQ0yBkhTo+VjLCrYqPxYkRvZyuNQij20EjgA0BKPvg=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1769440752;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=UC4Q07RQq9IEDw2G4OBDQAQ6pFBbVmUDwDAlQW8rIWM=;\n\tb=iQN8nwkLCITVrGMmbWSUlPhj0Nt29XUdGmHRMz3aqQrJboGS8fdvugZKxq/qA0Gp\n\tWCtbH/4DBlFSIQgU4JoFJhFSb3j9wwBRsqA98kmRBEX6vfBa6C3o1/wtjS+I8PzdGEu\n\tyLW8e3/iFbddvWSg3zamHSCvdEp8kKwQCaQJLJYQ=","Message-ID":"<082921b1-a640-41a4-9be6-95dbef0a5c5c@collabora.com>","Date":"Mon, 26 Jan 2026 16:19:07 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 13/15] libcamera: ipa: simple: Set contrast metadata\n\tunconditionally","To":"libcamera-devel@lists.libcamera.org","References":"<20260122161935.208562-1-mzamazal@redhat.com>\n\t<20260122161935.208562-14-mzamazal@redhat.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20260122161935.208562-14-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]