[{"id":37911,"web_url":"https://patchwork.libcamera.org/comment/37911/","msgid":"<176917777283.302817.13975214132894417354@localhost>","date":"2026-01-23T14:16:12","subject":"Re: [PATCH v6 10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-01-21 18:37:29)\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Reviewed-by: Isaac Scott \n> Reviewed-by: Barnabás Pőcze \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v5:\n> - Use Q<4, 7>\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..466d7a116eea 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> */\n> for (unsigned int i = 0; i < 3; i++) {\n> for (unsigned int j = 0; j < 3; j++)\n> - config.coeff[i][j] =\n> - floatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> + config.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n\nYep, that is all fine now.\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> }\n> \n> for (unsigned int i = 0; i < 3; i++)\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9CB7C3220\n\tfor ;\n\tFri, 23 Jan 2026 14:16:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57EA061FC4;\n\tFri, 23 Jan 2026 15:16:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6226615B2\n\tfor ;\n\tFri, 23 Jan 2026 15:16:15 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1d92:9f27:5dd1:dc89])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2C25B103D; \n\tFri, 23 Jan 2026 15:15:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FZd6R6J6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769177742;\n\tbh=amv/GwCF3AwDysOx9nEVeMl+exiMgU/Siz3GlQn9WjY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FZd6R6J62oKdUG0tjMejoDdblZxB2WFVetFjDpVYHtdcUNOeZVQiLcry0g+6I7W7e\n\tFa/inZS6GMk+sKsu8YINF0herYTIzjcLD9Ki223DlrEJBlgFcaYA63ytOyKM0ci3OJ\n\txidrURmgr1UkLzWHqraEiGgwW5pvFcGi37ugbhyM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260121173737.376113-11-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>\n\t<20260121173737.376113-11-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v6 10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","From":"Stefan Klug ","Cc":"Kieran Bingham , Isaac Scott\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Fri, 23 Jan 2026 15:16:12 +0100","Message-ID":"<176917777283.302817.13975214132894417354@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]