[{"id":37909,"web_url":"https://patchwork.libcamera.org/comment/37909/","msgid":"<176917547195.302817.15453055503030069418@localhost>","date":"2026-01-23T13:37:51","subject":"Re: [PATCH v6 08/16] libcamera: controls: Define a new core Hue\n\tcontrol","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nQuoting Kieran Bingham (2026-01-21 18:37:27)\n> From: \"van Veen, Stephan\" \n> \n> Define a new control to support configuration of Hue adjustments when\n> supported by the available platform.\n> \n> Reviewed-by: Isaac Scott \n> Signed-off-by: van Veen, Stephan \n> [Kieran: Rework to define as a rotation in degrees]\n\nThis looks like a leftover note?\n\n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v5:\n> - Reworked control definition and direction\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/control_ids_core.yaml | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 8e99bd84825f..67a44f8089bd 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1356,4 +1356,19 @@ controls:\n> Enable or disable lens dewarping. This control is only available if lens\n> dewarp parameters are configured in the tuning file.\n> \n> + - Hue:\n> + type: float\n> + direction: inout\n> + description: |\n> + Adjusts the image hue (colour rotation) in degrees, as defined in\n> + the HSL/HSV colour model.\n> +\n> + The value represents a rotation around the hue circle in HSL/HSV space:\n> + positive values rotate hues clockwise (for example a +60° turns\n> + Red hues to Yellow hues), and negative values rotate counter-clockwise\n> + (a -60° turns Red hues to Magenta hues).\n> +\n> + The nominal range is [-180, 180[, where 0° leaves hues unchanged and the\n\nShould that be ]-180, 180] or maybe just [-180,180]? I think I would be\npuzzled to see 180 being returned as -180 in metadata.\n\nWith the line in the commit message removed:\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> + range wraps around continuously, with 180° == -180°.\n> +\n> ...\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7C47C3220\n\tfor ;\n\tFri, 23 Jan 2026 13:37:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB9DF61FC9;\n\tFri, 23 Jan 2026 14:37:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 789FE615B2\n\tfor ;\n\tFri, 23 Jan 2026 14:37:55 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1d92:9f27:5dd1:dc89])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E4C0C9CE;\n\tFri, 23 Jan 2026 14:37:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k9dxwPPg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769175442;\n\tbh=1BsoC6K05ubCY5DgULXywe1y/MxuAGII4+wV5GZDQ1A=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=k9dxwPPgKow/7SCocGdi/+lzqSZVLBRVqbdd3OHMzG0CwgvLEvRyiTPRiW7ZE8vMh\n\tf146a6YnlqIOpLuszUf3uDinsJEAPbkQFlOhhLaRSDonYuy1o0kPIvCDI54M3vgN6c\n\tjOSSgTzFOeyahHcQSbLY+inmqcRY79sutYvqAaMo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260121173737.376113-9-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>\n\t<20260121173737.376113-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v6 08/16] libcamera: controls: Define a new core Hue\n\tcontrol","From":"Stefan Klug ","Cc":"\"van Veen, Stephan\" ,\n\tIsaac Scott ,\n\tKieran Bingham ","To":"Kieran Bingham ,\n\tlibcamera devel ","Date":"Fri, 23 Jan 2026 14:37:51 +0100","Message-ID":"<176917547195.302817.15453055503030069418@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37918,"web_url":"https://patchwork.libcamera.org/comment/37918/","msgid":"<176918151211.1693075.6732341034255394388@ping.linuxembedded.co.uk>","date":"2026-01-23T15:18:32","subject":"Re: [PATCH v6 08/16] libcamera: controls: Define a new core Hue\n\tcontrol","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2026-01-23 13:37:51)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> Quoting Kieran Bingham (2026-01-21 18:37:27)\n> > From: \"van Veen, Stephan\" \n> > \n> > Define a new control to support configuration of Hue adjustments when\n> > supported by the available platform.\n> > \n> > Reviewed-by: Isaac Scott \n> > Signed-off-by: van Veen, Stephan \n> > [Kieran: Rework to define as a rotation in degrees]\n> \n> This looks like a leftover note?\n\nNo - that's accurate. Stephan's original patch here used an integer\nvalue between -1 and 1 or such. I have changed this to be based in\ndegrees.\n\n> \n> > Signed-off-by: Kieran Bingham \n> > \n> > ---\n> > v5:\n> > - Reworked control definition and direction\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/control_ids_core.yaml | 15 +++++++++++++++\n> > 1 file changed, 15 insertions(+)\n> > \n> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > index 8e99bd84825f..67a44f8089bd 100644\n> > --- a/src/libcamera/control_ids_core.yaml\n> > +++ b/src/libcamera/control_ids_core.yaml\n> > @@ -1356,4 +1356,19 @@ controls:\n> > Enable or disable lens dewarping. This control is only available if lens\n> > dewarp parameters are configured in the tuning file.\n> > \n> > + - Hue:\n> > + type: float\n> > + direction: inout\n> > + description: |\n> > + Adjusts the image hue (colour rotation) in degrees, as defined in\n> > + the HSL/HSV colour model.\n> > +\n> > + The value represents a rotation around the hue circle in HSL/HSV space:\n> > + positive values rotate hues clockwise (for example a +60° turns\n> > + Red hues to Yellow hues), and negative values rotate counter-clockwise\n> > + (a -60° turns Red hues to Magenta hues).\n> > +\n> > + The nominal range is [-180, 180[, where 0° leaves hues unchanged and the\n> \n> Should that be ]-180, 180] or maybe just [-180,180]? I think I would be\n> puzzled to see 180 being returned as -180 in metadata.\n\nYes, good point. I'd probably prefer [-180, 180]\n\n\n \n> With the line in the commit message removed:\n> Reviewed-by: Stefan Klug \n> \n> Regards,\n> Stefan\n> \n> > + range wraps around continuously, with 180° == -180°.\n> > +\n> > ...\n> > -- \n> > 2.52.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31332C3220\n\tfor ;\n\tFri, 23 Jan 2026 15:18:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 537DA61FC4;\n\tFri, 23 Jan 2026 16:18:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DDE9615B2\n\tfor ;\n\tFri, 23 Jan 2026 16:18:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1513414C7;\n\tFri, 23 Jan 2026 16:18:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vvJSVi3E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769181482;\n\tbh=Y8CuYpOZS1C9snlJoWHBQiqNIm6GkIYJORupSDpDEo8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vvJSVi3EXjTE7aIEJ0S/loI9oUxu0QDIzCFXRbUjQ/T7PSCpXIYh/7z59xAZCQC42\n\tPWZ13XlIb9o7OQy9PO1nYZjSJ7+9HDuFUpUcI6GCeIenO/6ao1Z3mQqJPZ9hbSQgI5\n\ti7yk3YI226ujL1+0sPJ/N4lzo8dBbKCvkRCCN+M0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<176917547195.302817.15453055503030069418@localhost>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>\n\t<20260121173737.376113-9-kieran.bingham@ideasonboard.com>\n\t<176917547195.302817.15453055503030069418@localhost>","Subject":"Re: [PATCH v6 08/16] libcamera: controls: Define a new core Hue\n\tcontrol","From":"Kieran Bingham ","Cc":"\"van Veen, Stephan\" ,\n\tIsaac Scott ","To":"Stefan Klug ,\n\tlibcamera devel ","Date":"Fri, 23 Jan 2026 15:18:32 +0000","Message-ID":"<176918151211.1693075.6732341034255394388@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]